From: Devi Priya <quic_devipriy@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<linus.walleij@linaro.org>, <catalin.marinas@arm.com>,
<will@kernel.org>, <p.zabel@pengutronix.de>,
<shawnguo@kernel.org>, <arnd@arndb.de>,
<marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
<nfraprado@collabora.com>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_poovendh@quicinc.com>
Subject: Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
Date: Mon, 13 Feb 2023 19:48:54 +0530 [thread overview]
Message-ID: <ed3637e4-7a5a-55be-be49-cdb0ec978752@quicinc.com> (raw)
In-Reply-To: <20230208231412.yqp3rvokvmbb7ixi@ripper>
Thanks Bjorn for taking time to review the patch
On 2/9/2023 4:44 AM, Bjorn Andersson wrote:
> On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote:
>> +static const struct msm_pingroup ipq9574_groups[] = {
>> + PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _),
>> + PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _),
>> + PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> + PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
>> + PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _),
>> + PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _,
>> + _),
>
> Please avoid line wrapping these, it just makes it hard to read.
Yes, we have addressed this comment part of V7 series
https://lore.kernel.org/linux-arm-kernel/20230206103337.21000-5-quic_devipriy@quicinc.com/
>
> [..]
>> +};
>> +
>> +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */
>
> This seems like a property of the board, please use gpio-reserved-ranges
> in the DT node instead.
As the GPIO is forbidden on SoC IPQ9574,
we have moved it to the pinctrl driver based on the suggestions received
in V1 series
https://lore.kernel.org/linux-arm-kernel/675ed9f7-da31-6206-5089-1db22025ef4b@linaro.org/
>
> Thanks,
> Bjorn
Best Regards,
Devi Priya
next prev parent reply other threads:[~2023-02-13 14:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 12:55 [PATCH V3 0/7] Add minimal boot support for IPQ9574 devi priya
2023-01-30 12:55 ` [PATCH V3 1/7] dt-bindings: Add ipq9574 clock and reset definitions devi priya
2023-01-31 18:16 ` Krzysztof Kozlowski
2023-01-31 21:13 ` Stephen Boyd
2023-02-08 23:11 ` Bjorn Andersson
2023-02-13 14:27 ` Devi Priya
2023-02-14 3:14 ` Devi Priya
2023-01-30 12:55 ` [PATCH V3 3/7] dt-bindings: pinctrl: qcom: Add support for IPQ9574 devi priya
2023-01-31 18:12 ` Krzysztof Kozlowski
2023-01-30 12:55 ` [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver devi priya
2023-02-08 23:14 ` Bjorn Andersson
2023-02-13 14:18 ` Devi Priya [this message]
2023-01-30 12:55 ` [PATCH V3 5/7] dt-bindings: arm: qcom: Add ipq9574 compatible devi priya
2023-01-31 18:11 ` Krzysztof Kozlowski
2023-01-30 12:55 ` [PATCH V3 6/7] arm64: dts: qcom: Add ipq9574 SoC and AL02 board support devi priya
2023-01-30 23:55 ` Konrad Dybcio
2023-01-31 10:41 ` Devi Priya
2023-01-30 12:55 ` [PATCH V3 7/7] arm64: defconfig: Enable IPQ9574 SoC base configs devi priya
2023-01-31 18:10 ` [PATCH V3 0/7] Add minimal boot support for IPQ9574 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3637e4-7a5a-55be-be49-cdb0ec978752@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox