From: David Lechner <david@lechnology.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2,7/8] clk: divider: read-only divider can propagate rate change
Date: Mon, 19 Feb 2018 11:30:38 -0600 [thread overview]
Message-ID: <f1d4688b-87ce-01df-ab94-72bf20579330@lechnology.com> (raw)
In-Reply-To: <20180214134340.17242-8-jbrunet@baylibre.com>
On 02/14/2018 07:43 AM, Jerome Brunet wrote:
> When a divider clock has CLK_DIVIDER_READ_ONLY set, it means that the
> register shall be left un-touched, but it does not mean the clock
> should stop rate propagation if CLK_SET_RATE_PARENT is set
>
> This is properly handled in qcom clk-regmap-divider but it was not in
> the generic divider
>
> To fix this situation, introduce a new helper function
> divider_ro_round_rate, on the same model as divider_round_rate.
>
> Fixes: e6d5e7d90be9 ("clk-divider: Fix READ_ONLY when divider > 1")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
Working for me with the davinci clk drivers I am developing.
Tested-By: David Lechner <david@lechnology.com>
next prev parent reply other threads:[~2018-02-19 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 13:43 [PATCH v2 0/8] clk: helpers and fixes Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 1/8] clk: divider: export clk_div_mask() helper Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 2/8] clk: mux: add helper function for index/value translation Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 3/8] clk: fix determine rate error with pass-through clock Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 4/8] clk: migrate the count of orphaned clocks at init Jerome Brunet
2018-02-15 12:55 ` Marek Szyprowski
2018-03-05 9:06 ` Marek Szyprowski
2018-02-15 21:01 ` Heiko Stübner
2018-03-12 5:54 ` Michael Turquette
2018-02-14 13:43 ` [PATCH v2 5/8] clk: call the clock init() callback before any other ops callback Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 6/8] clk: fix mux clock documentation Jerome Brunet
2018-02-14 13:43 ` [PATCH v2 7/8] clk: divider: read-only divider can propagate rate change Jerome Brunet
2018-02-19 17:30 ` David Lechner [this message]
2018-02-14 13:43 ` [PATCH v2 8/8] clk: qcom: use divider_ro_round_rate helper Jerome Brunet
2018-03-11 22:31 ` [PATCH v2 0/8] clk: helpers and fixes Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d4688b-87ce-01df-ab94-72bf20579330@lechnology.com \
--to=david@lechnology.com \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox