From: Krzysztof Kozlowski <krzk@kernel.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
Date: Sun, 31 Aug 2025 13:47:14 +0200 [thread overview]
Message-ID: <f2edc075-4bad-40a6-8cb2-14d3e6f3cdaa@kernel.org> (raw)
In-Reply-To: <20250831-usb-v1-1-02ec5ea50627@gmail.com>
On 31/08/2025 13:36, Denzeel Oliva wrote:
> Add the missing LHS_ACEL clock ID for the HSI0 block. This clock is
> required for proper USB operation, as without it, USB connections fail
> with errors like device descriptor read timeouts and address response
> issues.
Incomplete feature due to missing clock is not really a fix, considering
that we add clocks piece-by-piece. Otherwise every new clock would be a fix.
Unless something else changed and the USB was working fine before?
If not, drop fixes and cc-stable from this and following commits.
>
> Fixes: 5feae3e79dbe ("dt-bindings: clock: samsung: Add Exynos990 SoC CMU bindings")
> Cc: stable@vger.kernel.org
> Signed-off-by: Denzeel Oliva <wachiturroxd150@gmail.com>
> ---
> include/dt-bindings/clock/samsung,exynos990.h | 1 +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-31 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 11:36 [PATCH 0/3] clk: samsung: exynos990: Fix USB clock support Denzeel Oliva
2025-08-31 11:36 ` [PATCH 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block Denzeel Oliva
2025-08-31 11:47 ` Krzysztof Kozlowski [this message]
2025-08-31 11:36 ` [PATCH 2/3] clk: samsung: exynos990: Add LHS_ACEL gate clock for HSI0 and update CLK_NR_TOP Denzeel Oliva
2025-08-31 11:36 ` [PATCH 3/3] clk: samsung: exynos990: Add missing USB clock registers to HSI0 Denzeel Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2edc075-4bad-40a6-8cb2-14d3e6f3cdaa@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox