From: Markus Elfring <Markus.Elfring@web.de>
To: Felix Gu <ustc.gu@gmail.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Stephen Boyd <sboyd@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: LKML <linux-kernel@vger.kernel.org>, Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] clk: tegra: tegra124-emc: Fix reference leak in tegra124_clk_register_emc()
Date: Fri, 23 Jan 2026 15:05:27 +0100 [thread overview]
Message-ID: <f31a2eda-a801-443e-9f1a-63984b9006f9@web.de> (raw)
In-Reply-To: <20260123-tegra124-v1-1-5e0a5b499d1f@gmail.com>
…
> Add the missing of_node_put() call in the error handling path.
https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/clk/tegra/clk-tegra124-emc.c#L540-L542
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc6#n526
Regards,
Markus
prev parent reply other threads:[~2026-01-23 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 12:34 [PATCH] clk: tegra: tegra124-emc: Fix reference leak in tegra124_clk_register_emc() Felix Gu
2026-01-23 14:05 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f31a2eda-a801-443e-9f1a-63984b9006f9@web.de \
--to=markus.elfring@web.de \
--cc=jonathanh@nvidia.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu@tomeuvizoso.net \
--cc=treding@nvidia.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox