From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24AEEB64DD for ; Mon, 7 Aug 2023 08:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjHGIlQ (ORCPT ); Mon, 7 Aug 2023 04:41:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjHGIlP (ORCPT ); Mon, 7 Aug 2023 04:41:15 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8F551722 for ; Mon, 7 Aug 2023 01:41:13 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5231f439968so3819812a12.0 for ; Mon, 07 Aug 2023 01:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691397672; x=1692002472; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FiBr4qX4MDbW0bMa0nAPFtANFmRzjD74lfH4gfwbvd0=; b=iWuFcNfomzzwUernqbjgnHDmBrxPuIdUyl+xhLNUfhmAumSwMafnFExzEChBJ+4S/s u4Fo6hpOHrgOqGV06jmqPnZtzU9BhNo/+5YzUOI+2hRYuG7eiw+HuJd6CsVpVZidHgNI cozJDgPKoDh9UFbmr53PofIQRClu2SWCr3ZhjbKVKE3wwo9/usoXH5N6CpLxb5njgJbs ZHZKcpMMlVDkswUaVLAIlfDLcRIdNJBtIDOYBma6dxkuwf0u9bI0xesAk9VgZY5BaFNb +9LNUl8PqK1KxO9HLlEvUcpkaZcNd2dBtGqK3yPxklaZGoDwvw0mm1qY35bJAZE5Sqbs b4OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691397672; x=1692002472; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FiBr4qX4MDbW0bMa0nAPFtANFmRzjD74lfH4gfwbvd0=; b=EOC8aqZfwj3ykIMhjeNNVcVoDbowtf5+jCsDJwUsBcoYRq/RT8oQrbUhNOM5RbQbHI pQjS3+bFZEfBSoz2UZhac8yiBXgFNAP/QeA1SrLuqd1JPA0G6CPcqXf6/vtHDhzchuuU gBzD78BR5bjmSzEQQZsXXsPEHL55V8dL5g7yRZspd44wBgZQ46U5bYOGj6f6Hm1dBowF /Z5at0Obq4q5vcBfkEmKmoI3K+XTTkcAXR/JALNGpPYmTytqV4zmZlpxUsqpVrf5Lsae GZ9ahnTVtZQGypkYv34uQbiVp3vwvTaAJj0ytmcC+2FNiseL5pVJDjMQmkzDY83qAf0P ocBg== X-Gm-Message-State: AOJu0YyiyE2/qjzTMWA/l0zQE77Hx+nQJTI3UGGVwsxUUtMH8sYR2bHQ XYZ4vh3yZYastFIcKWp88nj3DA== X-Google-Smtp-Source: AGHT+IE9kWCdDPfh1ysGqzXA+sR8LgRcYRK5cY280j1rlxyyCD7yEz8BYDWSnuErnViUGY4Xfb5luw== X-Received: by 2002:a05:6402:6c1:b0:523:2da2:1ec4 with SMTP id n1-20020a05640206c100b005232da21ec4mr4356059edy.11.1691397672230; Mon, 07 Aug 2023 01:41:12 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id b4-20020aa7dc04000000b005224f840130sm4794190edu.60.2023.08.07.01.41.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 01:41:11 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 10:41:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RESEND PATCH v3 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id To: Conor Dooley , Elaine Zhang Cc: mturquette@baylibre.com, sboyd@kernel.org, kever.yang@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, huangtao@rock-chips.com References: <20230804025101.28438-1-zhangqing@rock-chips.com> <20230804-colonial-balsamic-c97491ebec12@spud> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230804-colonial-balsamic-c97491ebec12@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 04/08/2023 17:38, Conor Dooley wrote: > On Fri, Aug 04, 2023 at 10:51:01AM +0800, Elaine Zhang wrote: >> add PCLK_VO1GRF clk id. >> >> Signed-off-by: Elaine Zhang >> --- >> include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h >> index b5616bca7b44..864a321ab362 100644 >> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h >> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h >> @@ -733,8 +733,9 @@ >> #define ACLK_AV1_PRE 718 >> #define PCLK_AV1_PRE 719 >> #define HCLK_SDIO_PRE 720 >> +#define PCLK_VO1GRF 721 >> >> -#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1) >> +#define CLK_NR_CLKS (PCLK_VO1GRF + 1) > > I only got this patch & not the rest of the series, so no idea what's > going in those patches, but since CLK_NR_CLKS was put in a dt-binding > header, is that value not now part of the ABI? Technically yes, practically does not matter because no one should use it. More bindings make the same mistakes, so it could be just dropped. Best regards, Krzysztof