From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E7FC6FA89 for ; Thu, 15 Sep 2022 13:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiIONpN (ORCPT ); Thu, 15 Sep 2022 09:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229885AbiIONoh (ORCPT ); Thu, 15 Sep 2022 09:44:37 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A4F095AD4; Thu, 15 Sep 2022 06:44:23 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28FDNX0K018936; Thu, 15 Sep 2022 13:44:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=eqP/LNdZT47fD3kG0EE6X11B/URC5CRIdurcivlHHzY=; b=Jt/hZ4EsF4/RDITXBYJiiy0LyqetB/bGJ+U+zjnthLWIPgR+Q/PbEGfAfYC38YLAJSBg sFsgmG8/71GVXzmU3MABOe5iLW/dY5Ua1eULTibUvMpdu8p1MtUGGRAkKj9iTJmdOknk 7r90AYRZVmU4TrbBVYAHZQrbTwsZka5cWoCmRBfG3Kj+M/WPhaYtQh7qDZebBdlHPJJB G+Pcretg8mcCdFARcRvMKS2M/gDwyWXavb/mBvvmxwk53rQeVdF2JWBgvOw+lLB57Swe ZAQQenIVYv2FaR2WjLdTsxB2RqoEXYByatpj9GBfVYkGc/AtL3+EA4n1w99S52BOgmXU NA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jkwjesatt-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 13:44:15 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28FDTi6E017144 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 13:29:44 GMT Received: from [10.216.56.33] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 15 Sep 2022 06:29:40 -0700 Message-ID: Date: Thu, 15 Sep 2022 18:59:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 3/3] clk: qcom: gcc-sc7280: Update the .pwrsts for usb gdsc Content-Language: en-US From: Rajendra Nayak To: Matthias Kaehlcke , Johan Hovold CC: , , , , , , , , , , References: <20220901101756.28164-1-quic_rjendra@quicinc.com> <20220901101756.28164-3-quic_rjendra@quicinc.com> <4490d181-7bf2-791c-1778-1102e9adbc25@quicinc.com> In-Reply-To: <4490d181-7bf2-791c-1778-1102e9adbc25@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 7_FXwATLe-qSASit0KWGS8jgGkqohWE5 X-Proofpoint-GUID: 7_FXwATLe-qSASit0KWGS8jgGkqohWE5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_08,2022-09-14_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=652 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000 definitions=main-2209150079 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 9/15/2022 12:55 PM, Rajendra Nayak wrote: > > > On 9/15/2022 2:53 AM, Matthias Kaehlcke wrote: >> On Wed, Sep 14, 2022 at 09:12:36AM +0200, Johan Hovold wrote: >>> On Thu, Sep 01, 2022 at 09:04:55AM -0700, Matthias Kaehlcke wrote: >>>> On Thu, Sep 01, 2022 at 03:47:56PM +0530, Rajendra Nayak wrote: >>>>> USB on sc7280 cannot support wakeups from low power states >>>>> if the GDSC is turned OFF. Update the .pwrsts for usb GDSC so it >>>>> only transitions to RET in low power. >>>>> >>>>> Signed-off-by: Rajendra Nayak >>>> >>>> Reviewed-by: Matthias Kaehlcke >>>> Tested-by: Matthias Kaehlcke >>> >>> Did you confirm that you actually hit the retention state? >> >> No, how would I do that? >> >>> IIUC, this series is equivalent to using ALWAYS_ON unless CX is actually >>> powered off during suspend. >> >> The count in /sys/kernel/debug/qcom_stats/cxsd increses with each suspend, >> however it also does that with the GDSC configured as ALWAYS_ON and with >> Rajendra's "arm64: dts: qcom: sc7280: Add required-opps for USB" [1], so > > hmm, that's really not expected. With my above patch and with the GDSC as > ALWAYS_ON there is a cx vote in suspend preventing cxsd so the counter > should not go up. Perhaps you are missing '1b771839: clk: qcom: gdsc: enable optional power domain support' in your tree? > >> I guess that isn't the correct signal. >> >> https://patchwork.kernel.org/project/linux-arm-msm/patch/20220914053017.23617-1-quic_rjendra@quicinc.com/