From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AB929D273 for ; Wed, 28 Jan 2026 10:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596496; cv=none; b=nBRik4sLSPBPOQIMXvKX5Us/LDSpLbQcllqqo0ca8RWWsdNjSp5xfI7YmOQXBGwd5uaOIkejMPVrqUj/eQKSL9DYfe879IlNjgKYoG2lq/LgGR3siPjBXxuVw9Fv1GR7CWL9yqd/GkjptnVqdaB+jjrNs326voEhRQFrU5C9KY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596496; c=relaxed/simple; bh=HsKI8X7852eK07yEmtE9uzf7klLj/4S5XyAqbNDEDvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ISQhoeFI8QEKOzpM17ws5ZrHM8Q+K4G/NUtqpvE6ted1OAdv8MCX2WxLnVk9T2mELRpg3Ff8PgGHmw5M60U+oRiDGV6vOWTNaS7GdaBp2ZQS7MTQ8kseEl9JN4BpCFV7VDn5CLioBAO6WB2lTnztAekstVqjqjm/kyW8UEQyKkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IJCk6cVE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kV8zwRrR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IJCk6cVE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kV8zwRrR" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S93BiY3249540 for ; Wed, 28 Jan 2026 10:34:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NcWbNCQycmM8x5jw0xO7IuxbVMoHZTQUjaqgqnklwsc=; b=IJCk6cVEH+MY3uBj QVUOP4al9n9MOO0GO8Ld9hx9e67iuRHD/4vja7TTfrrrFItxiOWxPENfQu34DRN5 9y/HzF/ANulKipskXOexTSvZD4l/ALvZjveKRD/vtfU6iyap/HYXOhEnMgWR46z3 rY4zOz1x+Er3P0iirP4STHYZjA6xV5kOt1sfek2tfphdoC6YKmBHmPzWJpGdny9A LZQPx6weqHiSTwHjcogLKvgFQYZ/NTmhEf4SDvnHIgT4sxlOHVKHmhCl3273HCf+ g6N8g9amNpRTfFTdZFlXru9boJecalQCxlARPZ+ScEiM+UkLvV8uE03p00FaX/D4 sA2mXg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bydfk0s9f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 10:34:53 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70cb31bcdso14562085a.1 for ; Wed, 28 Jan 2026 02:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769596493; x=1770201293; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NcWbNCQycmM8x5jw0xO7IuxbVMoHZTQUjaqgqnklwsc=; b=kV8zwRrRnYwlhRER0zGK/zHNoG2bF5/PskZfSJ1FLyhrIj5Oax8yE2lcPnf6En+reE 4EduA9jYVoHHh9JLkXS9REKU2UU+SA6uldIootts9bfMLNAEgeBZ8HFx1wTHRTYazGyP hO+njo44WvLhsM71TZM66iMyddz3m0MRgKKtWCf21HJAI2dpBLqX8moEPWjd82z+7lOM 8pgSo0XjdEMaEwUSmt1fHT7DtdWLgM3pSZ+hY3BpyxFqj2p2DYA668mQfkaeZrCrRjhs h17LBwcwkxmCALMpM7KY3FO2fTP1POlA8PH8IfF+TTSOJr4xnBIc2n8ABQQQHErsRv8s AsWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769596493; x=1770201293; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NcWbNCQycmM8x5jw0xO7IuxbVMoHZTQUjaqgqnklwsc=; b=oUFgVHiVbMxk34fFk1bI0exsTnvxvX6YxNfdHnkYOqNzpZSLZvi6fjn/1qkCTzHXid w8jAwPj0Ro272UHTJhyJcf2cQcVWQkq+p+LXcX6MeIxeBpdaCcrzqTw/LY4UOWhs+/AO upyP7VKYON0sUDNy/jmGCK5NnFO9Nx4f0vEkjMufuuyce9CEHFL7kFRaspvEkMpdesmB D29KJaIhXU/Ut3EhrX893KOOjWUxmpsdnXlecZX059n8u23SqJeFDK/9VIVN/PHxmUzK +neAiLJOGZccLE2Krnv2c3p0my+i4P/M8zqBRPSIX3LWNJp/GrzANFIf7iGKO2nCMhvD XSRA== X-Forwarded-Encrypted: i=1; AJvYcCU77VMUpF7asLCBzHbVSX557O8UL86EgbkDWsYZkJUyrzG4CLXq5QP8XFv5WtJa9PDTV7zHQoIbQNI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1ScS2xvnRuSBosecfSBl4Kh9q8UofuXIMgefJMj3iUh7kPg/x RGxBkR08imI1l2ECRbSNN/S11L54fIJsQLtNvuVkSo2+HtDAeOslLeoQTiHztDGLlJu/vuw5dH7 xQeiTUrbWiB4fF5xEKsu2GA1rle11hoBNiTNGYvfzg8yDXBQTWrpwoo01SH+Lfpg= X-Gm-Gg: AZuq6aL+9VJ7RomyGeMz3tx3f4HIW78kOMBS6kW6xpJva+MaI3DNvx6LctqP9WnLop5 0Id96oOcpZdv5aboRNlDgWQXPnmjUfShQKxVQ2uBRmDoMDeX++EwQN1mIWAkDNOszCKa6/WZTL7 aAbvO72DasaAv6YOgY4V6F/nWQSTRk6ZqYuYYuBHzIRyddGPxCHcMdJo+ILdNyb/GMStjpqyxf2 15wghpbasu/Yh/wnAVz6e7J1lRH6HopdYiCp5jll3Fjssi3zxtAAGRfQz1CKkW2VRXvnPb69zAE AxmaXzlHMkdaa+ZGIj2FQvPbejg+F13Syg6OOtxy10AY1/3FO/OPcm8rUqj36mYbiavygPIGQdY gRDx1yUln4eiXAWfbxfo3f6qk1l+xuikBxkSeIrM90gzc9JAcuCNxnspn0XJ6bHdnWs8= X-Received: by 2002:a05:620a:bc3:b0:8c6:f7ad:49b with SMTP id af79cd13be357-8c714b85971mr124200285a.5.1769596493267; Wed, 28 Jan 2026 02:34:53 -0800 (PST) X-Received: by 2002:a05:620a:bc3:b0:8c6:f7ad:49b with SMTP id af79cd13be357-8c714b85971mr124197685a.5.1769596492863; Wed, 28 Jan 2026 02:34:52 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbef86942sm112832566b.11.2026.01.28.02.34.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 02:34:52 -0800 (PST) Message-ID: Date: Wed, 28 Jan 2026 11:34:49 +0100 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] clk: qcom: Add TCSR clock driver for Eliza To: Abel Vesa , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luca Weiss , Taniya Das , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127-eliza-clocks-v2-0-ccee9438b5c8@oss.qualcomm.com> <20260127-eliza-clocks-v2-6-ccee9438b5c8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260127-eliza-clocks-v2-6-ccee9438b5c8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA4NiBTYWx0ZWRfXwk61NC/3UChU t4aY2fvUmrQhejUbh0207xYzAHHHcSWlZBjrYwxFR5pugbzyXAgPPS2yyd5yrmqa1KQ7s9fgUaA zEBCSjUNbeIl7BF9aMZc79J3TSc2bmxD7y0QNzDCIO8Tps9W1DHrpOIFF9qdvgSCHewCVx8L+4G H1rRcwDJu6668iYmP7xicBXOddKSrCUZeX/F5IGFNRH3SgN4LN/v8reew96Oxkbit/15pA5oxnO lP8siR8bh98BILUfzTijdmq/fwnRy4q6mPs5B1RxKGUVTgr7+1P9ELYzEaAL4GlLWhKgPkiNBKs Xtv19qinKkE0kPk3sBqcuSyjj64liY21yZQw3/AMSIPw4fFQOC3u1LANIu6pdzVG2EQB1pwtKgy +7gFnAdzxDdIHc4jufu6nyGAmPGmTTK/NMs+bHeNQe9YGck6iwKBsLKgSpPaonVmp+VEJR/p6gh 5n2tfBWPQUZTC58Paow== X-Authority-Analysis: v=2.4 cv=XfWEDY55 c=1 sm=1 tr=0 ts=6979e64d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=rpZdSPpRYYrpvmdKZM4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: -C1UkRZlcWZugDWCQsyGfSKVJ6nHLD79 X-Proofpoint-ORIG-GUID: -C1UkRZlcWZugDWCQsyGfSKVJ6nHLD79 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280086 On 1/27/26 4:03 PM, Abel Vesa wrote: > Add the TCSR clock controller that provides the refclks on Eliza > platform for PCIe, USB and UFS subsystems. > > Co-developed-by: Taniya Das > Signed-off-by: Taniya Das > Signed-off-by: Abel Vesa > --- [...] > +++ b/drivers/clk/qcom/tcsrcc-eliza.c > @@ -0,0 +1,144 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include "clk-branch.h" > +#include "clk-regmap.h" > +#include "common.h" > + > +enum { > + DT_BI_TCXO_PAD, > +}; > + > +static struct clk_branch tcsr_pcie_0_clkref_en = { > + .halt_reg = 0x0, These regs certainly aren't at +0x0 to what we normally expect to be the start of the TCSR node [...] > +static struct clk_regmap *tcsr_cc_eliza_clocks[] = { > + [TCSR_PCIE_0_CLKREF_EN] = &tcsr_pcie_0_clkref_en.clkr, > + [TCSR_UFS_CLKREF_EN] = &tcsr_ufs_clkref_en.clkr, > + [TCSR_USB2_CLKREF_EN] = &tcsr_usb2_clkref_en.clkr, > + [TCSR_USB3_CLKREF_EN] = &tcsr_usb3_clkref_en.clkr, I don't think this list is complete Konrad