From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi,
helen.koike@collabora.com
Cc: sboyd@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver
Date: Sun, 26 Apr 2020 02:13:36 +0300 [thread overview]
Message-ID: <fd5300fd-33af-babe-95d0-9669b66a8c06@gmail.com> (raw)
In-Reply-To: <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
24.04.2020 06:55, Sowjanya Komatineni пишет:
> +static int __maybe_unused vi_runtime_resume(struct device *dev)
> +{
> + struct tegra_vi *vi = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = regulator_enable(vi->vdd);
> + if (ret) {
> + dev_err(dev, "failed to enable VDD supply: %d\n", ret);
> + return ret;
> + }
> +
> + ret = clk_set_rate(vi->clk, vi->soc->vi_max_clk_hz);
> + if (ret) {
> + dev_err(dev, "failed to set vi clock rate: %d\n", ret);
> + goto disable_vdd;
> + }
Isn't setting clock rate using assigned-clocks in a device-tree enough?
Could you please clarify why this vi_max_clk_hz is needed?
next prev parent reply other threads:[~2020-04-25 23:13 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 3:55 [RFC PATCH v10 0/9] Add Tegra driver for video capture Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 1/9] arm64: tegra: Fix sor powergate clocks and reset Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 2/9] arm64: tegra: Add reset-cells to mc Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 3/9] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 4/9] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 5/9] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 7/9] MAINTAINERS: Add Tegra Video driver section Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 8/9] dt-bindings: reset: Add ID for Tegra210 VI reset Sowjanya Komatineni
2020-04-24 3:55 ` [RFC PATCH v10 9/9] arm64: tegra: Add Tegra VI CSI support in device tree Sowjanya Komatineni
[not found] ` <1587700513-28449-7-git-send-email-skomatineni@nvidia.com>
2020-04-24 15:07 ` [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver Dmitry Osipenko
2020-04-24 22:00 ` Sowjanya Komatineni
2020-04-25 22:08 ` Dmitry Osipenko
2020-04-25 22:11 ` Sowjanya Komatineni
2020-04-25 23:40 ` Dmitry Osipenko
2020-04-25 23:44 ` Sowjanya Komatineni
2020-04-26 0:19 ` Dmitry Osipenko
2020-04-26 0:24 ` Sowjanya Komatineni
2020-04-26 0:38 ` Dmitry Osipenko
2020-04-26 8:07 ` Hans Verkuil
2020-04-24 15:11 ` Dmitry Osipenko
2020-04-25 9:36 ` Hans Verkuil
2020-04-26 0:36 ` Dmitry Osipenko
2020-04-26 0:41 ` Sowjanya Komatineni
2020-04-26 1:08 ` Sowjanya Komatineni
2020-04-26 1:26 ` Dmitry Osipenko
2020-04-26 1:43 ` Sowjanya Komatineni
2020-04-26 2:10 ` Dmitry Osipenko
2020-04-26 2:19 ` Sowjanya Komatineni
2020-04-26 2:38 ` Dmitry Osipenko
2020-04-26 2:48 ` Sowjanya Komatineni
2020-04-26 3:03 ` Sowjanya Komatineni
2020-04-26 2:19 ` Dmitry Osipenko
2020-04-26 4:23 ` Sowjanya Komatineni
2020-04-26 5:48 ` Dmitry Osipenko
2020-04-26 4:42 ` Dmitry Osipenko
2020-04-26 4:47 ` Sowjanya Komatineni
2020-04-26 5:04 ` Dmitry Osipenko
2020-04-26 5:51 ` Dmitry Osipenko
2020-04-26 8:27 ` Sowjanya Komatineni
2020-04-25 23:13 ` Dmitry Osipenko [this message]
2020-04-25 23:19 ` Sowjanya Komatineni
2020-04-25 23:25 ` Dmitry Osipenko
2020-04-25 23:27 ` Sowjanya Komatineni
2020-04-25 23:44 ` Dmitry Osipenko
2020-04-25 23:47 ` Sowjanya Komatineni
2020-04-25 23:29 ` Dmitry Osipenko
2020-04-26 1:04 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd5300fd-33af-babe-95d0-9669b66a8c06@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox