Re: [PATCH v2 4/9] dt-bindings: clock: Add Marvell PXA1908 clock bindings

Krzysztof Kozlowski
2023-07-31T07:10:32Z

On 30/07/2023 23:18, Duje Mihanović wrote:
> On Friday, July 28, 2023 9:18:44 AM CEST Krzysztof Kozlowski wrote:
>>> +/* axi (apmu) peripherals */
>>> +#define PXA1908_CLK_CCIC1 9
>>> +#define PXA1908_CLK_ISP 14
>>
>> Why do you have gaps between IDs? The clock IDs are supposed to be
>> continuous, otherwise it is not an ID.
>
> Similarly to the PXA1928 clock driver, each clock's ID is its register offset
> divided by 4. Should I use continuous IDs and put the register offsets in the
> clock driver instead?

Either that or drop the bindings file, because otherwise what is the
point of having it in the bindings?

Best regards,
Krzysztof