From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602E522C35B for ; Tue, 10 Dec 2024 23:49:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733874567; cv=none; b=NOAtGdZPNzqeXGO4hOpB/MFx2BRcVxDCloDMUN82y88WXiovMjqZbfnLqWWZUn0FOiXFaiiRSynhVOND/xGah4S8+2eMtiWO05ZA5lvwn8acyGG4z1AmuEGrnZIdkdh0ZiQr0Q5ZKqYVLtL5eiTbKSjKL7p/xcn/a2zmT6LfuIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733874567; c=relaxed/simple; bh=kdVOR3Wklu2GB+n1WaWD3NPikmxtKRQ+RYJP3kaNy8c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GwieevVEohueLlqK7k3aM0hw6si+q5NxeU9eyTrDW+dGOENqy/aIHVRfjfZb0Bu4u8cMqwhWzlHwJFQjIS9BcrNDkbMfwruvkIdPp7QjWOBH4u1h7/n4wJoZJy/AZQaS7P4gq87wiJD6y98RG2lQC4z/T/19TqowPpxVxwDTgs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aTyCii4L; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aTyCii4L" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5d414b8af7bso3720048a12.0 for ; Tue, 10 Dec 2024 15:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733874564; x=1734479364; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w0Bi83nwvzBHW9htNaoYyBIkvuLS9x1PWwSOzilvAhQ=; b=aTyCii4LWyoa2OHa80DLNkJS4aKIv2vO4xR9PuM8UmJ3ysF3MNmds8O+XAnDMS4POL lbcnRX/Td2hFIqMLlZQxw1OIbU9KiZScj8JoVpKPrQQsxU3I1jffXDasJAibMrCy/6wF fRoj/zvYlF9PzEbQHDLsb086pWeYTSeek8qMSVXYmSDOia38BOsQXPUMPvGI2yuQsbxu SFrn+YY4IfNSVIiW4XD0o91QEOX+aDEZZbZvhGp49gEqnt/YeoQFErxKO9LjUJf1+atL NulixXsya6sV0gVGOiJ9G2btnbq2+WUQdg9CEqi/ACl8vjN0mGMtjhmRNpLBeyp2OLhT Ht7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733874564; x=1734479364; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w0Bi83nwvzBHW9htNaoYyBIkvuLS9x1PWwSOzilvAhQ=; b=pWlrCfWiq1tm3SRHk69M2pWuq9N3MTxy0U3zpaFGgBMdBOh2v/7BSs/KhGicNb/4Vp HnXzr7nuc1Nr3iBoyceKqUwhB4b+pco3FO9t694YbOQQgxUB0ItitLXaQrlYuIZi6r1a R5YsOnu2OIZqB+JlpX+Pkqh6km0gqDyj1pK7i2X0GG/793rfoNA8crM1pCr9QgpTxW/u yCUG9w5swQgVXli3E2ndYsK1G9WyEuO5eVX+uBxD8JrTC94roTmEsHNkuXP44DYSmiLa LTTL6I6nFQ91ATa6UQyKjMUQ6FHZL9JTEzGzrspdYb46NbN2D3034zcHEsae8xZmFC6G 2kgA== X-Forwarded-Encrypted: i=1; AJvYcCUpa/lnbwvpv++hgx998dC4m4EeUusIImKMX/ZoiioOq4khvsLh2Hzdd/VkiCcajItZtw+H8T4VBG0=@vger.kernel.org X-Gm-Message-State: AOJu0YwaeOlMvxgizyWRLExwUgV0AUvmQNsw/UVEvyU3dD6rCMgvO+vH 00moDrmo/tZNR2MoOU4Oy0xW+Lw+z/Dsr0ehdRIAkCuoupJ1AuiA/ElYwUo92Mg= X-Gm-Gg: ASbGnctC657CtMD1tUaB1kPuuNUsp/gYvTIxOcxSzoD1CCBnchbRxMBIzZBNBbU1UR1 xK194STNhU8yhCBosAFLGBFNHo/WgMQ3ba2QzXdNmq6SxoNXOGvICWfCMmdk5lW1sQhvddkUhpp XhpSpGsOjZVSTGcoE9rxkYMkcDVGxJgx4EvacR7deuxjuhME5r/5HKqqJ1Q8/pUyP1EE5I1N1FA bOwYokaE5BPA50sJI1m5pdQNfe4n2vsdz5d4InSiDEhR5280bVhYLamXs0OZj8kcUs= X-Google-Smtp-Source: AGHT+IH3jF2Z/UsyE2JcokH/TitWFHL68lwzNBprD9TUestO/ngKH+QJQZekruekHvuCtiR3BRVDbA== X-Received: by 2002:a05:6402:5305:b0:5d2:723c:a568 with SMTP id 4fb4d7f45d1cf-5d433094803mr714069a12.10.1733874563797; Tue, 10 Dec 2024 15:49:23 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3ee6ddf5dsm4755794a12.86.2024.12.10.15.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 15:49:22 -0800 (PST) Message-ID: Date: Tue, 10 Dec 2024 23:49:20 +0000 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: sdm670: add camss and cci To: Richard Acayan , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Cc: Vladimir Zapolskiy References: <20241210233534.614520-7-mailingradian@gmail.com> <20241210233534.614520-12-mailingradian@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241210233534.614520-12-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/12/2024 23:35, Richard Acayan wrote: > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&gcc GCC_CAMERA_AXI_CLK>, > + <&camcc CAM_CC_SOC_AHB_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CSID_CLK>, > + <&camcc CAM_CC_IFE_1_CSID_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_IFE_0_AXI_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_1_AXI_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>; > + clock-names = "gcc_camera_ahb", > + "gcc_camera_axi", > + "soc_ahb", > + "camnoc_axi", > + "cpas_ahb", I think you sorted the regs, interrupts but forgot the clocks ? --- bod