From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Melody Olvera <quic_molvera@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Luca Weiss <luca.weiss@fairphone.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] clk: qcom: gcc-qdu1000: Update the SDCC RCGs to use shared_floor_ops
Date: Fri, 28 Nov 2025 09:25:05 +0530 [thread overview]
Message-ID: <feb55ec8-9c90-4660-b729-e81b4fe2bd9b@oss.qualcomm.com> (raw)
In-Reply-To: <20251127-sdcc_shared_floor_ops-v2-7-473afc86589c@oss.qualcomm.com>
On 11/27/2025 11:27 PM, Jagadeesh Kona wrote:
> Use shared_floor_ops for the SDCC RCGs so the RCG is safely parked
> during disable and the new parent configuration is programmed in
> hardware only when the new parent is enabled, avoiding cases where
> the RCG configuration fails to update.
>
> Fixes: baa316580013 ("clk: qcom: gcc-qdu1000: Update the SDCC clock RCG ops")
> Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
> ---
> drivers/clk/qcom/gcc-qdu1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-qdu1000.c b/drivers/clk/qcom/gcc-qdu1000.c
> index dbe9e9437939afbcd50759dfc21a599864278816..915bb9b4ff8130e086ad6b5bb8872c79617afee8 100644
> --- a/drivers/clk/qcom/gcc-qdu1000.c
> +++ b/drivers/clk/qcom/gcc-qdu1000.c
> @@ -904,7 +904,7 @@ static struct clk_rcg2 gcc_sdcc5_apps_clk_src = {
> .name = "gcc_sdcc5_apps_clk_src",
> .parent_data = gcc_parent_data_8,
> .num_parents = ARRAY_SIZE(gcc_parent_data_8),
> - .ops = &clk_rcg2_floor_ops,
> + .ops = &clk_rcg2_shared_floor_ops,
> },
> };
>
> @@ -923,7 +923,7 @@ static struct clk_rcg2 gcc_sdcc5_ice_core_clk_src = {
> .name = "gcc_sdcc5_ice_core_clk_src",
> .parent_data = gcc_parent_data_2,
> .num_parents = ARRAY_SIZE(gcc_parent_data_2),
> - .ops = &clk_rcg2_floor_ops,
> + .ops = &clk_rcg2_shared_floor_ops,
> },
> };
>
>
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
next prev parent reply other threads:[~2025-11-28 3:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 17:57 [PATCH v2 0/8] clk: qcom: gcc: Update the SDCC RCGs to use shared_floor_ops Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 1/8] clk: qcom: gcc-sm8450: " Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 2/8] clk: qcom: gcc-sm8750: " Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 3/8] clk: qcom: gcc-sm4450: " Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 4/8] clk: qcom: gcc-sdx75: " Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 5/8] clk: qcom: gcc-milos: " Jagadeesh Kona
2025-11-27 17:57 ` [PATCH v2 6/8] clk: qcom: gcc-x1e80100: " Jagadeesh Kona
2025-11-27 19:27 ` Vladimir Zapolskiy
2025-11-28 7:39 ` Imran Shaik
2025-11-27 17:57 ` [PATCH v2 7/8] clk: qcom: gcc-qdu1000: " Jagadeesh Kona
2025-11-27 19:28 ` Vladimir Zapolskiy
2025-11-28 3:55 ` Taniya Das [this message]
2025-11-28 7:39 ` Imran Shaik
2025-11-27 17:57 ` [PATCH v2 8/8] clk: qcom: gcc-glymur: " Jagadeesh Kona
2025-11-27 19:28 ` Vladimir Zapolskiy
2025-11-28 3:55 ` Taniya Das
2025-11-28 7:39 ` Imran Shaik
2025-12-18 3:11 ` [PATCH v2 0/8] clk: qcom: gcc: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb55ec8-9c90-4660-b729-e81b4fe2bd9b@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=abel.vesa@linaro.org \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=lumag@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox