From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7444AC43381 for ; Tue, 12 Jan 2021 13:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3333A23101 for ; Tue, 12 Jan 2021 13:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731287AbhALNrL (ORCPT ); Tue, 12 Jan 2021 08:47:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:49852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731162AbhALNrK (ORCPT ); Tue, 12 Jan 2021 08:47:10 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 13B60ACAC; Tue, 12 Jan 2021 13:46:29 +0000 (UTC) Date: Tue, 12 Jan 2021 14:46:28 +0100 Message-ID: From: Takashi Iwai To: Thierry Reding Cc: Peter Geis , Michael Turquette , Stephen Boyd , Peter De Schrijver , Prashant Gaikwad , Jonathan Hunter , Jaroslav Kysela , Takashi Iwai , Sameer Pujar , Mohan Kumar , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 0/2] fix tegra-hda on tegra30 devices In-Reply-To: References: <20210108135913.2421585-1-pgwipeout@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 12 Jan 2021 14:00:37 +0100, Thierry Reding wrote: > > On Tue, Jan 12, 2021 at 09:22:38AM +0100, Takashi Iwai wrote: > > On Fri, 08 Jan 2021 14:59:11 +0100, > > Peter Geis wrote: > > > > > > The following patches fix tegra-hda on legacy tegra devices. > > > Two issues were discovered preventing tegra-hda from functioning: > > > -The hda clocks on tegra30 were assigned to clk_m and running at too low > > > of a rate to function. > > > -The tegra-hda encounters an input/output error when opening a stream. > > > > > > Since the only mainline device that used tegra-hda until recently was the > > > t124, it is unknown exactly when this was broken. Fortunately a recent > > > patch was submitted that fixed the issue only on t194 devices. We can > > > apply it to the tegra30-hda device to resolve the issue across the board. > > > Note that downstream devices used the spdif device instead of hda for hdmi > > > audio. The spdif device lacks a driver on mainline. > > > > > > -Checkpatch seems to have issues finding [1], but git show has no issue. > > > [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on > > > Tegra194") > > > > > > Changelog: > > > > > > v2: > > > -Added ack and reviewed-by from Jon > > > -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) > > > -Updated commit to include comments from hardware team (Thanks Sameer) > > > -Cleaned up commit messages > > > > > > Peter Geis (2): > > > clk: tegra30: Add hda clock default rates to clock driver > > > ALSA: hda/tegra: fix tegra-hda on tegra30 soc > > > > Shall I apply both patches via sound git tree? > > > > Or, if you want to take through clk tree, let me know. In that case, > > feel free to take my ack: > > Acked-by: Takashi Iwai > > There doesn't seem to be a build-time (or even runtime) dependency > between the two patches and they fix two independent issues, so they > could also go in separately. Yes. OTOH, it's better to be applied in a shot when you look back at the changes later. > I'm fine either way. From a Tegra perspective, the Tegra30 clock driver > is very low activity, so I don't expect any conflicts with between this > and some other patches that might go in through the clock tree. OK, then I queued both patches now to for-linus branch in sound tree. Thanks! Takashi