From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 5/5] clk: qcom: Add support for Global clock controller on Halliday
Date: Mon, 09 Nov 2026 00:40:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-204235@kernel.org> (raw)
In-Reply-To: <20261109-halliday-clk-v1-5-20c3ba8be0bd@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] clk: qcom: gcc-halliday: duplicate frequency table
ftbl_gcc_qupv3_wrap1_s0_clk_src
--
commit 608509f5e5ce26bad8172d9da9b2a60d503d221a
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
clk: qcom: Add support for Global clock controller on Halliday
This commit adds the Global Clock Controller (GCC) driver for the Qualcomm
Halliday SoC, including PLLs, RCGs, branch clocks, GDSCs, resets, and
QREF reference clocks.
> diff --git a/drivers/clk/qcom/gcc-halliday.c b/drivers/clk/qcom/gcc-halliday.c
> new file mode 100644
> index 0000000000000..77b078ac50467
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-halliday.c
[ ... ]
> +static const struct freq_tbl ftbl_gcc_qupv3_wrap0_s0_clk_src[] = {
> + F(7372800, P_GCC_GPLL0_OUT_EVEN, 1, 384, 15625),
> + F(14745600, P_GCC_GPLL0_OUT_EVEN, 1, 768, 15625),
> + F(19200000, P_BI_TCXO, 1, 0, 0),
> + F(29491200, P_GCC_GPLL0_OUT_EVEN, 1, 1536, 15625),
> + F(32000000, P_GCC_GPLL0_OUT_EVEN, 1, 8, 75),
> + F(48000000, P_GCC_GPLL0_OUT_EVEN, 1, 4, 25),
> + F(64000000, P_GCC_GPLL0_OUT_EVEN, 1, 16, 75),
> + F(75000000, P_GCC_GPLL0_OUT_EVEN, 4, 0, 0),
> + F(80000000, P_GCC_GPLL0_OUT_EVEN, 1, 4, 15),
> + F(96000000, P_GCC_GPLL0_OUT_EVEN, 1, 8, 25),
> + F(100000000, P_GCC_GPLL0_OUT_MAIN, 6, 0, 0),
> + F(102400000, P_GCC_GPLL0_OUT_EVEN, 1, 128, 375),
> + F(112000000, P_GCC_GPLL0_OUT_EVEN, 1, 28, 75),
> + F(117964800, P_GCC_GPLL0_OUT_EVEN, 1, 6144, 15625),
> + F(120000000, P_GCC_GPLL0_OUT_MAIN, 5, 0, 0),
> + { }
> +};
[ ... ]
> +static const struct freq_tbl ftbl_gcc_qupv3_wrap1_s0_clk_src[] = {
> + F(7372800, P_GCC_GPLL0_OUT_EVEN, 1, 384, 15625),
> + F(14745600, P_GCC_GPLL0_OUT_EVEN, 1, 768, 15625),
> + F(19200000, P_BI_TCXO, 1, 0, 0),
> + F(29491200, P_GCC_GPLL0_OUT_EVEN, 1, 1536, 15625),
> + F(32000000, P_GCC_GPLL0_OUT_EVEN, 1, 8, 75),
> + F(48000000, P_GCC_GPLL0_OUT_EVEN, 1, 4, 25),
> + F(64000000, P_GCC_GPLL0_OUT_EVEN, 1, 16, 75),
> + F(75000000, P_GCC_GPLL0_OUT_EVEN, 4, 0, 0),
> + F(80000000, P_GCC_GPLL0_OUT_EVEN, 1, 4, 15),
> + F(96000000, P_GCC_GPLL0_OUT_EVEN, 1, 8, 25),
> + F(100000000, P_GCC_GPLL0_OUT_MAIN, 6, 0, 0),
> + F(102400000, P_GCC_GPLL0_OUT_EVEN, 1, 128, 375),
> + F(112000000, P_GCC_GPLL0_OUT_EVEN, 1, 28, 75),
> + F(117964800, P_GCC_GPLL0_OUT_EVEN, 1, 6144, 15625),
> + F(120000000, P_GCC_GPLL0_OUT_MAIN, 5, 0, 0),
> + { }
> +};
[Severity: Low]
This isn't a bug, but ftbl_gcc_qupv3_wrap1_s0_clk_src is identical to
ftbl_gcc_qupv3_wrap0_s0_clk_src. Can gcc_qupv3_wrap1_s0_clk_src and
gcc_qupv3_wrap1_s1_clk_src reuse ftbl_gcc_qupv3_wrap0_s0_clk_src, matching
how the other wrap1 RCGs reuse the wrap0 frequency tables?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-halliday-clk-v1-0-20c3ba8be0bd@gmail.com?part=5
prev parent reply other threads:[~2026-11-09 0:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 0:29 [PATCH 0/5] Add RPMh and global clock controller support for Qualcomm Halliday (SXR2250P) Stanislav Aleksandrov
2026-11-09 0:29 ` [PATCH 1/5] dt-bindings: clock: qcom: document the Halliday RPMh Clock Controller Stanislav Aleksandrov
2026-11-09 0:29 ` [PATCH 2/5] clk: qcom: rpmh: Add support for RPMh clocks on Halliday Stanislav Aleksandrov
2026-11-09 8:54 ` Abel Vesa
2026-11-09 0:29 ` [PATCH 3/5] dt-bindings: clock: qcom: document the Halliday Global Clock Controller Stanislav Aleksandrov
2026-11-09 0:29 ` [PATCH 4/5] clk: qcom: common: Register clk_ref clocks from qcom_cc_desc Stanislav Aleksandrov
2026-11-09 0:42 ` sashiko-bot
2026-11-09 0:29 ` [PATCH 5/5] clk: qcom: Add support for Global clock controller on Halliday Stanislav Aleksandrov
2026-11-09 0:40 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204235@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lightofmysoul@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox