Linux clock framework development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: clock: Convert hisilicon,hi3519-crg to DT schema
Date: Mon, 09 Nov 2026 18:52:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-205445@kernel.org> (raw)
In-Reply-To: <20261109184453.449141-1-robh@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: clock: missing SPDX license tag in
  hisilicon,hi3519-crg.yaml
--

commit 8c68b5566e3d58eaa450c64590a34c88cc578c96
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: clock: Convert hisilicon,hi3519-crg to DT schema

This commit converts the HiSilicon CRG binding from plain text to DT
schema YAML format and updates the allowed compatible strings.

> diff --git a/Documentation/devicetree/bindings/clock/hisilicon,hi3519-crg.yaml b/Documentation/devicetree/bindings/clock/hisilicon,hi3519-crg.yaml
> new file mode 100644
> index 0000000000000..c0b7a5521fe3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/hisilicon,hi3519-crg.yaml
> @@ -0,0 +1,61 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/hisilicon,hi3519-crg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

[Severity: Low]
This schema file is missing an SPDX-License-Identifier header on the first
line, such as:

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Without it, dt-doc-validate (via make dt_binding_check) and checkpatch.pl
report a validation error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109184453.449141-1-robh@kernel.org?part=1

  reply	other threads:[~2026-11-09 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 18:44 [PATCH] dt-bindings: clock: Convert hisilicon,hi3519-crg to DT schema Rob Herring (Arm)
2026-11-09 18:52 ` sashiko-bot [this message]
2026-11-10  0:02 ` Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-205445@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox