Re: [PATCH v5 2/4] MIPS: Skip generic IPI setup for platform-specific callbacks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] MIPS: smp: missing Signed-off-by trailer in commit message
--

commit c5c283e69afb709a8e47e1279441d01d98c9d98c
Author: Florian Fainelli <f.fainelli@gmail.com>

> MIPS: Skip generic IPI setup for platform-specific callbacks
>
> A generic MIPS kernel can select a platform SMP backend with direct IPI
> callbacks instead of an IPI IRQ domain. The XBurst backend uses CP0
> mailboxes, so generic IPI allocation would find no domain and BUG when
> more than one CPU is present.
>
> Skip generic IPI initialization when neither selected send callback uses
> the generic implementation. Keep initialization when either callback
> uses generic IRQ IPIs, and retain the existing single-CPU shortcut.
>
> Sashiko AI reported the XBurst integration issue; Codex assisted with
> the change and extracted-function/build checks.

[Severity: High]
The commit message is missing a Signed-off-by trailer, which is required
under the Developer's Certificate of Origin before the patch can be
applied.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113184210.470320-1-f.fainelli@gmail.com?part=2