From: sashiko-bot@kernel.org
To: "Frédéric Mahé" <frederic.mahe@cirad.fr>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/6] clk: spacemit: k1: Keep pll1_aud_245p7 enabled
Date: Tue, 17 Nov 2026 21:18:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-219683@kernel.org> (raw)
In-Reply-To: <20261117205951.140146-3-frederic.mahe@cirad.fr>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] clk: spacemit: k1: missing Fixes trailer for pll1_aud_245p7
critical clock fix
--
commit 83873cc8722c58b6ef8102ec78a68b9664559a72
Author: Frédéric Mahé <frederic.mahe@cirad.fr>
> clk: spacemit: k1: Keep pll1_aud_245p7 enabled
>
> Accesses to the RCPU2 block (0xc0888000) hang once pll1_aud_245p7 is
> gated: the CPU stops responding, even to NMIs. Nothing claims this
> clock in mainline, so clk_disable_unused() turns it off at boot, and
> probing an RCPU2 PWM afterwards hangs the board. The RCPU2 clock and
> reset registers live in the same block.
>
> Mark it critical, as was done for the K3 RCPU clock.
>
> Tested on a BPI-F3: without this, probing an RCPU2 PWM hangs the
> board; with it, no hang, also with no PWM in use.
>
> Written with help from Claude (Anthropic); reviewed and tested on hardware.
>
> Signed-off-by: Frédéric Mahé <frederic.mahe@cirad.fr>
[Severity: Low]
Since this fixes a hardware hang when clk_disable_unused() gates
pll1_aud_245p7, should this include a Fixes tag?
Fixes: 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117205951.140146-1-frederic.mahe@cirad.fr?part=2
next prev parent reply other threads:[~2026-11-17 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 20:59 [PATCH 0/6] riscv: spacemit: k1: RCPU2 PWM clocks and the BPI-F3 fan Frédéric Mahé
2026-11-17 20:59 ` [PATCH 1/6] dt-bindings: clock: spacemit: k1: Add RCPU2 PWM clocks Frédéric Mahé
2026-11-17 20:59 ` [PATCH 2/6] clk: spacemit: k1: Keep pll1_aud_245p7 enabled Frédéric Mahé
2026-11-17 21:18 ` sashiko-bot [this message]
2026-11-17 20:59 ` [PATCH 3/6] clk: spacemit: k1: Add RCPU2 PWM clocks Frédéric Mahé
2026-11-17 20:59 ` [PATCH 4/6] riscv: dts: spacemit: k1: Add RCPU2 PWM nodes Frédéric Mahé
2026-11-17 20:59 ` [PATCH 5/6] riscv: dts: spacemit: k1-bananapi-f3: Add PWM fan Frédéric Mahé
2026-11-17 20:59 ` [PATCH 6/6] riscv: defconfig: Enable PWM fan support Frédéric Mahé
2026-11-17 21:16 ` [PATCH 0/6] riscv: spacemit: k1: RCPU2 PWM clocks and the BPI-F3 fan Frédéric Mahé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219683@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frederic.mahe@cirad.fr \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox