From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
Christophe de Dinechin <dinechin@redhat.com>
Cc: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"amd-sev-snp@lists.suse.com" <amd-sev-snp@lists.suse.com>
Subject: Re: SVSM Attestation and vTPM specification additions - v0.60
Date: Thu, 12 Jan 2023 10:24:21 -0500 [thread overview]
Message-ID: <028752ebb328e3e9e4ce2a61b04d598f547e894e.camel@HansenPartnership.com> (raw)
In-Reply-To: <6705338d-2fb7-4f6d-6a5b-2a860e894a20@amd.com>
On Thu, 2023-01-12 at 09:13 -0600, Tom Lendacky wrote:
> On 1/12/23 07:57, James Bottomley wrote:
> > On Wed, 2023-01-11 at 17:39 +0100, Christophe de Dinechin wrote:
> > [...]
> > > p29: Table 14: How can RAX be used as command ordinal and command
> > > response size if it's already used for call identifier / result
> > > value?
> >
> > I think there's a bug on the first table: in the prototype we use
> > RAX [in] (not RCX [in]) for the pointer to the request/response
> > buffer and RAX [out] as the SVSM return code.
>
> No, it's not a bug. You'll need to use RCX as the pointer to the
> request/response buffer because RAX, per calling convention, contains
> the protocol id and call id.
Oh, right, I should have looked at the code first before commenting we
do indeed use RCX for the shared buffer.
Do you have a timetable for updating the linux-svsm github for the new
protocol based calling convention? We'd like to rebase the new vTPM
code off it when it's available.
James
next prev parent reply other threads:[~2023-01-12 15:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:54 SVSM Attestation and vTPM specification additions - v0.60 Tom Lendacky
2023-01-10 19:37 ` Tom Lendacky
2023-01-10 19:40 ` Dionna Amalie Glaze
2023-01-10 21:03 ` Tom Lendacky
2023-01-10 22:14 ` James Bottomley
2023-01-10 22:45 ` Tom Lendacky
2023-01-10 23:52 ` James Bottomley
2023-01-11 9:15 ` Christophe de Dinechin Dupont de Dinechin
2023-01-10 20:29 ` James Bottomley
2023-01-10 20:37 ` James Bottomley
2023-01-10 21:33 ` Tom Lendacky
2023-01-10 21:32 ` Tom Lendacky
2023-01-10 21:47 ` James Bottomley
2023-01-10 23:00 ` Tom Lendacky
2023-01-10 23:09 ` James Bottomley
2023-01-11 14:49 ` Tom Lendacky
2023-01-11 14:56 ` James Bottomley
2023-01-10 23:14 ` James Bottomley
2023-01-11 16:39 ` Christophe de Dinechin
2023-01-11 23:00 ` Tom Lendacky
2023-01-12 1:27 ` [EXTERNAL] " Jon Lange
2023-01-13 16:10 ` Tom Lendacky
2023-01-12 13:57 ` James Bottomley
2023-01-12 15:13 ` Tom Lendacky
2023-01-12 15:24 ` James Bottomley [this message]
2023-01-13 16:12 ` Tom Lendacky
2023-01-12 8:19 ` Dov Murik
2023-01-12 12:18 ` James Bottomley
2023-01-13 16:16 ` Tom Lendacky
2023-01-13 11:50 ` Nicolai Stange
2023-01-13 17:20 ` Tom Lendacky
2023-01-24 9:35 ` Jörg Rödel
2023-01-26 14:36 ` Tom Lendacky
2023-01-26 16:45 ` Christophe de Dinechin Dupont de Dinechin
2023-02-01 10:50 ` Jörg Rödel
2023-02-20 15:10 ` Tom Lendacky
2023-01-24 9:45 ` Jörg Rödel
2023-01-26 14:51 ` Tom Lendacky
2023-01-26 16:49 ` Christophe de Dinechin Dupont de Dinechin
2023-01-26 17:33 ` [EXTERNAL] " Jon Lange
2023-01-27 8:35 ` Jörg Rödel
2023-01-27 16:11 ` Jon Lange
2023-01-30 11:29 ` Jörg Rödel
2023-01-31 4:44 ` Jon Lange
2023-01-31 15:06 ` Tom Lendacky
2023-01-31 15:34 ` Jon Lange
2023-02-01 15:20 ` [EXTERNAL] " Christophe de Dinechin Dupont de Dinechin
2023-02-02 6:04 ` Jon Lange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028752ebb328e3e9e4ce2a61b04d598f547e894e.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=amd-sev-snp@lists.suse.com \
--cc=dinechin@redhat.com \
--cc=linux-coco@lists.linux.dev \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).