Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Sean Christopherson <seanjc@google.com>,
	Peter Fang <peter.fang@intel.com>
Cc: Rick P Edgecombe <rick.p.edgecombe@intel.com>,
	"djbw@kernel.org" <djbw@kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"kas@kernel.org" <kas@kernel.org>,
	"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
	Yilun Xu <yilun.xu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Zhenzhong Duan <zhenzhong.duan@intel.com>,
	Kishen Maloor <kishen.maloor@intel.com>,
	"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 16/17] KVM: TDX: Add in-kernel Quote generation
Date: Wed, 8 Jul 2026 13:47:29 -0700	[thread overview]
Message-ID: <08c9bf2f-75be-4244-b99c-153ec1f604ca@intel.com> (raw)
In-Reply-To: <akvsgVjwb00P1EuA@google.com>

On 7/6/26 10:57, Sean Christopherson wrote:
> What is "the S3M" though?  Is it a separate chip a la AMD's PSP/ASP?  Is it a
> per-package thing? Per-core?
I'll give you my rough software guy mental model of what it is: Each
package has its own S3M. They are microcontrollers which are discrete
from the CPU cores. Each S3M gets some CPU physical address space routed
over to it.

> How is it accessed, and what are the "rules" for for those
> accesses?  What types of latencies are we looking at?

As far as I know, the latency for one round trip to/from S3M is on the
order of a "real" device. It has a physical address and when the OS
wants to talk to it, those addresses are mapped with ioremap(). It's
similar to any modern I/O device control plane. Note, though, that for
TDX, there's no ioremap() because the I/O is hidden in the TDX module.

The real overhead comes because the I/O window is essentially 4 bytes
wide (IIRC) and all the data that comes in and out of it has to be
squeezed through that window. It reminds me of a UART, but with a
slightly more arcane interface.

For TDX, though, the craziness is mostly hidden in the TDX module.

> What else uses the S3M?  Do we have to worry about contending with
> non-TDX usage?
There _are_ different users of S3M. But each of them should get their
own I/O address and S3M firmware has to handle talking to those
different users at the same time. The TDX I/O window is owned
exclusively by the TDX module.

So, while S3M has and long and growing list of jobs, the random software
(like the host kernel) poking at one I/O window doesn't have to know
about the other piece of software (the TDX module) poking at another.

I'm sure I got a detail or two wrong in there, so folks that know this
better: please correct me. But I think that's a halfway-decent 10,000ft
view.

  reply	other threads:[~2026-07-08 20:47 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  8:13 [PATCH v2 00/17] Enable DICE-based TDX Quoting Extension Xu Yilun
2026-06-18  8:13 ` [PATCH v2 01/17] x86/virt/tdx: Embed version info in SEAMCALL leaf function definitions Xu Yilun
2026-06-18 14:45   ` Dave Hansen
2026-06-22 12:05     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 02/17] x86/virt/tdx: Configure add-on features on TDX module init and update Xu Yilun
2026-06-18 15:04   ` Dave Hansen
2026-06-22 13:15     ` Xu Yilun
2026-06-24 12:00     ` Xu Yilun
2026-06-24 22:10       ` Peter Fang
2026-06-25  6:33         ` Xu Yilun
2026-06-23  8:43   ` Chao Gao
2026-06-25 10:50     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 03/17] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-06-25  5:19   ` Tony Lindgren
2026-06-25 10:57     ` Xu Yilun
2026-06-29  6:33   ` Chao Gao
2026-06-30 11:10     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 04/17] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-06-29  7:56   ` Chao Gao
2026-06-30 10:27     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 05/17] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-06-18  8:13 ` [PATCH v2 06/17] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
2026-06-29  8:12   ` Chao Gao
2026-06-30 11:14     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 07/17] x86/virt/tdx: Initialize Quoting extension Xu Yilun
2026-06-29  8:33   ` Chao Gao
2026-06-30  5:20     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 08/17] x86/virt/tdx: Prepare Quote buffer during extension bringup Xu Yilun
2026-06-25  6:08   ` Tony Lindgren
2026-06-30  4:12     ` Peter Fang
2026-07-01 19:56   ` Dave Hansen
2026-07-08  9:25     ` Peter Fang
2026-07-08  7:52   ` Nikolay Borisov
2026-06-18  8:13 ` [PATCH v2 09/17] x86/virt/tdx: Add interface to check Quoting availability Xu Yilun
2026-06-25  6:09   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 10/17] x86/virt/tdx: Move tdx_tdr_pa() up in the file Xu Yilun
2026-06-25  6:10   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 11/17] x86/virt/tdx: Add interface to generate a Quote Xu Yilun
2026-06-25  6:05   ` Tony Lindgren
2026-06-30  4:22     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 12/17] x86/virt/tdx: Reinitialize the Quoting extension after TDX module update Xu Yilun
2026-06-25  6:12   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 13/17] x86/virt/tdx: Enable Quoting extension Xu Yilun
2026-06-25  6:13   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 14/17] x86/tdx: Move and rename Quote request structure Xu Yilun
2026-06-25  6:15   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 15/17] KVM: TDX: Factor out userspace return path from tdx_get_quote() Xu Yilun
2026-06-25  6:16   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 16/17] KVM: TDX: Add in-kernel Quote generation Xu Yilun
2026-06-25 18:01   ` Sean Christopherson
2026-06-29 10:03     ` Peter Fang
2026-06-30  0:42       ` Sean Christopherson
2026-06-30 23:33         ` Edgecombe, Rick P
2026-07-01  0:24           ` Dan Williams (nvidia)
2026-07-01 17:25             ` Sean Christopherson
2026-07-01 18:45               ` Edgecombe, Rick P
2026-07-04  5:43                 ` Peter Fang
2026-07-06 17:57                   ` Sean Christopherson
2026-07-08 20:47                     ` Dave Hansen [this message]
2026-07-08 21:16                       ` Sean Christopherson
2026-07-08 22:09                       ` Peter Fang
2026-07-08 22:28                         ` Sean Christopherson
2026-07-08 23:38                           ` Edgecombe, Rick P
2026-07-10  9:01                   ` Nikolay Borisov
2026-07-10  9:38                     ` Peter Fang
2026-07-08 21:37   ` Sean Christopherson
2026-07-10 12:52     ` Peter Fang
2026-07-10 14:48       ` Sean Christopherson
2026-07-10 22:59         ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 17/17] KVM: TDX: Support event-notify interrupts only with userspace Quoting Xu Yilun
2026-06-25  6:28   ` Tony Lindgren
2026-06-30  6:36     ` Peter Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08c9bf2f-75be-4244-b99c-153ec1f604ca@intel.com \
    --to=dave.hansen@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=djbw@kernel.org \
    --cc=kas@kernel.org \
    --cc=kishen.maloor@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.fang@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=sohil.mehta@intel.com \
    --cc=tony.lindgren@linux.intel.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox