From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A2C34F4029 for ; Wed, 14 Oct 2026 10:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791975497; cv=none; b=VglrRqQ8wkl2gEihC0B5KVodfw5t9lzHhGM/44ovaIAenRjlC8ytdobKmFpPx5Tg8KFsu8vFwDKxE3gyXUu2AU+Cbwno2Gcoi9qM2ESWAGVSrZFoUHhS5cMD4Nxxr6NyzVwCq2nsMJHYkz6aBAK8RmP0tZOic2V18ESvwK100mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791975497; c=relaxed/simple; bh=oMdJQ4OULZXyBz3Ko0nv7l3azl/UbkYzjQDSpcXpAiM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pzwrZU3ak+pcSVbctz8VlYm2pLbOCLdnZcuwZ68NZCws1wyuRNkIx87HLs6rFdb5SzngFLIqlryJLO3r1XxmtsptVQ/qTB3lGjdnKlkUPZzbraDmmoUYpZ4OapplIr/IEPrX7cGlv9pzezVZJhaj4JLHU2kHAKZ4PrPSdjC7fyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ft5vQYAs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ft5vQYAs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791975493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jH1ufsQ5g3r1H3aslg+X8qJ0wMgxmZRuam6ChKawEQw=; b=Ft5vQYAsmmGrRvVXqCt1HYeHZ/Ss5dxr+fW7NY2k/4aJRERtUVy/lcCqrKuHmbsHW1mIvF lwm0g58dzj8uO5BdKbbyl88Cy96OXK2D0xq5nPhbHx1TXTSahG42t6QArrLKLHX60mPBvZ NUjCa1cCI43Ezz/SggMR+G19hiElMBU= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-D0yuJrY5MD28QmGtWmL7kw-1; Wed, 14 Oct 2026 10:58:11 +0000 X-MC-Unique: D0yuJrY5MD28QmGtWmL7kw-1 X-Mimecast-MFC-AGG-ID: D0yuJrY5MD28QmGtWmL7kw_1791975491 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3ab67ff8ec3so223168a91.0 for ; Wed, 14 Oct 2026 03:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791975491; x=1792580291; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jH1ufsQ5g3r1H3aslg+X8qJ0wMgxmZRuam6ChKawEQw=; b=G+3epYcltpaUsAkF6GHbWbpRMIHwP0/IrzyrTscQuGdGpErIpljdwJE0ilbi4ULMpp areTYF0ub+W889MAi1KNlXH/AM9oSRRpoVlV7p4xQKX5BIUf7aJqw9V6BK8HQsj4cuC8 DoWf5OufIvrdZSKfgtXUxd04x8M0MkoR8q8UWJuNn5k/fLDErrdHhC+cGJ1eal/Ihbwa Q3t3z0AUUTSin4cgukKBDjGBpKiid+LkO0KNh5o4jN7dcrlgrXvhnBi+RHeM3EMspeeN 0mfwH8kzstEjByuMOHVYS5C6jQsuCGGwojVjfuz2VN4EIYVw0l/11Zm6N/f72y+wi2Tj THcw== X-Forwarded-Encrypted: i=1; AKwUvBxwNDbKeESmebGuvKyv1tCluBRfoaLpat/mo71/ARGiEwFx02F0dLPkbccZgN9SfeBX7ek3yQ8HGeXl@lists.linux.dev X-Gm-Message-State: AFq9FYJhB9CtejMOnj6YxhMXJmhX8uRm9XfMEYnPUCjYGztmRoFM9ao6 TweT5ab6sLL56rj0kYjid/3ARRb2IXiv4tGibngzisNf3ltEBlclmAeKAVct/K7yOiIkmH0fCZw aMc6+AnowPOC5+sYJzvZe6WOPPNQAlfz7RS/Ryl1Fln8U657N5FD6zq3HkvKeiEw= X-Gm-Gg: AYBFou3KZob2WtSWO7J3QQdzTY6IRIcoAujY3PFS94dOZRmnRe2CQeyZ6ou4A7O/X0U U41G35fijMJSK2H6GuegKHmdIsM8QIebAM4Xfd8BdhBEgSAnx8UfpdNWGoJ312KJOw0UUW1795h 75vWJJUvZwOHns5r5nMO5UB+v90Wqg9hxIgGVnoecEXleuJ2fxyNe9gfTL4Y1WDc76d4TdtaK5l GbHLEKrZGco6cramgWJCqKYIXvM0WYrBeeC5vr8xOT+OFwKogDhVIROvfLInvUcJhX3v2IgTkke +/Yip7XHsY7pbGYveHY5HN/StRAR/QzzRiNTgwHug6WZUJ6rJ9sNJgeT/20ln04RiXCKLHc4+oT TAykYrDonW97dpn+bckH6F98qnoZTfDhiKZLA1kk/2g== X-Received: by 2002:a17:90a:51a7:b0:3ab:4262:1a3a with SMTP id 98e67ed59e1d1-3ab42621c33mr8647756a91.61.1791975490681; Wed, 14 Oct 2026 03:58:10 -0700 (PDT) X-Received: by 2002:a17:90a:51a7:b0:3ab:4262:1a3a with SMTP id 98e67ed59e1d1-3ab42621c33mr8647724a91.61.1791975490063; Wed, 14 Oct 2026 03:58:10 -0700 (PDT) Received: from [192.168.68.52] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac5f05083fsm4391258a91.1.2026.10.14.03.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 03:58:09 -0700 (PDT) Message-ID: <0ceda99f-0352-474b-a30a-c5e79b817c2d@redhat.com> Date: Wed, 14 Oct 2026 20:58:00 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v22 02/10] firmware: arm_rmm: Check for RMI support at init To: Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: maz@kernel.org, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com, sudeep.holla@arm.com, jonathan.cameron@oss.qualcomm.com References: <20261002061507.1600269-1-suzuki.poulose@arm.com> <20261002061507.1600269-3-suzuki.poulose@arm.com> <2586e689-c27d-4e4c-8c69-03e24259cb96@redhat.com> <8be050e3-8af1-4f04-902f-9bc01b209dd0@arm.com> <3fbd4739-a4eb-4428-95ae-ead22e7cf9f2@redhat.com> <799fb810-c33e-4d0e-9a70-7092c0a681ff@arm.com> From: Gavin Shan In-Reply-To: <799fb810-c33e-4d0e-9a70-7092c0a681ff@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q0ySjPSCrZSpr5l8wI2srIxii42WzP3Hf0XHJ9s-k-E_1791975491 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/14/26 7:19 PM, Suzuki K Poulose wrote: > On 14/10/2026 08:26, Gavin Shan wrote: >> On 10/13/26 7:58 PM, Suzuki K Poulose wrote: >>> On 13/10/2026 04:53, Gavin Shan wrote: >>>> Hi Suzuki, >>>> >>>> On 10/2/26 4:14 PM, Suzuki K Poulose wrote: >>>>> From: Steven Price >>>>> >>>>> Query the RMI version number and check if it is a compatible version. >>>>> All RMM feature registers are read and exposed for future code to >>>>> use. Also restrict the support to SMC conduit. >>>>> >>>>> We only support this for Little Endian kernels, the Big Endian kernel >>>>> support is anyway marked BROKEN and is being removed. >>>>> >>>>> Cc: Marc Zyngier >>>>> Cc: Oliver Upton >>>>> Reviewed-by: Jonathan Cameron >>>>> Reviewed-by: Gavin Shan >>>>> Reviewed-by: Catalin Marinas >>>>> Tested-by: Gavin Shan >>>>> Signed-off-by: Steven Price >>>>> Co-developed-by: Suzuki K Poulose >>>>> Signed-off-by: Suzuki K Poulose >>>>> --- >>>> >>>> [...] >>>> >>>>> --- >>>>>   MAINTAINERS                       |   2 + >>>>>   arch/arm64/Kconfig                |   1 + >>>>>   arch/arm64/kernel/cpufeature.c    |   1 + >>>>>   arch/arm64/kvm/sys_regs.c         |   2 + >>>>>   drivers/firmware/Kconfig          |   1 + >>>>>   drivers/firmware/Makefile         |   1 + >>>>>   drivers/firmware/arm_rmm/Kconfig  |  25 +++++++ >>>>>   drivers/firmware/arm_rmm/Makefile |   1 + >>>>>   drivers/firmware/arm_rmm/rmi.c    | 112 ++++++++++++++++++++++++++ ++++ >>>>>   include/linux/arm-rmi-cmds.h      |  48 +++++++++++++ >>>>>   10 files changed, 194 insertions(+) >>>>>   create mode 100644 drivers/firmware/arm_rmm/Kconfig >>>>>   create mode 100644 drivers/firmware/arm_rmm/Makefile >>>>>   create mode 100644 drivers/firmware/arm_rmm/rmi.c >>>>>   create mode 100644 include/linux/arm-rmi-cmds.h >>>>> >>>> >>>> [...] >>>> >>>>> diff --git a/drivers/firmware/arm_rmm/rmi.c b/drivers/firmware/ arm_rmm/rmi.c >>>>> new file mode 100644 >>>>> index 0000000000000..06f5392c982d2 >>>>> --- /dev/null >>>>> +++ b/drivers/firmware/arm_rmm/rmi.c >>>>> @@ -0,0 +1,112 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0 >>>>> +/* >>>>> + * Copyright (C) 2023-2026 ARM Ltd. >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include >>>>> +#include >>>>> + >>>>> +/* RMM v2.0 defines RmiFeatureRegister0 to RmiFeatureRegister4. */ >>>>> +static unsigned long rmi_feat_reg_cache[5] __ro_after_init; >>>>> + >>>>> +static int rmi_check_version(void) >>>>> +{ >>>>> +    unsigned short version_major, version_minor; >>>>> +    unsigned long host_version = RMI_ABI_VERSION(RMI_ABI_MAJOR_VERSION, >>>>> +                             RMI_ABI_MINOR_VERSION); >>>>> +    unsigned long aa64pfr0 = read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1); >>>>> +    struct arm_smccc_1_2_regs res = { >>>>> +        SMC_RMI_VERSION, host_version, >>>>> +    }; >>>>> + >>>>> +    /* If RME isn't supported, then RMI can't be */ >>>>> +    if (cpuid_feature_extract_unsigned_field(aa64pfr0, ID_AA64PFR0_EL1_RME_SHIFT) == 0) >>>>> +        return -ENXIO; >>>>> + >>>>> +    if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_SMC) >>>>> +        return -ENXIO; >>>> >>>> I think we need to ensure SMCCC version is v1.2 or a newer one here? arm_smccc_1_2_smc() >>>> is immediately called by rmi_smccc_invoke() after this check. >>>> >>>>      if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_SMC || >>>>              arm_smccc_get_version() < ARM_SMCCC_VERSION_1_2) >>> >>> We could. But I am wondering if that adds any value ? If the RMM >>> exists and responds to the RMI_ABI_VERSION, it must be so on a >>> platform with v1.2 or greater ? The extra check doesn't hurt. >>> >> >> It's required as documented in section "B1.1 overview" of RMM-spec-v2.0- bet3. >> In the same section, there are more requirements regarding the SMCCC version >> when SVE/SME are supported. I don't see a practical problem if the check is >> missed since the combination of TF-A and TF-RMM are the only RMM-spec- v2.0-bet3 >> implementation (as I knew) where the SMCCC version has been set to v1.5 in the >> 'master' branch. > > Reading the RMM spec again, DFNMZ lists how one can detect if the RMM > ABI is present. That specifies that the user checks for SMCCC > version >= 1.1, which we do by using arm_smccc_1_1_get_conduit(). > > Then checking the R{M,S}I_VERSION call is sufficient. So, I think > we are good here. Do you agree ? > arm_smccc_1_1_get_conduit() ensures SMCCC version >= v1.1, but we need SMCCC version >= v1.2. We will have problem if the firmware only supports SMCCC v1.1 and R{M,S}I_VERSION is coincidentally supported. In this rare (even impossible) case, it's not sufficient to check R{M,S}I_VERSION as I understand. As far as TF-A+TF-RMM is concerned, I agree there is no issue. However, the extra check doesn't hurt and make the code following the spec a bit more strictly? :-) Thanks, Gavin > Suzuki > >> >> Thanks, >> Gavin >> >>> Suzuki >>> >>>>          return -ENXIO; >>>> >>>> Thanks, >>>> Gavin >>>> >>>>> + >>>>> +    rmi_smccc_invoke(&res); >>>>> +    if (res.a0 == SMCCC_RET_NOT_SUPPORTED) >>>>> +        return -ENXIO; >>>>> + >>>>> +    version_major = RMI_ABI_VERSION_GET_MAJOR(res.a1); >>>>> +    version_minor = RMI_ABI_VERSION_GET_MINOR(res.a1); >>>>> + >>>>> +    if (res.a0 != RMI_SUCCESS) { >>>>> +        unsigned short high_version_major, high_version_minor; >>>>> + >>>>> +        high_version_major = RMI_ABI_VERSION_GET_MAJOR(res.a2); >>>>> +        high_version_minor = RMI_ABI_VERSION_GET_MINOR(res.a2); >>>>> + >>>>> +        pr_err("Unsupported RMI ABI (v%d.%d - v%d.%d) we want v%d. %d\n", >>>>> +               version_major, version_minor, >>>>> +               high_version_major, high_version_minor, >>>>> +               RMI_ABI_MAJOR_VERSION, >>>>> +               RMI_ABI_MINOR_VERSION); >>>>> +        return -ENXIO; >>>>> +    } >>>>> + >>>>> +    pr_info("RMI ABI version %d.%d\n", version_major, version_minor); >>>>> + >>>>> +    return 0; >>>>> +} >>>>> + >>>> >>>> [...] >>>> >>>> >>>> >>> >> >