From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B90E3911A1 for ; Mon, 8 Jun 2026 07:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780903893; cv=none; b=f85zRH6DENTTH0cL9xBx+iNxmyr47Rv0SpYAFgAGqKPwcM5E3lySVLQRNSzQtARb6ENLrE8AdmoA3s0Jj50EYDSjKmqB17PWnhkBinu5Wxt1Ro5g96qlmW5O7+FCmsqMfvZqFCu77dnEPd04W92dsDoUIhXrP6iSDB5RCDssBhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780903893; c=relaxed/simple; bh=CvTLFyhxq9msoIgNWC90DtZohlxaCQTF9fNqOcbIN3g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BH6+C/GylIoVqclB9//yuTmOKZ4aEe0Kz26LHEaMg1UpNd0jeKpU1r0Drp+3U6Q2u7qX/7QErF/9lwseUQUOSnT6aLyI0qV1O8ozUyrGlIqgXz2/iT/UZSgR2UwP8LX/w0Yy0ncwTTpslrtB+5GmUUvND9PNk2dxxNZ2eG2w71o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V5fxnQbo; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V5fxnQbo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780903889; x=1812439889; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CvTLFyhxq9msoIgNWC90DtZohlxaCQTF9fNqOcbIN3g=; b=V5fxnQbopyLIlesGC8aG9YMAchWDac6kRSZFOD8M3db7CEkNIvtdofzs 96oxwL3p3K8OSDr0/6T8O7IDzxZwHlxb11RDwcBrd/zm4nER5VO+gdtW6 AdBHb0179VI71Li6nvf8ty2WZ/iRr7o0bV/AuaR3JseSKW/URvrejPhKa CjcAF7VTV4lPYi9422IoQWBiAq2lwuPF99CnSv1KHhh4Ow8bkmZxHNVFs 5C40KEjFF0uPh6u/j6VomOBS/lmu3h5dJSRlgdj9zTr/c23YWnGN5QpIj Ht+wzPsmveKFvQ/erpZbnOy7ew91GmJ6v9w8ya42q4f3P1OGqk+29Pxie A==; X-CSE-ConnectionGUID: OFi8rqGSRr+Se1iH3uHPWQ== X-CSE-MsgGUID: XFjJuT54TRWujK5Nt1dl5g== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="84206793" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="84206793" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:31:18 -0700 X-CSE-ConnectionGUID: dlvNSPV/Qf6vGo/QWFgWxA== X-CSE-MsgGUID: d3OpymgeS7SsWO8cOkbqIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="242496781" Received: from unknown (HELO [10.238.2.24]) ([10.238.2.24]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:31:12 -0700 Message-ID: <14385c18-a236-44fd-8728-598d6b6cc8a5@linux.intel.com> Date: Mon, 8 Jun 2026 15:31:10 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 12/22] KVM: selftests: Back the first memory region with guest_memfd for TDX To: Lisa Wang Cc: Andrew Jones , Ackerley Tng , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton , Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260521-tdx-selftests-v13-v13-0-6983ae4c3a4d@google.com> <20260521-tdx-selftests-v13-v13-12-6983ae4c3a4d@google.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20260521-tdx-selftests-v13-v13-12-6983ae4c3a4d@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/2026 7:16 AM, Lisa Wang wrote: > Force GUEST_MEMFD for the primary memory region of TDX VMs. > > TDX must use guest_memfd for private pages as there is no alternative > mechanism supported by the TDX architecture. This sounds a bit confusing to me. It's the kernel/KVM only support guest_memfd for private pages. The restriction is not from the "TDX architecture". Also, the short log is also a bit confusing. Why describe the "first memory region" here? > > Signed-off-by: Lisa Wang > --- > tools/testing/selftests/kvm/lib/kvm_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index d1befa3f4b30..9a29540fff40 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -472,7 +472,7 @@ void kvm_set_files_rlimit(u32 nr_vcpus) > static bool is_guest_memfd_required(struct vm_shape shape) > { > #ifdef __x86_64__ > - return shape.type == KVM_X86_SNP_VM; > + return (shape.type == KVM_X86_SNP_VM || shape.type == KVM_X86_TDX_VM); > #else > return false; > #endif >