From: Jason Gunthorpe <jgg@nvidia.com>
To: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org>
Cc: linux-coco@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Greg KH <gregkh@linuxfoundation.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will@kernel.org>,
Steven Price <steven.price@arm.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v10 1/7] firmware: smccc: Add an Arm SMCCC bus
Date: Fri, 04 Sep 2026 16:39:35 -0300 [thread overview]
Message-ID: <178855077568.693280.12901641270978126497.b4-review@b4> (raw)
In-Reply-To: <20260904095000.1184861-2-aneesh.kumar@kernel.org>
> [ ... 243 lines skipped ... ]
> +++ b/include/linux/device-id/arm_smccc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __LINUX_DEVICE_ID_ARM_SMCCC_H
> +#define __LINUX_DEVICE_ID_ARM_SMCCC_H
> +
> +#define ARM_SMCCC_MODULE_PREFIX "arm_smccc:"
> +
> +/**
> + * struct arm_smccc_device_id - Arm SMCCC bus device identifier
> + * @func_id: SMCCC function identifier
> + */
> +struct arm_smccc_device_id {
> + __u32 func_id;
[Severity: Low]
Does this new header need to include <linux/types.h> so that it is
self-contained?
If a C file includes <linux/device-id/arm_smccc.h> directly without a prior
inclusion of <linux/types.h>, the __u32 type used in arm_smccc_device_id will
be undeclared, which will cause a compilation failure.
It is minor, but if you have to respin it is nice for clangd users if
headers are self contained.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
--
Jason
next prev parent reply other threads:[~2026-09-04 19:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:49 [PATCH v10 0/7] Switch Arm SMCCC firmware services to an SMCCC bus Aneesh Kumar K.V (Arm)
2026-09-04 9:49 ` [PATCH v10 1/7] firmware: smccc: Add an Arm " Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe [this message]
2026-09-04 9:49 ` [PATCH v10 2/7] firmware: hwrng: arm_smccc_trng: Register as an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
2026-09-04 9:49 ` [PATCH v10 3/7] firmware: arm_rmm: Move RSI support out of arch/arm64 Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
2026-09-04 9:49 ` [PATCH v10 4/7] arm64: realm: Move Realm memory encryption ops to RSI code Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
2026-09-04 9:49 ` [PATCH v10 5/7] virt: coco: arm-cca-guest: Rename TSM report source file Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
2026-09-04 9:49 ` [PATCH v10 6/7] firmware: smccc: arm-cca-guest: Bind the TSM provider to an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
2026-09-09 7:37 ` Aneesh Kumar K.V
2026-09-09 12:05 ` Jason Gunthorpe
2026-09-11 14:55 ` Suzuki K Poulose
2026-09-11 14:59 ` Jason Gunthorpe
2026-09-04 9:50 ` [PATCH v10 7/7] coco: guest: arm64: Replace dummy CCA device with sysfs ABI Aneesh Kumar K.V (Arm)
2026-09-04 19:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178855077568.693280.12901641270978126497.b4-review@b4 \
--to=jgg@nvidia.com \
--cc=Suzuki.Poulose@arm.com \
--cc=andre.przywara@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox