From: Tom Lendacky <thomas.lendacky@amd.com>
To: "Kalra, Ashish" <ashish.kalra@amd.com>,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, bp@alien8.de,
hpa@zytor.com
Cc: michael.roth@amd.com, nikunj@amd.com, seanjc@google.com,
ardb@kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-coco@lists.linux.dev
Subject: Re: [PATCH v3] x86/sev: Fix making shared pages private during kdump
Date: Fri, 2 May 2025 14:40:28 -0500 [thread overview]
Message-ID: <18d4f1d7-0b40-06eb-f328-fbe198a2832d@amd.com> (raw)
In-Reply-To: <dd0cfca0-44a1-436b-a115-44ad02369850@amd.com>
On 5/2/25 14:32, Kalra, Ashish wrote:
> Hello Tom,
>
> On 5/1/2025 8:56 AM, Tom Lendacky wrote:
>> On 4/30/25 18:17, Ashish Kalra wrote:
>>> From: Ashish Kalra <ashish.kalra@amd.com>
>
> I agree, i really don't need the check as i can simply apply the mask as
> the mask is based on page level/size.
>
> mask = page_level_mask(level);
> ghcb = (struct ghcb *)((unsigned long)ghcb & mask);
There's also a lot of casting back and forth with the ghcb variable. It
might be better to define it as an unsigned long and reduce all that.
Thanks,
Tom
>
prev parent reply other threads:[~2025-05-02 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 23:17 [PATCH v3] x86/sev: Fix making shared pages private during kdump Ashish Kalra
2025-05-01 13:56 ` Tom Lendacky
2025-05-02 13:30 ` Borislav Petkov
2025-05-02 19:32 ` Kalra, Ashish
2025-05-02 19:40 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d4f1d7-0b40-06eb-f328-fbe198a2832d@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox