From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCA76156861 for ; Tue, 9 Apr 2024 18:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712686387; cv=none; b=FD38VSOxV9yzFZN6V4jY+hH5dNEO7cqde2FjddNQJAPz02Gbct7URxmA84JlcrKxDM6w39q4BA1SPurI06J7KL/m6XDmxJfqyu+w/uSGPB0DtzO+uYX2b3vDWWjTybXHfwC6xqyB9RNAv2dvn8iMEUjX3q28F7wNw2S18y9sO8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712686387; c=relaxed/simple; bh=mt4LK8wRky83QmRbMyyw2lMJig0xnioKZPacc3nZi+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tlTysZzeJcoctadl+HC8nBVdxwBJanAE+in8yVTY+q7z7X9RqmLMF6BbGBifoKR86DZ4Qo3CFvS4PwsaMXCzr0dUQdJZoTJttiX+aMtv0Jdui6sT70pWfwUwiAUeXKeR0iSXwpvfZZCOHS4Ahqd47mxNTBjuhc4HY1aftlijG3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KFNIhLE5; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KFNIhLE5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712686386; x=1744222386; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mt4LK8wRky83QmRbMyyw2lMJig0xnioKZPacc3nZi+E=; b=KFNIhLE5BOqWm/Ww/Z7RjNfUvu+TuAD4UlI4nBRUZkthssDSGdii4WRp CMkWRzYQAHx0WexGGvB2WqlzRFffSaq20W0G+7kpfdlRKCO+/+GCdkZ90 xqr7Xq9G0FBE4bQoufGwp5/M9MbxdSnTD5k/UJcH849YwKDDJkkTOux2R pOQaZnT8dsc8/gTccpbCLSMhQewewaAlcICdhXB9U0kuv0gORhC9a0udZ uAZ5bLhYG63cGjEaf6S1CRFe2KSW4d7kJohnSICBX/gXEGbdGx9xoGkga aujU4tQL6z7Xr6x5DAKSCseECCKXyaeSNzjIGg/KN4IiKWxoJuB8BURGn A==; X-CSE-ConnectionGUID: rbzZ61+6QPGSloCOeYawQA== X-CSE-MsgGUID: sHoAjJp8Rr+mnTPCI4pOwA== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="7931372" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="7931372" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 11:12:54 -0700 X-CSE-ConnectionGUID: 4JwxIqsJQ8iG/aa8qLdXTw== X-CSE-MsgGUID: c4Qe3VIESJuWGUtRrfIBdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="20777552" Received: from osezer-mobl.amr.corp.intel.com (HELO [10.209.70.70]) ([10.209.70.70]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 11:12:52 -0700 Message-ID: <1f6f4477-0f2a-434a-8c89-3b5d51d61581@linux.intel.com> Date: Tue, 9 Apr 2024 11:12:52 -0700 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/14] x86/sev: Hide SVSM attestation entries if not running under an SVSM To: Tom Lendacky , linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev, svsm-devel@coconut-svsm.dev Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Dan Williams , Michael Roth , Ashish Kalra , Joel Becker , Christoph Hellwig References: <67893f352bc54de61160bfe251cba0bdf0431f37.1711405593.git.thomas.lendacky@amd.com> Content-Language: en-US From: Kuppuswamy Sathyanarayanan In-Reply-To: <67893f352bc54de61160bfe251cba0bdf0431f37.1711405593.git.thomas.lendacky@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/25/24 3:26 PM, Tom Lendacky wrote: > Config-fs provides support to hide individual attribute entries. Using > this support, base the display of the SVSM related entries on the presence > of an SVSM. > > Cc: Joel Becker > Cc: Christoph Hellwig > Signed-off-by: Tom Lendacky > --- > arch/x86/coco/core.c | 4 ++++ > drivers/virt/coco/tsm.c | 14 ++++++++++---- > include/linux/cc_platform.h | 8 ++++++++ > 3 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/coco/core.c b/arch/x86/coco/core.c > index d07be9d05cd0..efa0f648f754 100644 > --- a/arch/x86/coco/core.c > +++ b/arch/x86/coco/core.c > @@ -12,6 +12,7 @@ > > #include > #include > +#include > > enum cc_vendor cc_vendor __ro_after_init = CC_VENDOR_NONE; > u64 cc_mask __ro_after_init; > @@ -78,6 +79,9 @@ static bool noinstr amd_cc_platform_has(enum cc_attr attr) > case CC_ATTR_GUEST_STATE_ENCRYPT: > return sev_status & MSR_AMD64_SEV_ES_ENABLED; > > + case CC_ATTR_GUEST_SVSM_PRESENT: > + return snp_get_vmpl(); > + > /* > * With SEV, the rep string I/O instructions need to be unrolled > * but SEV-ES supports them through the #VC handler. > diff --git a/drivers/virt/coco/tsm.c b/drivers/virt/coco/tsm.c > index 46f230bf13ac..d30471874e87 100644 > --- a/drivers/virt/coco/tsm.c > +++ b/drivers/virt/coco/tsm.c > @@ -64,6 +64,12 @@ static struct tsm_report_state *to_state(struct tsm_report *report) > return container_of(report, struct tsm_report_state, report); > } > > +static bool provider_visibility(const struct config_item *item, > + const struct configfs_attribute *attr) > +{ > + return cc_platform_has(CC_ATTR_GUEST_SVSM_PRESENT); > +} > + Any comment about the following query? I think introducing a CC flag for this use case is over kill. https://lore.kernel.org/lkml/6b90b223-46e0-4e6d-a17c-5caf72e3c949@linux.intel.com/ > static int try_advance_write_generation(struct tsm_report *report) > { > struct tsm_report_state *state = to_state(report); > @@ -144,7 +150,7 @@ static ssize_t tsm_report_service_provider_store(struct config_item *cfg, > > return len; > } > -CONFIGFS_ATTR_WO(tsm_report_, service_provider); > +CONFIGFS_ATTR_VISIBLE_WO(tsm_report_, service_provider, provider_visibility); > > static ssize_t tsm_report_service_guid_store(struct config_item *cfg, > const char *buf, size_t len) > @@ -165,7 +171,7 @@ static ssize_t tsm_report_service_guid_store(struct config_item *cfg, > > return len; > } > -CONFIGFS_ATTR_WO(tsm_report_, service_guid); > +CONFIGFS_ATTR_VISIBLE_WO(tsm_report_, service_guid, provider_visibility); > > static ssize_t tsm_report_service_manifest_version_store(struct config_item *cfg, > const char *buf, size_t len) > @@ -186,7 +192,7 @@ static ssize_t tsm_report_service_manifest_version_store(struct config_item *cfg > > return len; > } > -CONFIGFS_ATTR_WO(tsm_report_, service_manifest_version); > +CONFIGFS_ATTR_VISIBLE_WO(tsm_report_, service_manifest_version, provider_visibility); > > static ssize_t tsm_report_inblob_write(struct config_item *cfg, > const void *buf, size_t count) > @@ -333,7 +339,7 @@ static ssize_t tsm_report_manifestblob_read(struct config_item *cfg, void *buf, > > return tsm_report_read(report, buf, count, TSM_MANIFEST); > } > -CONFIGFS_BIN_ATTR_RO(tsm_report_, manifestblob, NULL, TSM_OUTBLOB_MAX); > +CONFIGFS_BIN_ATTR_VISIBLE_RO(tsm_report_, manifestblob, NULL, TSM_OUTBLOB_MAX, provider_visibility); > > #define TSM_DEFAULT_ATTRS() \ > &tsm_report_attr_generation, \ > diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h > index cb0d6cd1c12f..f1b4266c1484 100644 > --- a/include/linux/cc_platform.h > +++ b/include/linux/cc_platform.h > @@ -90,6 +90,14 @@ enum cc_attr { > * Examples include TDX Guest. > */ > CC_ATTR_HOTPLUG_DISABLED, > + > + /** > + * @CC_ATTR_GUEST_SVSM_PRESENT: Guest is running under an SVSM > + * > + * The platform/OS is running as a guest/virtual machine and is > + * running under a Secure VM Service Module (SVSM). > + */ > + CC_ATTR_GUEST_SVSM_PRESENT, > }; > > #ifdef CONFIG_ARCH_HAS_CC_PLATFORM -- Sathyanarayanan Kuppuswamy Linux Kernel Developer