From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB8F6882E for ; Mon, 20 Feb 2023 21:37:13 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id a30so2555118ljr.0 for ; Mon, 20 Feb 2023 13:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ntTegXxHE2C6Lp8xdtMzn8aIclw1LjjCN5pS0JeaA8A=; b=K8zGSFBNI3bdU6J5gbrSYZcfL5sYsQjVxJTFkpIjhAqxR1Xxr817nUsCsnvL/JrUMp qoPWnoDVVtnpBTvblsnDdqASG0UQ7WxtCHGWIaD8xXMKvw5xxrEYv2zRrGw6EEzNHKUj UvEzax+npqRsxhJ8JA5VL57mkKzv9SPf0eqWr2PQ9wgxyXnOW9NxfdumExqueZbw8FsP wisNc6cs8i8MKfQZbkfwjawdBzTETXo+kIWV3oi/vN1tHuW82XTJjBjtLNQC8BQNNasi WK8w/uHuMYgkSPwZ4AYAG3k6i5mpyxrTtxYMwhqKcy7nCMpQ5pEsrC1o/nSFiQWyHmA1 CWng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntTegXxHE2C6Lp8xdtMzn8aIclw1LjjCN5pS0JeaA8A=; b=ya7LdRIXITTrwzFDaR703zNNeiF8bb1BDylGY1sr7bOnPunx4I6f24Cf40/IGxlrZk u4wFRHYW47C859tF45hFdS/QCy1vtBHIinfq05qZ54w7b1CFMtigq/JcP3f+YUdDAr4M aFESFg2CM+BKepSeEMLhNk2T91m5te/hEPJwggOp6DI7FqFDGZOXSVzhJKqs6JyKo0bk 6mnlQwzMH7qXW46+2+VKnifxNUcU0xt7DuwY0QeHanuRPs1yqepDZULlmAwPPlDBLA/n TytrJ7xJ3706Elq6fwezeh0E0WzF75/DPNfjoau1y0AQJhA/Gd0sSFHWmj0UjhWBKtlS va1A== X-Gm-Message-State: AO0yUKVYLZyrkDqfjtu7g5PqAf3mcOpNDMqmHUHqlqPteG/A/r4GRviJ IyYM2+OYUUBStQC32ReLv88= X-Google-Smtp-Source: AK7set9ere6899+uPRGjAaNY74PLHi6orKNOrPSws3NLJTJtiICDHHa4uvOj8GLhs/n/V591Itkx1Q== X-Received: by 2002:a05:651c:210f:b0:293:52a4:9717 with SMTP id a15-20020a05651c210f00b0029352a49717mr1528073ljq.4.1676929031468; Mon, 20 Feb 2023 13:37:11 -0800 (PST) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id y2-20020a2e3202000000b002934ff9c817sm401104ljy.107.2023.02.20.13.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 13:37:11 -0800 (PST) Date: Mon, 20 Feb 2023 23:37:09 +0200 From: Zhi Wang To: Michael Roth Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Vishal Annapurve Subject: Re: [PATCH RFC v8 04/56] KVM: Add HVA range operator Message-ID: <20230220233709.00006dfc@gmail.com> In-Reply-To: <20230220183847.59159-5-michael.roth@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-5-michael.roth@amd.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 20 Feb 2023 12:37:55 -0600 Michael Roth wrote: > From: Vishal Annapurve > > Introduce HVA range operator so that other KVM subsystems > can operate on HVA range. > > Signed-off-by: Vishal Annapurve > [mdr: minor checkpatch alignment fixups] > Signed-off-by: Michael Roth > --- > include/linux/kvm_host.h | 6 +++++ > virt/kvm/kvm_main.c | 48 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 4d542060cd93..c615650ed256 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1402,6 +1402,12 @@ void kvm_mmu_invalidate_begin(struct kvm *kvm); > void kvm_mmu_invalidate_range_add(struct kvm *kvm, gfn_t start, gfn_t end); > void kvm_mmu_invalidate_end(struct kvm *kvm); > > +typedef int (*kvm_hva_range_op_t)(struct kvm *kvm, > + struct kvm_gfn_range *range, void *data); > + > +int kvm_vm_do_hva_range_op(struct kvm *kvm, unsigned long hva_start, > + unsigned long hva_end, kvm_hva_range_op_t handler, void *data); > + > long kvm_arch_dev_ioctl(struct file *filp, > unsigned int ioctl, unsigned long arg); > long kvm_arch_vcpu_ioctl(struct file *filp, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index f7e00593cc5d..4ccd655dd5af 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -642,6 +642,54 @@ static __always_inline int __kvm_handle_hva_range(struct kvm *kvm, > return (int)ret; > } > Below function seems a reduced duplicate of __kvm_handle_hva_range() in virt/kvm/kvm_main.c. It would be nice to factor __kvm_handle_hva_range(). > +int kvm_vm_do_hva_range_op(struct kvm *kvm, unsigned long hva_start, > + unsigned long hva_end, kvm_hva_range_op_t handler, void *data) > +{ > + int ret = 0; > + struct kvm_gfn_range gfn_range; > + struct kvm_memory_slot *slot; > + struct kvm_memslots *slots; > + int i, idx; > + > + if (WARN_ON_ONCE(hva_end <= hva_start)) > + return -EINVAL; > + > + idx = srcu_read_lock(&kvm->srcu); > + > + for (i = 0; i < kvm_arch_nr_memslot_as_ids(kvm); i++) { > + struct interval_tree_node *node; > + > + slots = __kvm_memslots(kvm, i); > + kvm_for_each_memslot_in_hva_range(node, slots, > + hva_start, hva_end - 1) { > + unsigned long start, end; > + > + slot = container_of(node, struct kvm_memory_slot, > + hva_node[slots->node_idx]); > + start = max(hva_start, slot->userspace_addr); > + end = min(hva_end, slot->userspace_addr + > + (slot->npages << PAGE_SHIFT)); > + > + /* > + * {gfn(page) | page intersects with [hva_start, hva_end)} = > + * {gfn_start, gfn_start+1, ..., gfn_end-1}. > + */ > + gfn_range.start = hva_to_gfn_memslot(start, slot); > + gfn_range.end = hva_to_gfn_memslot(end + PAGE_SIZE - 1, slot); > + gfn_range.slot = slot; > + > + ret = handler(kvm, &gfn_range, data); > + if (ret) > + goto e_ret; > + } > + } > + > +e_ret: > + srcu_read_unlock(&kvm->srcu, idx); > + > + return ret; > +} > + > static __always_inline int kvm_handle_hva_range(struct mmu_notifier *mn, > unsigned long start, > unsigned long end,