From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Borislav Petkov <bp@alien8.de>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Sean Christopherson <seanjc@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>, Ard Biesheuvel <ardb@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Tom Lendacky <thomas.lendacky@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Dario Faggioli <dfaggioli@suse.com>,
Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
aarcange@redhat.com, peterx@redhat.com, x86@kernel.org,
linux-mm@kvack.org, linux-coco@lists.linux.dev,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv14 0/9] mm, x86/cc, efi: Implement support for unaccepted memory
Date: Tue, 6 Jun 2023 21:14:44 +0300 [thread overview]
Message-ID: <20230606181444.2rxorg6gaeasgugx@box.shutemov.name> (raw)
In-Reply-To: <20230606161606.GDZH9bxhrGnFkaLl2A@fat_crate.local>
On Tue, Jun 06, 2023 at 06:16:06PM +0200, Borislav Petkov wrote:
> On Tue, Jun 06, 2023 at 05:26:28PM +0300, Kirill A. Shutemov wrote:
> > v14:
> > - Fix error handling in arch_accept_memory() (Tom);
> > - Address Borislav's feedback:
> > + code restructure;
> > + added/adjusted comments;
>
> In file included from arch/x86/coco/tdx/tdx-shared.c:1:
> ./arch/x86/include/asm/tdx.h: In function ‘tdx_kvm_hypercall’:
> ./arch/x86/include/asm/tdx.h:70:17: error: ‘ENODEV’ undeclared (first use in this function)
> 70 | return -ENODEV;
> | ^~~~~~
> ./arch/x86/include/asm/tdx.h:70:17: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [scripts/Makefile.build:252: arch/x86/coco/tdx/tdx-shared.o] Error 1
> make[3]: *** [scripts/Makefile.build:494: arch/x86/coco/tdx] Error 2
> make[2]: *** [scripts/Makefile.build:494: arch/x86/coco] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [scripts/Makefile.build:494: arch/x86] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:2026: .] Error 2
>
> Not enough build tests ran?
Hm. I've got a lot of reports from 0day, but never this one.
Kai has posted patch that fixes it already:
https://lore.kernel.org/all/20230606034000.380270-1-kai.huang@intel.com/
> $ grep INTEL_TDX_GUEST .config
> CONFIG_INTEL_TDX_GUEST=y
> $ grep KVM_GUEST .config
> $
>
> Why does that tdx_kvm_hypercall() thing even depend on CONFIG_KVM_GUEST?
Because nobody uses it otherwise. For instance, Hyper-V guest will no need
this KVM glue.
--
Kiryl Shutsemau / Kirill A. Shutemov
prev parent reply other threads:[~2023-06-06 18:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:26 [PATCHv14 0/9] mm, x86/cc, efi: Implement support for unaccepted memory Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 1/9] mm: Add " Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 2/9] efi/x86: Get full memory map in allocate_e820() Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 3/9] efi/libstub: Implement support for unaccepted memory Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 4/9] x86/boot/compressed: Handle " Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 5/9] efi: Add unaccepted memory support Kirill A. Shutemov
2023-07-03 13:25 ` Mel Gorman
2023-07-04 14:37 ` Kirill A. Shutemov
2023-07-12 9:18 ` Mel Gorman
2023-10-10 21:05 ` Michael Roth
2023-10-13 12:33 ` Kirill A. Shutemov
2023-10-13 16:22 ` Kirill A. Shutemov
2023-10-13 16:44 ` Vlastimil Babka
2023-10-13 17:27 ` Kirill A. Shutemov
2023-10-13 21:54 ` Kirill A. Shutemov
2023-10-13 17:45 ` Tom Lendacky
2023-10-13 19:53 ` Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 6/9] efi/unaccepted: Avoid load_unaligned_zeropad() stepping into unaccepted memory Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 7/9] x86/tdx: Make _tdx_hypercall() and __tdx_module_call() available in boot stub Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 8/9] x86/tdx: Refactor try_accept_one() Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 9/9] x86/tdx: Add unaccepted memory support Kirill A. Shutemov
2023-06-06 16:16 ` [PATCHv14 0/9] mm, x86/cc, efi: Implement support for unaccepted memory Borislav Petkov
2023-06-06 16:25 ` Borislav Petkov
2023-06-06 18:14 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606181444.2rxorg6gaeasgugx@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=dfaggioli@suse.com \
--cc=jroedel@suse.de \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=philip.cox@canonical.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.gardner@canonical.com \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).