From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Huang, Kai" <kai.huang@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"dionnaglaze@google.com" <dionnaglaze@google.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"Aktas, Erdem" <erdemaktas@google.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"shuah@kernel.org" <shuah@kernel.org>,
"Du, Fan" <fan.du@intel.com>, "Luck, Tony" <tony.luck@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
"joey.gouly@arm.com" <joey.gouly@arm.com>,
"qinkun@apache.org" <qinkun@apache.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"wander@redhat.com" <wander@redhat.com>,
"atishp@rivosinc.com" <atishp@rivosinc.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"chongc@google.com" <chongc@google.com>,
"bp@alien8.de" <bp@alien8.de>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"Yu, Guorui" <guorui.yu@linux.alibaba.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation feature
Date: Wed, 28 Jun 2023 08:46:08 +0200 [thread overview]
Message-ID: <2023062805-drove-privatize-ae2c@gregkh> (raw)
In-Reply-To: <c85324480053af20e6f0409e28fbc5e156c54143.camel@intel.com>
On Wed, Jun 28, 2023 at 02:16:45AM +0000, Huang, Kai wrote:
> > You really shouldn't be putting attestation validation logic in the
> > kernel.
>
> Agreed. The data blob for remote verification should be just some data blob to
> the kernel. I think the kernel shouldn't even try to understand the data blob
> is for which architecture. From the kernel's perspective, it should be just
> some data blob that the kernel gets from hardware/firmware or whatever embedded
> in the root-of-trust in the hardware after taking some input from usrspace for
> the unique identity of the blob that can be used to, e.g., mitigate replay-
> attack, etc.
Great, then use the common "data blob" api that we have in the kernel
for a very long time now, the "firwmare download" api, or the sysfs
binary file api. Both of them just use the kernel as a pass-through and
do not touch the data at all. No need for crazy custom ioctls and all
that mess :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-28 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
[not found] ` <972e1d5c5ec53e2757fb17a586558c5385e987dd.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
[not found] ` <64876bf6c30e2_1433ac29415@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <64961c3baf8ce_142af829436@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <9437b176-e15a-3cec-e5cb-68ff57dbc25c@linux.intel.com>
2023-06-26 18:57 ` [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation feature Dionna Amalie Glaze
2023-06-27 0:39 ` Sathyanarayanan Kuppuswamy
2023-06-28 15:41 ` Samuel Ortiz
2023-06-28 15:55 ` Sathyanarayanan Kuppuswamy
2023-06-28 0:11 ` Dan Williams
2023-06-28 1:36 ` Dionna Amalie Glaze
2023-06-28 2:16 ` Huang, Kai
2023-06-28 6:46 ` gregkh [this message]
2023-06-28 8:56 ` Huang, Kai
2023-06-28 9:02 ` gregkh
2023-06-28 9:45 ` Huang, Kai
2023-06-28 2:52 ` Dan Williams
2023-06-29 16:25 ` Dionna Amalie Glaze
2023-06-28 15:31 ` Samuel Ortiz
2023-06-28 15:24 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062805-drove-privatize-ae2c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=atishp@rivosinc.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=chongc@google.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=dionnaglaze@google.com \
--cc=erdemaktas@google.com \
--cc=fan.du@intel.com \
--cc=guorui.yu@linux.alibaba.com \
--cc=hpa@zytor.com \
--cc=joey.gouly@arm.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qinkun@apache.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).