From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD7F11A71F for ; Mon, 9 Oct 2023 13:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="b9iqcUnq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696858378; x=1728394378; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KQiIeN5ST8uGhtT0LhMJYQQaH+STe2BjgqRaOYnAfTw=; b=b9iqcUnqbutObW/AHOoYiMSoLUbgCcT09dKNXLIAbH1EY5M3mWRJ8vak lbwSjC2CS77CwAHczrNoKAsJkGRnZ7ZLNty9eJ9NzTaFCgwW/6f68lrOG HsLMXgkm8GQqtLkcJtEagtg6BbiMceKTZDTpgoCuTHsJfYFqKmNJEGMmt ebNd86T4cBJwTXSgtwcubUgDIvyMb2c/87CnKNH0Y8iws1M6d6vVprCCI 9yOySRqFW75+u7E15uHZIJPibnlv3zCMbaLThb1VmKGFavGvj7SMRSCqu izEVGXTEoTMeDCkZDzfh9U0yH9pxKSoDCZaDwXohMd2P1xNkH6qmgu6is g==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="374473689" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="374473689" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 06:32:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="782491307" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="782491307" Received: from ahuge-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.40.233]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 06:32:53 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 4EAB710A196; Mon, 9 Oct 2023 16:32:51 +0300 (+03) Date: Mon, 9 Oct 2023 16:32:51 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "Edgecombe, Rick P" , "Reshetova, Elena" , "Nakajima, Jun" , "rafael@kernel.org" , "peterz@infradead.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Hunter, Adrian" , "thomas.lendacky@amd.com" , "linux-kernel@vger.kernel.org" , "kexec@lists.infradead.org" , "linux-coco@lists.linux.dev" Subject: Re: [PATCH 05/13] x86/kexec: Keep CR4.MCE set during kexec for TDX guest Message-ID: <20231009133251.lmdubojesxtwzdyl@box.shutemov.name> References: <20231005131402.14611-1-kirill.shutemov@linux.intel.com> <20231005131402.14611-6-kirill.shutemov@linux.intel.com> <2c76fa83b154566e49425e3a7ccc9a268318d63a.camel@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c76fa83b154566e49425e3a7ccc9a268318d63a.camel@intel.com> On Mon, Oct 09, 2023 at 12:30:55PM +0000, Huang, Kai wrote: > On Thu, 2023-10-05 at 16:13 +0300, Kirill A. Shutemov wrote: > > TDX guests are not allowed to clear CR4.MCE. Attempt to clear it leads > > to #VE. > > > > Use alternatives to keep the flag during kexec for TDX guests. > > > > The change doesn't affect non-TDX environments. > > Nit: non-TDX-guest environments. ? Okay, will fix. > > Signed-off-by: Kirill A. Shutemov > > Reviewed-by: Kai Huang Thanks. -- Kiryl Shutsemau / Kirill A. Shutemov