From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 092B5DDAB for ; Fri, 20 Oct 2023 10:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lO3MWNFS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697798562; x=1729334562; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=I1QT8NLCZxYYRpmRYZW3+A0VC3zncef/y0csj15rovI=; b=lO3MWNFST67vA6kHNliZD9hXNuo6hTi4ffxYZItKQwBZ7jPjC3glLgGE xC9NjeSwxr44CU3uyVSKJmVBUOnXLxNuChgbsRcQHCQywP4pi6vMADP7Z 6MHltj+JOvUpoyOVGcO53dX2EExZSwUJzxSMwb/0oiTJ/bxqOxmHhC8S4 ehci0Ci+GH90/Jdxtsi98ok7i2otaJhGTPGVu0Lo+CB28lEyvsVMLbMDn uvyB+iN564Lz5xbG+jPqOqgeYoBb+39XXJoI+kf1ScXSSUxSxQS/AN6Xm GGBUaJvcn9w/xYNebGK9lSqwAlM/lFq8kUQg+84VDWn5293B7CshYNWbv w==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="8039381" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="8039381" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 03:42:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="707200102" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="707200102" Received: from dgutows1-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.39.237]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 03:42:36 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 20789109D0A; Fri, 20 Oct 2023 13:42:34 +0300 (+03) Date: Fri, 20 Oct 2023 13:42:34 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "Edgecombe, Rick P" , "Reshetova, Elena" , "Nakajima, Jun" , "rafael@kernel.org" , "peterz@infradead.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Hunter, Adrian" , "thomas.lendacky@amd.com" , "linux-kernel@vger.kernel.org" , "kexec@lists.infradead.org" , "linux-coco@lists.linux.dev" Subject: Re: [PATCH 13/13] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Message-ID: <20231020104234.s2qqfssultevcnlr@box.shutemov.name> References: <20231005131402.14611-1-kirill.shutemov@linux.intel.com> <20231005131402.14611-14-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Oct 20, 2023 at 09:49:59AM +0000, Huang, Kai wrote: > On Thu, 2023-10-05 at 16:14 +0300, Kirill A. Shutemov wrote: > >  struct acpi_madt_multiproc_wakeup { > >   struct acpi_subtable_header header; > > - u16 mailbox_version; > > + u16 version; > >   u32 reserved; /* reserved - must be zero */ > > - u64 base_address; > > + u64 mailbox_address; > > + u64 reset_vector; > >  }; > > I don't quite understand the connection between the renaming and what this patch > wants to achieve? What's the reason to rename? Names are bad: the version field guides version of the structure, not version of the mailbox. And it is not clear what base base_address specifies. > If needed, perhaps put into a separate patch with proper justification? Hm. Okay... -- Kiryl Shutsemau / Kirill A. Shutemov