From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B1996413B for ; Tue, 12 Dec 2023 21:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oBWPCFgl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6D06C433C9; Tue, 12 Dec 2023 21:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702417027; bh=YG9YY9iEszGGckGfEsHdcd7GRr37WZ5+YKaXd/4SyBA=; h=From:To:Cc:Subject:Date:From; b=oBWPCFgld2/BjYDNaG8jaEnt7Cx9tpnd7KcYCtbnA5rD52Cy82NwBE9XJAGFsqCM3 U6utTvXQcKjl6EnuRdn5XM+B2DZOrua3ymFoTqGqxoCjxOrqurFzf5It6UbOfaXIUZ KkNa23uvx7WyLkk7RRt02tVKDrnAW7xXwbcQ48gvRps2teHFuNi8A3f9D0mjUvm6Je 0S2d4DZjkdycE2IpzxEdbrn5vVRnZlG14rsmR30Qgp7JjcyARWj3zyuoiVvnG8FYGA oEs1GshsyyENWFrnzZO+IC6VpHwflKZVK9pwKzW66VYsqqrAQkujmqJA3zZ4wjts5m yGrB/+QUyHozQ== From: Arnd Bergmann To: "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Yuan Yao , Kai Huang , Tony Luck Cc: Arnd Bergmann , "H. Peter Anvin" , Isaku Yamahata , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] x86: tdx: hide unused tdx_dump_mce_info() Date: Tue, 12 Dec 2023 22:36:50 +0100 Message-Id: <20231212213701.4174806-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann When TDX is enabled but MCE is not, the tdx_dump_mce_info() function fails to link: ld.lld: error: undefined symbol: mce_is_memory_error ld.lld: error: undefined symbol: mce_usable_address >>> referenced by usercopy_64.c >>> vmlinux.o:(tdx_dump_mce_info) In this configuration, there is also no caller for the function, so avoid the problem by enclosing it in an #ifdef block. Fixes: 45f31973967d ("x86/mce: Differentiate real hardware #MCs from TDX erratum ones") Signed-off-by: Arnd Bergmann --- arch/x86/virt/vmx/tdx/tdx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index 13df68ef40b5..3af7a7e2d8d0 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -1245,6 +1245,7 @@ int tdx_enable(void) } EXPORT_SYMBOL_GPL(tdx_enable); +#ifdef CONFIG_X86_MCE static bool is_pamt_page(unsigned long phys) { struct tdmr_info_list *tdmr_list = &tdx_tdmr_list; @@ -1344,6 +1345,7 @@ const char *tdx_dump_mce_info(struct mce *m) return "TDX private memory error. Possible kernel bug."; } +#endif static __init int record_keyid_partitioning(u32 *tdx_keyid_start, u32 *nr_tdx_keyids) -- 2.39.2