From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: kirill.shutemov@linux.intel.com
Cc: adrian.hunter@intel.com, ashish.kalra@amd.com, bhe@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com,
elena.reshetova@intel.com, jun.nakajima@intel.com,
kai.huang@intel.com, kexec@lists.infradead.org,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, rafael@kernel.org,
rick.p.edgecombe@intel.com,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
tglx@linutronix.de, thomas.lendacky@amd.com, x86@kernel.org
Subject: [PATCHv5.1 14/16] x86/smp: Add smp_ops.stop_this_cpu() callback
Date: Mon, 25 Dec 2023 11:05:24 +0300 [thread overview]
Message-ID: <20231225080524.4240-1-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <20231222235209.32143-15-kirill.shutemov@linux.intel.com>
If the helper is defined, it is called instead of halt() to stop the CPU
at the end of stop_this_cpu() and on crash CPU shutdown.
ACPI MADT will use it to hand over the CPU to BIOS in order to be able
to wake it up again after kexec.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
v5.1:
- Fix build for !SMP;
---
arch/x86/include/asm/smp.h | 1 +
arch/x86/kernel/process.c | 7 +++++++
arch/x86/kernel/reboot.c | 12 ++++++++----
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
index 4fab2ed454f3..390d53fd34f9 100644
--- a/arch/x86/include/asm/smp.h
+++ b/arch/x86/include/asm/smp.h
@@ -38,6 +38,7 @@ struct smp_ops {
int (*cpu_disable)(void);
void (*cpu_die)(unsigned int cpu);
void (*play_dead)(void);
+ void (*stop_this_cpu)(void);
void (*send_call_func_ipi)(const struct cpumask *mask);
void (*send_call_func_single_ipi)(int cpu);
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index b6f4e8399fca..ea4c812c7bf3 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -835,6 +835,13 @@ void __noreturn stop_this_cpu(void *dummy)
*/
cpumask_clear_cpu(cpu, &cpus_stop_mask);
+#ifdef CONFIG_SMP
+ if (smp_ops.stop_this_cpu) {
+ smp_ops.stop_this_cpu();
+ unreachable();
+ }
+#endif
+
for (;;) {
/*
* Use native_halt() so that memory contents don't change
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 16dde83df49a..738b3e810196 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -881,10 +881,14 @@ static int crash_nmi_callback(unsigned int val, struct pt_regs *regs)
cpu_emergency_disable_virtualization();
atomic_dec(&waiting_for_crash_ipi);
- /* Assume hlt works */
- halt();
- for (;;)
- cpu_relax();
+
+ if (smp_ops.stop_this_cpu) {
+ smp_ops.stop_this_cpu();
+ } else {
+ halt();
+ for (;;)
+ cpu_relax();
+ }
return NMI_HANDLED;
}
--
2.41.0
next prev parent reply other threads:[~2023-12-25 8:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 23:51 [PATCHv5 00/16] x86/tdx: Add kexec support Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 01/16] x86/acpi: Extract ACPI MADT wakeup code into a separate file Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 02/16] x86/apic: Mark acpi_mp_wake_* variables as __ro_after_init Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 03/16] cpu/hotplug: Add support for declaring CPU offlining not supported Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 04/16] cpu/hotplug, x86/acpi: Disable CPU offlining for ACPI MADT wakeup Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 05/16] x86/kvm: Do not try to disable kvmclock if it was not enabled Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 06/16] x86/kexec: Keep CR4.MCE set during kexec for TDX guest Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 07/16] x86/mm: Make x86_platform.guest.enc_status_change_*() return errno Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 08/16] x86/mm: Return correct level from lookup_address() if pte is none Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 09/16] x86/tdx: Account shared memory Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 10/16] x86/tdx: Convert shared memory back to private on kexec Kirill A. Shutemov
2024-01-05 19:38 ` Edgecombe, Rick P
2024-01-06 0:59 ` kirill.shutemov
2024-01-06 1:12 ` Edgecombe, Rick P
2024-01-15 10:53 ` Nikolay Borisov
2024-01-16 7:28 ` Kirill A. Shutemov
2024-01-16 8:01 ` Nikolay Borisov
2024-01-16 10:45 ` Kirill A. Shutemov
2024-01-16 10:53 ` Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 11/16] x86/mm: Make e820_end_ram_pfn() cover E820_TYPE_ACPI ranges Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 12/16] x86/acpi: Rename fields in acpi_madt_multiproc_wakeup structure Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 13/16] x86/acpi: Do not attempt to bring up secondary CPUs in kexec case Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 14/16] x86/smp: Add smp_ops.stop_this_cpu() callback Kirill A. Shutemov
2023-12-25 8:05 ` Kirill A. Shutemov [this message]
2024-01-08 3:04 ` [PATCHv5.1 " Huang, Kai
2024-01-08 10:15 ` kirill.shutemov
2024-01-09 3:04 ` Huang, Kai
2023-12-22 23:52 ` [PATCHv5 15/16] x86/mm: Introduce kernel_ident_mapping_free() Kirill A. Shutemov
2024-01-08 3:13 ` Huang, Kai
2024-01-08 3:30 ` Huang, Kai
2024-01-08 10:17 ` kirill.shutemov
2024-01-08 13:13 ` Huang, Kai
2024-01-08 13:35 ` kirill.shutemov
2023-12-22 23:52 ` [PATCHv5 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Kirill A. Shutemov
2024-01-15 13:19 ` Nikolay Borisov
2024-01-16 6:50 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225080524.4240-1-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=ashish.kalra@amd.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kai.huang@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).