From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev
Cc: Juergen Gross <jgross@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH] x86/kvm/tdx: Save %rbp in TDX_MODULE_CALL
Date: Fri, 17 May 2024 14:14:50 +0200 [thread overview]
Message-ID: <20240517121450.20420-1-jgross@suse.com> (raw)
While testing TDX host support patches, a crash of the host has been
observed a few instructions after doing a seamcall. Reason was a
clobbered %rbp (set to 0), which occurred in spite of the TDX module
offering the feature NOT to modify %rbp across TDX module calls.
In order not having to build the host kernel with CONFIG_FRAME_POINTER,
save %rbp across a seamcall/tdcall.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/virt/vmx/tdx/tdxcall.S | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/virt/vmx/tdx/tdxcall.S b/arch/x86/virt/vmx/tdx/tdxcall.S
index 016a2a1ec1d6..68728acf0d3a 100644
--- a/arch/x86/virt/vmx/tdx/tdxcall.S
+++ b/arch/x86/virt/vmx/tdx/tdxcall.S
@@ -44,6 +44,10 @@
*/
.macro TDX_MODULE_CALL host:req ret=0 saved=0
FRAME_BEGIN
+#ifndef CONFIG_FRAME_POINTER
+ /* Buggy firmware sometimes clobbers %rbp, so save it. */
+ pushq %rbp
+#endif
/* Move Leaf ID to RAX */
mov %rdi, %rax
@@ -187,6 +191,9 @@
popq %rbx
.endif /* \saved */
+#ifndef CONFIG_FRAME_POINTER
+ popq %rbp
+#endif
FRAME_END
RET
--
2.35.3
next reply other threads:[~2024-05-17 12:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 12:14 Juergen Gross [this message]
2024-05-17 13:55 ` [PATCH] x86/kvm/tdx: Save %rbp in TDX_MODULE_CALL Kirill A. Shutemov
2024-05-17 14:08 ` Juergen Gross
2024-05-17 14:39 ` Kirill A. Shutemov
2024-05-17 14:41 ` Kirill A. Shutemov
2024-05-17 14:44 ` Juergen Gross
2024-05-17 15:16 ` Dave Hansen
2024-05-17 15:27 ` Jürgen Groß
2024-05-17 15:43 ` Dave Hansen
2024-05-17 15:48 ` Juergen Gross
2024-05-17 15:52 ` Dave Hansen
2024-05-17 15:58 ` Juergen Gross
2024-05-17 16:48 ` Dave Hansen
2024-05-20 11:54 ` Huang, Kai
2024-05-23 5:56 ` Jürgen Groß
2024-05-23 10:30 ` Huang, Kai
2024-05-23 12:26 ` Huang, Kai
2024-05-23 12:43 ` Jürgen Groß
2024-05-23 22:34 ` Huang, Kai
2024-05-23 23:28 ` Huang, Kai
2024-05-24 5:46 ` Jürgen Groß
2024-05-17 16:12 ` Sean Christopherson
2024-05-17 16:34 ` Dave Hansen
2024-05-17 17:01 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517121450.20420-1-jgross@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox