Re: [PATCH 14/20] x86/tdx: Add macros to generate TDCALL wrappers

Paolo Bonzini
2024-05-17T17:05:09Z

On 5/17/24 16:19, Kirill A. Shutemov wrote:
> Introduce a set of macros that allow to generate wrappers for TDCALL
> leafs.
>
> There are three macros differentiated by number of return parameters.
>
> Signed-off-by: Kirill A. Shutemov<kirill.shutemov@linux.intel.com>
> ---
> arch/x86/include/asm/shared/tdx.h | 58 +++++++++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)

Can you explain in the commit message why you picked a different
approach? That is, a sequence of inlined movq instructions here vs.
compiler-generated movqs + a trampoline for TDVMCALL.

Paolo