linux-coco.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: vsntk18@gmail.com
To: vsntk18@gmail.com
Cc: x86@kernel.org, Borislav.Petkov@amd.com, Dhaval.Giani@amd.com,
	ashish.kalra@amd.com, cfir@google.com, dan.j.williams@intel.com,
	dave.hansen@linux.intel.com, ebiederm@xmission.com,
	erdemaktas@google.com, hpa@zytor.com, jgross@suse.com,
	jroedel@suse.de, jslaby@suse.cz, keescook@chromium.org,
	kexec@lists.infradead.org, kvm@vger.kernel.org,
	linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
	luto@kernel.org, martin.b.radev@gmail.com, mhiramat@kernel.org,
	michael.roth@amd.com, mstunes@vmware.com, nivedita@alum.mit.edu,
	peterz@infradead.org, rientjes@google.com, seanjc@google.com,
	stable@vger.kernel.org, thomas.lendacky@amd.com,
	virtualization@lists.linux-foundation.org, vkarasulli@suse.de
Subject: [PATCH v6 10/10] x86/sev: Exclude AP jump table related code for SEV-SNP guests
Date: Mon, 10 Jun 2024 12:21:13 +0200	[thread overview]
Message-ID: <20240610102113.20969-11-vsntk18@gmail.com> (raw)
In-Reply-To: <20240610102113.20969-1-vsntk18@gmail.com>

From: Vasant Karasulli <vkarasulli@suse.de>

Unlike SEV-ES, AP jump table technique is not used in SEV-SNP
when transitioning from one layer of code to another
(e.g. when going from UEFI to the OS).

Signed-off-by: Vasant Karasulli <vkarasulli@suse.de>
---
 arch/x86/kernel/sev.c    | 6 +++++-
 arch/x86/realmode/init.c | 5 +++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index e64320507da2..a9cf74512269 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -1392,7 +1392,8 @@ STACK_FRAME_NON_STANDARD(sev_jumptable_ap_park);
 void sev_es_stop_this_cpu(void)
 {
 	if (!(cc_vendor == CC_VENDOR_AMD) ||
-	    !cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT))
+	    !cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT) ||
+	     cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
 		return;
 
 	/* Only park in the AP jump table when the code has been installed */
@@ -1468,6 +1469,9 @@ bool sev_kexec_supported(void)
 	if (!cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT))
 		return true;
 
+	if (cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
+		return false;
+
 	/*
 	 * KEXEC with SEV-ES and more than one CPU is only supported
 	 * when the AP jump table is installed.
diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
index f9bc444a3064..ed798939be5d 100644
--- a/arch/x86/realmode/init.c
+++ b/arch/x86/realmode/init.c
@@ -80,8 +80,9 @@ static void __init sme_sev_setup_real_mode(struct trampoline_header *th)
 		 */
 		th->start = (u64) secondary_startup_64_no_verify;
 
-		if (sev_es_setup_ap_jump_table(real_mode_header))
-			panic("Failed to get/update SEV-ES AP Jump Table");
+		if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
+			if (sev_es_setup_ap_jump_table(real_mode_header))
+				panic("Failed to get/update SEV-ES AP Jump Table");
 	}
 #endif
 }
-- 
2.34.1


  parent reply	other threads:[~2024-06-10 10:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 10:21 [PATCH v6 00/10] x86/sev: KEXEC/KDUMP support for SEV-ES guests vsntk18
2024-06-10 10:21 ` [PATCH v6 01/10] x86/kexec/64: Disable kexec when SEV-ES is active vsntk18
2024-06-10 10:21 ` [PATCH v6 02/10] x86/sev: Save and print negotiated GHCB protocol version vsntk18
2024-06-10 10:21 ` [PATCH v6 03/10] x86/sev: Set GHCB data structure version vsntk18
2024-06-10 10:21 ` [PATCH v6 04/10] x86/sev: Setup code to park APs in the AP Jump Table vsntk18
2024-06-10 10:21 ` [PATCH v6 05/10] x86/sev: Park APs on AP Jump Table with GHCB protocol version 2 vsntk18
2024-06-10 10:21 ` [PATCH v6 06/10] x86/sev: Use AP Jump Table blob to stop CPU vsntk18
2024-06-10 10:21 ` [PATCH v6 07/10] x86/sev: Add MMIO handling support to boot/compressed/ code vsntk18
2024-06-10 10:21 ` [PATCH v6 08/10] x86/sev: Handle CLFLUSH MMIO events vsntk18
2024-06-10 10:21 ` [PATCH v6 09/10] x86/kexec/64: Support kexec under SEV-ES with AP Jump Table Blob vsntk18
2024-06-10 10:21 ` vsntk18 [this message]
2024-06-10 10:30 ` [PATCH v6 00/10] x86/sev: KEXEC/KDUMP support for SEV-ES guests Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610102113.20969-11-vsntk18@gmail.com \
    --to=vsntk18@gmail.com \
    --cc=Borislav.Petkov@amd.com \
    --cc=Dhaval.Giani@amd.com \
    --cc=ashish.kalra@amd.com \
    --cc=cfir@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ebiederm@xmission.com \
    --cc=erdemaktas@google.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=jroedel@suse.de \
    --cc=jslaby@suse.cz \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=martin.b.radev@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mstunes@vmware.com \
    --cc=nivedita@alum.mit.edu \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vkarasulli@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).