From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E003D176259; Wed, 28 Aug 2024 13:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724852995; cv=none; b=MfAU9PRe5u8tH0/ddnnkE5ney3DSS2NCaHaty+ztB0Q450NtzXq79zyoRhLb0ALbopznmJt3X1sugdMHcGPE3shq9/u+BcmLfJVZIU5TOUyd3nmQ147LtIiJo7xX/wQxR7v7TnlnqYjaGovlBms4SXyOzujOzOETkkd8k6ovGFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724852995; c=relaxed/simple; bh=MlvzK++rts6N5s5ER6D1ysWQa4XUMbHr4Vl8gRTANUE=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aeVdPcO9WnfDTfpnR1o7pSL8RAyVlD+96w9QBgIT7kDGoGEYf/Ni3Wamhn7xi54T/qSxH77dmR6PEfQo5rtHFxAc12Va8Xhb2gSJeo8EbhdQihXVLvGPEJAH0p4DuZdXBdGrKo8DnZuJgVEykcBg2a8GugrMtHgVG0ADGTFisv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv5L32qKpz67ZDL; Wed, 28 Aug 2024 21:46:35 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id AC1641400D4; Wed, 28 Aug 2024 21:49:51 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 14:49:51 +0100 Date: Wed, 28 Aug 2024 14:49:50 +0100 From: Jonathan Cameron To: Alexey Kardashevskiy CC: , , , , "Suravee Suthikulpanit" , Alex Williamson , Dan Williams , , , , , Santosh Shukla , Tom Lendacky , "Michael Roth" , Alexander Graf , "Nikunj A Dadhania" , Vasant Hegde , "Lukas Wunner" Subject: Re: [RFC PATCH 01/21] tsm-report: Rename module to reflect what it does Message-ID: <20240828144950.000004b7@Huawei.com> In-Reply-To: <20240823132137.336874-2-aik@amd.com> References: <20240823132137.336874-1-aik@amd.com> <20240823132137.336874-2-aik@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) On Fri, 23 Aug 2024 23:21:15 +1000 Alexey Kardashevskiy wrote: > And release the name for TSM to be used for TDISP-associated code. > Mention that it's not a simple file rename. Some structure renames etc as well. Maybe consider renaming the bits of the exported API as well? > Suggested-by: Dan Williams > Signed-off-by: Alexey Kardashevskiy > --- > drivers/virt/coco/Makefile | 2 +- > include/linux/{tsm.h => tsm-report.h} | 15 ++++++++------- > drivers/virt/coco/sev-guest/sev-guest.c | 10 +++++----- > drivers/virt/coco/tdx-guest/tdx-guest.c | 8 ++++---- > drivers/virt/coco/{tsm.c => tsm-report.c} | 12 ++++++------ > MAINTAINERS | 4 ++-- > 6 files changed, 26 insertions(+), 25 deletions(-) > > diff --git a/drivers/virt/coco/Makefile b/drivers/virt/coco/Makefile > index 18c1aba5edb7..75defec514f8 100644 > --- a/drivers/virt/coco/Makefile > +++ b/drivers/virt/coco/Makefile > @@ -2,7 +2,7 @@ > # > # Confidential computing related collateral > # > -obj-$(CONFIG_TSM_REPORTS) += tsm.o > +obj-$(CONFIG_TSM_REPORTS) += tsm-report.o > obj-$(CONFIG_EFI_SECRET) += efi_secret/ > obj-$(CONFIG_SEV_GUEST) += sev-guest/ > obj-$(CONFIG_INTEL_TDX_GUEST) += tdx-guest/ > diff --git a/include/linux/tsm.h b/include/linux/tsm-report.h > similarity index 92% > rename from include/linux/tsm.h > rename to include/linux/tsm-report.h > index 11b0c525be30..4d815358790b 100644 > --- a/include/linux/tsm.h > +++ b/include/linux/tsm-report.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#ifndef __TSM_H > -#define __TSM_H > +#ifndef __TSM_REPORT_H > +#define __TSM_REPORT_H > > #include > #include > @@ -88,7 +88,7 @@ enum tsm_bin_attr_index { > }; > > /** > - * struct tsm_ops - attributes and operations for tsm instances > + * struct tsm_report_ops - attributes and operations for tsm instances > * @name: tsm id reflected in /sys/kernel/config/tsm/report/$report/provider > * @privlevel_floor: convey base privlevel for nested scenarios > * @report_new: Populate @report with the report blob and auxblob > @@ -99,7 +99,7 @@ enum tsm_bin_attr_index { > * Implementation specific ops, only one is expected to be registered at > * a time i.e. only one of "sev-guest", "tdx-guest", etc. > */ > -struct tsm_ops { > +struct tsm_report_ops { > const char *name; > unsigned int privlevel_floor; > int (*report_new)(struct tsm_report *report, void *data); > @@ -107,6 +107,7 @@ struct tsm_ops { > bool (*report_bin_attr_visible)(int n); > }; > > -int tsm_register(const struct tsm_ops *ops, void *priv); > -int tsm_unregister(const struct tsm_ops *ops); > -#endif /* __TSM_H */ > +int tsm_register(const struct tsm_report_ops *ops, void *priv); > +int tsm_unregister(const struct tsm_report_ops *ops); Perhaps makes sense to make thiese tsm_report_register() etc. > +#endif /* __TSM_REPORT_H */ > +