From: Yan Zhao <yan.y.zhao@intel.com>
To: ebiederm@xmission.com
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-coco@lists.linux.dev, x86@kernel.org,
rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
Yan Zhao <yan.y.zhao@intel.com>
Subject: [PATCH] kexec_core: Accept unaccepted kexec destination addresses
Date: Mon, 21 Oct 2024 11:45:53 +0800 [thread overview]
Message-ID: <20241021034553.18824-1-yan.y.zhao@intel.com> (raw)
The kexec destination addresses (incluing those for purgatory, the new
kernel, boot params/cmdline, and initrd) are searched from the free area of
memblock or RAM resources. Since they are not allocated by the currently
running kernel, it is not guaranteed that they are accepted before
relocating the new kernel.
Accept the destination addresses for the new kernel, as the new kernel may
not be able to or may not accept them by itself.
Place the "accept" code immediately after the destination addresses pass
sanity checks, so the code can be shared by both users of the kexec_load
and kexec_file_load system calls.
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
---
kernel/kexec_core.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index c0caa14880c3..d97376eafc1a 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -210,6 +210,16 @@ int sanity_check_segment_list(struct kimage *image)
}
#endif
+ /*
+ * The destination addresses are searched from free memory ranges rather
+ * than being allocated from the current kernel, so they are not
+ * guaranteed to be accepted by the current kernel.
+ * Accept those initial pages for the new kernel since it may not be
+ * able to accept them by itself.
+ */
+ for (i = 0; i < nr_segments; i++)
+ accept_memory(image->segment[i].mem, image->segment[i].memsz);
+
return 0;
}
base-commit: 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b
--
2.43.2
next reply other threads:[~2024-10-21 3:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 3:45 Yan Zhao [this message]
2024-10-21 14:33 ` [PATCH] kexec_core: Accept unaccepted kexec destination addresses Eric W. Biederman
2024-10-22 3:12 ` Yan Zhao
2024-10-22 12:06 ` Kirill A. Shutemov
2024-10-23 15:44 ` Eric W. Biederman
2024-10-24 0:15 ` Yan Zhao
2024-10-24 0:26 ` Yan Zhao
2024-11-26 11:38 ` Baoquan He
2024-11-27 10:01 ` Yan Zhao
2024-11-28 15:19 ` Baoquan He
2024-11-29 5:52 ` Yan Zhao
2024-12-02 14:17 ` Baoquan He
2024-12-03 10:06 ` Yan Zhao
2024-12-03 10:30 ` Baoquan He
2024-12-04 9:19 ` Yan Zhao
2024-10-25 13:56 ` Kirill A. Shutemov
2024-11-04 8:35 ` Kirill A. Shutemov
2024-11-08 12:29 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021034553.18824-1-yan.y.zhao@intel.com \
--to=yan.y.zhao@intel.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox