From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB251F4612 for ; Thu, 24 Apr 2025 20:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745525578; cv=none; b=tMHkq2DlW6qoKGIBMM3p0NoGh2PaMZO2tkGW6pz3Lo7a89tM3DeOGAhIyZqLmidYBYaaaTU+8JzM0Mt4Bau1rlbk08x9Psqsiz4BepujMoavN1AfYQPdFro+eO8hgYZAjNAkTsugtY2BskaUR5r8RVVqcwJYamyvH4so7O+M8Tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745525578; c=relaxed/simple; bh=2pOJat/7RknLpDlgvWY07xMjRZe0qw8mNUALBgrJfk4=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=nQe+v+4aLQdjtPQUE0wjKJ8KUYo94meN4N6MmkEhTwrqGiHBBPvyGPD7WA5wNcVz/621CD3lRzWyxFB7zVhEigU7hI6vYkxsaY1/cYnz/jjb/eEop8fvK/bB8p/GAFNMm3vqUJf0su5L1Cx+lmGfY0IO7nUjAifvYYD3g2LaAEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WzR3lBT1; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WzR3lBT1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745525574; x=1777061574; h=from:subject:date:message-id:mime-version: content-transfer-encoding:to:cc; bh=2pOJat/7RknLpDlgvWY07xMjRZe0qw8mNUALBgrJfk4=; b=WzR3lBT1sIf0MdLc+XBy7ntnk75SID6Owda/TGSWe42B0bkEdNu5JXeQ m3Cq1QUUnLwUxJEr47O97HBtpg5LnDPTSYilwIFHhNBpjEeDWNj7X27Nv eNbVLf0aqst8GrlGx3k/UlGgMU/bvBef93PuUr/k9Ccjp0JlMrB9NchXe 6rSqND4maxMiP1jyxn/YUG+ZD/a9XS9vtY8gqxll9UTQ4x1Ps5ExNceUG 6ed3lUX5S9x/Rmwmsn4Rh4WYorhPaGsR6K2OtsLRr1D2XIaEhz/j+fiE/ CIpBaO32ph+9TxV+Zdk+RHE/ttBqolptK1T/TswAZ53Gr+oNZZfdA2N8z A==; X-CSE-ConnectionGUID: TxwL7TZXTKaWhE7Nw4MwRg== X-CSE-MsgGUID: Wv6pYuI8QZ2KqCJZiX6aqg== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="50986681" X-IronPort-AV: E=Sophos;i="6.15,237,1739865600"; d="scan'208";a="50986681" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 13:12:53 -0700 X-CSE-ConnectionGUID: y3abzMYbTqmsDcJ8WzxESA== X-CSE-MsgGUID: hEgU1/aAQSeVseQ4Oy9dQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,237,1739865600"; d="scan'208";a="155945358" Received: from ajatsiv-mobl.amr.corp.intel.com (HELO bxing-mobl1.clients.intel.com) ([10.246.112.111]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 13:12:54 -0700 From: Cedric Xing Subject: [PATCH v5 0/5] tsm-mr: Unified Measurement Register ABI for TVMs Date: Thu, 24 Apr 2025 15:12:24 -0500 Message-Id: <20250424-tdx-rtmr-v5-0-4fe28ddf85d4@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACibCmgC/13MQQ6CMBCF4auYrq1ph5mWuvIexgXQVpoomEKIx nB3CzGhYfkm8/1fNrgY3MDOhy+LbgpD6Ls06HhgTVt1d8eDTZuBABIgDB/tm8fxGTkQoTZKaYm KpfdXdD6819T1lnYbhrGPn7U8yeX6j0jYIpPkghttyDZonCzgErrRPU5N/2RLZIIMQpFBSNCDL akWFXmDe1hsEIXOYJEgoZe6bhQBlHuIGZSYQUxQO+ur0ppSS5XDeZ5/fAPrt0sBAAA= To: Dan Williams , "Kirill A. Shutemov" , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Dionna Amalie Glaze , Guorui Yu , James Bottomley , Dan Middleton , Mikko Ylinen , Sathyanarayanan Kuppuswamy , Cedric Xing X-Mailer: b4 0.13.0 NOTE: This patch series introduces the Measurement Register (MR) ABI, and is a continuation of the RFC series on the same topic [1]. Introduce the CONFIG_TSM_MEASUREMENTS helper library (tsm-mr) as a cross-vendor transport schema to allow TVM (TEE VM) guest drivers to export CC (Confidential Compute) architecture-specific MRs (Measurement Registers) as sysfs attributes/files. Enable applications to read, write/extend MRs like regular files, supporting various usages such as configuration verification (e.g., verify a TVM's configuration against digests stored in static/immutable MRs like MRCONFIGID on TDX or HOSTDATA on SEV) and runtime measurements (e.g., extend the measurement of a container image to an RTMR before running it). Patches included in this series: - Patch 1 adds the tsm-mr library to help TVM guest drivers exposing MRs as sysfs attributes. - Patch 2 provides a sample module demonstrating the usage of the new tsm-mr library. - The remaining patches update the TDX guest driver to expose TDX MRs with the help of the tsm-mr library. [1]: https://lore.kernel.org/linux-coco/20241210-tsm-rtmr-v3-0-5997d4dbda73@intel.com/ Signed-off-by: Cedric Xing --- Changes in v5: - tsm-mr: Fix typo in MAINTAINERS. - tsm-mr-sample: Fix Kconfig dependencies by adding `select VIRT_DRIVERS`. - Link to v4: https://lore.kernel.org/r/20250414-tdx-rtmr-v4-0-7edfa8d98716@intel.com Changes in v4: - tsm-mr: Add details to ABI doc. - tsm-mr: Add driver-api doc. - tsm-mr: Add tracepoints. - tsm-mr: Use the constant string "mr" as the group/directory name for MR sysfs attributes. - x86/tdx: Revise error codes returned by tdx_mcall_* functions. - tdx-guest: Merge all TDREPORT code paths into a common function. - Link to v3: https://lore.kernel.org/r/20250407-tdx-rtmr-v3-0-54f17bc65228@intel.com Changes in v3: - tsm-mr: Separate measurement support (tsm-mr) from the original tsm source code. Modules depending on tsm-mr should `select TSM_MEASUREMENTS` in Kconfig. (Dan Williams) - tsm-mr: Revise tsm-mr APIs to allow callers to decide where to host the MR attributes in sysfs. - tsm-mr: Drop TSM_MR_F_EXTENSIBLE and route all "write" requests to the CC guest driver, which decides how to handle writes (e.g., by extending the buffer on input to the specified MR). - tsm-mr: Update the naming pattern for MR attributes from MRNAME/HASH/digest to MRNAME:HASH. - tsm-mr: Drop TSM_MR_MAXBANKS kernel config. - x86/tdx: Return -EBUSY from tdx_mcall_get_report0 on TDCALL_OPERAND_BUSY error. - tdx-guest: Move MR attributes from /sys/kernel/tsm/tdx/ to /sys/class/misc/tdx_guest/ because MR names are architecture-specific, so their attributes should reside in an architecture-specific location. - tdx-guest: Remove hash from `mrconfigid`, `mrowner`, `mrownerconfig`. - tdx-guest: Remove `servtd_hash`, `report0`, and `reportdata`. - Link to v2: https://lore.kernel.org/r/20250223-tdx-rtmr-v2-0-f2d85b0a5f94@intel.com Changes in v2: - Added TSM_MR_MAXBANKS Kconfig option - Updated Kconfig dependency for TSM_REPORTS - Updated comments in include/linux/tsm.h - Updated drivers/virt/coco/tdx-guest/tdx-guest.c to use `IS_BUILTIN()` for determining if static buffer addresses can be converted to GPAs by `virt_to_phys()` - Renamed function `tdx_mcall_rtmr_extend()` -> `tdx_mcall_extend_rtmr()` - Link to v1: https://lore.kernel.org/r/20250212-tdx-rtmr-v1-0-9795dc49e132@intel.com --- Cedric Xing (5): tsm-mr: Add TVM Measurement Register support tsm-mr: Add tsm-mr sample code x86/tdx: Add tdx_mcall_extend_rtmr() interface x86/tdx: tdx_mcall_get_report0: Return -EBUSY on TDCALL_OPERAND_BUSY error virt: tdx-guest: Expose TDX MRs as sysfs attributes .../testing/sysfs-devices-virtual-misc-tdx_guest | 60 +++++ Documentation/driver-api/coco/index.rst | 12 + .../driver-api/coco/measurement-registers.rst | 12 + Documentation/driver-api/index.rst | 1 + MAINTAINERS | 6 +- arch/x86/coco/tdx/tdx.c | 50 +++- arch/x86/include/asm/shared/tdx.h | 1 + arch/x86/include/asm/tdx.h | 2 + drivers/virt/coco/Kconfig | 5 + drivers/virt/coco/Makefile | 1 + drivers/virt/coco/tdx-guest/Kconfig | 1 + drivers/virt/coco/tdx-guest/tdx-guest.c | 291 +++++++++++++-------- drivers/virt/coco/tsm-mr.c | 247 +++++++++++++++++ include/linux/tsm-mr.h | 94 +++++++ include/trace/events/tsm_mr.h | 80 ++++++ samples/Kconfig | 11 + samples/Makefile | 1 + samples/tsm-mr/Makefile | 2 + samples/tsm-mr/tsm_mr_sample.c | 137 ++++++++++ 19 files changed, 904 insertions(+), 110 deletions(-) --- base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b change-id: 20250209-tdx-rtmr-255479667146 Best regards, -- Cedric Xing