From: Eric Biggers <ebiggers@kernel.org>
To: Zhenghan Cheng <chengzhenghan@uniontech.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org,
mario.limonciello@amd.com, yazen.ghannam@amd.com,
jpoimboe@kernel.org, tony.luck@intel.com, jarkko@kernel.org,
bhelgaas@google.com, pbonzini@redhat.com, oleg@redhat.com,
jbaron@akamai.com, ning.sun@intel.com, seanjc@google.com,
luto@kernel.org, andy@kernel.org, jim.cromie@gmail.com,
kirill.shutemov@linux.intel.com, hpa@zytor.com,
pawan.kumar.gupta@linux.intel.com, vkuznets@redhat.com,
rostedt@goodmis.org, ardb@kernel.org, thomas.lendacky@amd.com,
nikunj@amd.com, ashish.kalra@amd.com, kees@kernel.org,
alexandre.chartre@oracle.com, rppt@kernel.org,
steve.wahl@hpe.com, jirislaby@kernel.org,
apatel@ventanamicro.com, bvanassche@acm.org,
ptsm@linux.microsoft.com, Jonathan.Cameron@huawei.com,
beata.michalska@arm.com, xin@zytor.com,
davydov-max@yandex-team.ru, ravi.bangoria@amd.com,
joel.granados@kernel.org, ffmancera@riseup.net,
kprateek.nayak@amd.com, akpm@linux-foundation.org,
bhe@redhat.com, brgerst@gmail.com, coxu@redhat.com,
dmaluka@chromium.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-sgx@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
tboot-devel@lists.sourceforge.net, nouveau@lists.freedesktop.org,
linux-coco@lists.linux.dev, xen-devel@lists.xenproject.org,
Huacai Chen <chenhuacai@loongson.cn>,
Zhenghan Cheng <your_email@example.com>
Subject: Re: [PATCH] x86: Fix build warnings about export.h
Date: Thu, 12 Jun 2025 12:03:47 -0700 [thread overview]
Message-ID: <20250612190347.GB1283@sol> (raw)
In-Reply-To: <20250612093228.7655-1-chengzhenghan@uniontech.com>
On Thu, Jun 12, 2025 at 05:32:28PM +0800, Zhenghan Cheng wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check:
> check missing #include <linux/export.h> when W=1")
> and commit 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"),
> we get some build warnings with W=1,such as:
>
> arch/x86/coco/sev/core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/x86/crypto/aria_aesni_avx2_glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/x86/kernel/unwind_orc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/x86/kvm/hyperv.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/x86/events/intel/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> arch/x86/events/zhaoxin/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> arch/x86/kernel/crash.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> arch/x86/kernel/devicetree.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
>
> so fix these build warnings for x86.
>
> Signed-off-by: "Zhenghan Cheng" <chengzhenghan@uniontech.com>
> Suggested-by: "Huacai Chen" <chenhuacai@loongson.cn>
FYI, I'm planning to handle arch/x86/lib/crc*.c and arch/x86/lib/crypto/.
(Specifically, I'm migrating them to lib/crc/ and lib/crypto/ respectively, and
one of the effects of that is the EXPORT_SYMBOL in arch-specific crc and crypto
library files go away. The lib/crc/ change is already in linux-next, and
https://lore.kernel.org/r/20250612183852.114878-1-ebiggers@kernel.org adds
<linux/export.h> to all files with EXPORT_SYMBOL in lib/crc/.)
- Eric
prev parent reply other threads:[~2025-06-12 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 9:32 [PATCH] x86: Fix build warnings about export.h Zhenghan Cheng
2025-06-12 10:19 ` Juergen Gross
2025-06-12 11:10 ` Andy Shevchenko
2025-06-12 19:03 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612190347.GB1283@sol \
--to=ebiggers@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.chartre@oracle.com \
--cc=andy@kernel.org \
--cc=apatel@ventanamicro.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=beata.michalska@arm.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=bvanassche@acm.org \
--cc=chengzhenghan@uniontech.com \
--cc=chenhuacai@loongson.cn \
--cc=coxu@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=davydov-max@yandex-team.ru \
--cc=dmaluka@chromium.org \
--cc=ffmancera@riseup.net \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=jirislaby@kernel.org \
--cc=joel.granados@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=ning.sun@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=oleg@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=ptsm@linux.microsoft.com \
--cc=ravi.bangoria@amd.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=steve.wahl@hpe.com \
--cc=tboot-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=virtualization@lists.linux.dev \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xin@zytor.com \
--cc=yazen.ghannam@amd.com \
--cc=your_email@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox