From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 181E828CF6A for ; Tue, 29 Jul 2025 11:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753788503; cv=none; b=r9lLmagwLVhmOPOsNQaDpUZBadWl5YlMLKfPRGl7+9JeK9X0UK4Z0JUa6hBhZaTqclmoT7Srame78fbLu5235A0j8gmWwwYgf2CIivrol4PXZsn5eID8h2R7oWBpvBQqEfLbkbYfo3+SNloALha2KYV4AohePG6I1SGYsTjZAss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753788503; c=relaxed/simple; bh=95KnHoEI2OnNA8bds9YbjE3P0QGj3btAA1vLBgfUonA=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qEJsQmhfg7uRi48CAk7HZfJWQWmx+CHQw9IfKlqEXSRmPhr6tL/DyrF+6Sflaw3dTuTC2PsK+b1EnbWqFhzdeIMvVH9jBcnV4y1pM+Lpvbm4/lCq/seLCA89v2nQm0+aq8BRZB/V4/We3ITH3uzP4nH5l0EDSInM/EJJdgu8lSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4brtMw6Bc1z6M4PM; Tue, 29 Jul 2025 19:26:36 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 36FF114038F; Tue, 29 Jul 2025 19:28:11 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 29 Jul 2025 13:28:05 +0200 Date: Tue, 29 Jul 2025 12:28:02 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , , , , Xiaoyao Li , Isaku Yamahata , Yilun Xu , Tom Lendacky , John Allen , "Aneesh Kumar K.V (Arm)" Subject: Re: [PATCH v4 01/10] coco/tsm: Introduce a core device for TEE Security Managers Message-ID: <20250729122802.00004aac@huawei.com> In-Reply-To: <20250717183358.1332417-2-dan.j.williams@intel.com> References: <20250717183358.1332417-1-dan.j.williams@intel.com> <20250717183358.1332417-2-dan.j.williams@intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 17 Jul 2025 11:33:49 -0700 Dan Williams wrote: > A "TSM" is a platform component that provides an API for securely > provisioning resources for a confidential guest (TVM) to consume. The > name originates from the PCI specification for platform agent that > carries out operations for PCIe TDISP (TEE Device Interface Security > Protocol). > > Instances of this core device are parented by a device representing the > platform security function like CONFIG_CRYPTO_DEV_CCP or > CONFIG_INTEL_TDX_HOST. > > This device interface is a frontend to the aspects of a TSM and TEE I/O > that are cross-architecture common. This includes mechanisms like > enumerating available platform TEE I/O capabilities and provisioning > connections between the platform TSM and device DSMs (Device Security > Manager (TDISP)). > > For now this is just the scaffolding for registering a TSM device sysfs > interface. > > Cc: Xiaoyao Li > Cc: Isaku Yamahata > Cc: Alexey Kardashevskiy > Cc: Yilun Xu > Cc: Tom Lendacky > Cc: John Allen > Co-developed-by: Aneesh Kumar K.V (Arm) > Signed-off-by: Aneesh Kumar K.V (Arm) > Signed-off-by: Dan Williams Nice. One trivial comment inline. Reviewed-by: Jonathan Cameron > diff --git a/drivers/virt/coco/Makefile b/drivers/virt/coco/Makefile > index f918bbb61737..c0c3733be165 100644 > --- a/drivers/virt/coco/Makefile > +++ b/drivers/virt/coco/Makefile > @@ -2,9 +2,11 @@ > # > # Confidential computing related collateral > # > + Unrelated change. > obj-$(CONFIG_EFI_SECRET) += efi_secret/ > obj-$(CONFIG_ARM_PKVM_GUEST) += pkvm-guest/ > obj-$(CONFIG_SEV_GUEST) += sev-guest/ > obj-$(CONFIG_INTEL_TDX_GUEST) += tdx-guest/ > obj-$(CONFIG_ARM_CCA_GUEST) += arm-cca-guest/ > +obj-$(CONFIG_TSM) += tsm-core.o > obj-$(CONFIG_TSM_GUEST) += guest/