From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A0E2E54CC for ; Thu, 11 Sep 2025 23:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757635018; cv=none; b=A8n7pYyWaGPPxUFFH6cCruNdXI0rfek9ni5OzNXJd5dbSWlOjOPcEh17PD6QoB2EnLLRbnGahloAIlIIRC5rjN11TjxcEKfYAys5hTp1V2tN5YK2k6h0eT1T0KU3IweObyTkGP1Zg4nxyK3he2TUEyiJrLxlC1HNw+e36xK6aYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757635018; c=relaxed/simple; bh=HKqs1z3XyJ6hB9LZSzoym856kfboNUzxev19eYNllrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yjvu6KhnNgiy8z5mCVdRfqch/TP9roL7i03l/OjrnsKJirwESGc3XQbwvdZpuce/gapbI1C2rpegmtPbf/RvchrXrKc8m6IXJrh2CPnLbDg+ytBqwPsjsoliKD4D+Lea8vvXUfgj39aNuKo020H1kXsHxU+rG3Bkt7WJ2LPQ9d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jQK502yL; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jQK502yL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757635016; x=1789171016; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HKqs1z3XyJ6hB9LZSzoym856kfboNUzxev19eYNllrk=; b=jQK502yLxAmmyNEEMmMZPeGuCtCO9gXZ37Kk67Rkt8Xy9h77vwd75C9A F4BXU0esLtAi0tS/0ZAslR5y8I01qB9x3BWqtqy0KI3YDKrTU7/d5+QWr 1IH0ur+cMMo1VWLIh3oREJo88fmDONLa984ba/lUwTR8pQkoPoeolFLot 9ucLnePCxeCbpgQ4WCnUv0XGpLMs8usmY9U+GizbvJppM2AyqJSLSO49S 79VllA98S3Xs27bPwizMX8qaHPEM3I+dedKnjk9n72VcUhzDoFkp8IUrN yd9JeAFVib4RbNKXds79ujVwmVEXEjqKuBJW9PYXf+FXF2rlEaNz/3iGu g==; X-CSE-ConnectionGUID: 66vkTumeR4myopsVPOR+yw== X-CSE-MsgGUID: JLOb7wDrRreuufdPHRY2SQ== X-IronPort-AV: E=McAfee;i="6800,10657,11550"; a="70598765" X-IronPort-AV: E=Sophos;i="6.18,258,1751266800"; d="scan'208";a="70598765" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2025 16:56:52 -0700 X-CSE-ConnectionGUID: wFrSydUnSFOYN8VkVbumMg== X-CSE-MsgGUID: XZroizV8SEe6uS45+QMQXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,258,1751266800"; d="scan'208";a="173393546" Received: from dwillia2-desk.jf.intel.com ([10.88.27.145]) by fmviesa007.fm.intel.com with ESMTP; 11 Sep 2025 16:56:51 -0700 From: Dan Williams To: linux-pci@vger.kernel.org, linux-coco@lists.linux.dev Cc: gregkh@linuxfoundation.org, bhelgaas@google.com, lukas@wunner.de, Jonathan Cameron Subject: [PATCH resend v6 09/10] PCI/TSM: Report active IDE streams Date: Thu, 11 Sep 2025 16:56:46 -0700 Message-ID: <20250911235647.3248419-10-dan.j.williams@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250911235647.3248419-1-dan.j.williams@intel.com> References: <20250911235647.3248419-1-dan.j.williams@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Given that the platform TSM owns IDE Stream ID allocation, report the active streams via the TSM class device. Establish a symlink from the class device to the PCI endpoint device consuming the stream, named by the Stream ID. Acked-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Signed-off-by: Dan Williams --- Documentation/ABI/testing/sysfs-class-tsm | 10 ++++++++ drivers/pci/ide.c | 6 ++++- drivers/pci/pci.h | 2 +- drivers/virt/coco/tsm-core.c | 29 +++++++++++++++++++++++ include/linux/pci-ide.h | 2 ++ include/linux/tsm.h | 3 +++ 6 files changed, 50 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-class-tsm b/Documentation/ABI/testing/sysfs-class-tsm index 2949468deaf7..6fc1a5ac6da1 100644 --- a/Documentation/ABI/testing/sysfs-class-tsm +++ b/Documentation/ABI/testing/sysfs-class-tsm @@ -7,3 +7,13 @@ Description: signals when the PCI layer is able to support establishment of link encryption and other device-security features coordinated through a platform tsm. + +What: /sys/class/tsm/tsmN/streamH.R.E +Contact: linux-pci@vger.kernel.org +Description: + (RO) When a host bridge has established a secure connection via + the platform TSM, symlink appears. The primary function of this + is have a system global review of TSM resource consumption + across host bridges. The link points to the endpoint PCI device + and matches the same link published by the host bridge. See + Documentation/ABI/testing/sysfs-devices-pci-host-bridge. diff --git a/drivers/pci/ide.c b/drivers/pci/ide.c index eb6e146e6fb5..851633b240e3 100644 --- a/drivers/pci/ide.c +++ b/drivers/pci/ide.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "pci.h" @@ -272,6 +273,9 @@ void pci_ide_stream_release(struct pci_ide *ide) if (ide->partner[PCI_IDE_EP].enable) pci_ide_stream_disable(pdev, ide); + if (ide->tsm_dev) + tsm_ide_stream_unregister(ide); + if (ide->partner[PCI_IDE_RP].setup) pci_ide_stream_teardown(rp, ide); @@ -553,7 +557,7 @@ static umode_t pci_ide_attr_visible(struct kobject *kobj, struct attribute *a, i return a->mode; } -struct attribute_group pci_ide_attr_group = { +const struct attribute_group pci_ide_attr_group = { .attrs = pci_ide_attrs, .is_visible = pci_ide_attr_visible, }; diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 22e0256a10ba..716eb7fecb16 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -521,7 +521,7 @@ static inline void pci_doe_sysfs_teardown(struct pci_dev *pdev) { } #ifdef CONFIG_PCI_IDE void pci_ide_init(struct pci_dev *dev); -extern struct attribute_group pci_ide_attr_group; +extern const struct attribute_group pci_ide_attr_group; #define PCI_IDE_ATTR_GROUP (&pci_ide_attr_group) #else static inline void pci_ide_init(struct pci_dev *dev) { } diff --git a/drivers/virt/coco/tsm-core.c b/drivers/virt/coco/tsm-core.c index f0bb580563c9..d223cb6fa972 100644 --- a/drivers/virt/coco/tsm-core.c +++ b/drivers/virt/coco/tsm-core.c @@ -2,14 +2,17 @@ /* Copyright(c) 2024 Intel Corporation. All rights reserved. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#define dev_fmt(fmt) KBUILD_MODNAME ": " fmt #include #include +#include #include #include #include #include #include +#include static struct class *tsm_class; static DECLARE_RWSEM(tsm_rwsem); @@ -107,6 +110,32 @@ void tsm_unregister(struct tsm_dev *tsm_dev) } EXPORT_SYMBOL_GPL(tsm_unregister); +/* must be invoked between tsm_register / tsm_unregister */ +int tsm_ide_stream_register(struct pci_ide *ide) +{ + struct pci_dev *pdev = ide->pdev; + struct pci_tsm *tsm = pdev->tsm; + struct tsm_dev *tsm_dev = tsm->ops->owner; + int rc; + + rc = sysfs_create_link(&tsm_dev->dev.kobj, &pdev->dev.kobj, ide->name); + if (rc) + return rc; + + ide->tsm_dev = tsm_dev; + return 0; +} +EXPORT_SYMBOL_GPL(tsm_ide_stream_register); + +void tsm_ide_stream_unregister(struct pci_ide *ide) +{ + struct tsm_dev *tsm_dev = ide->tsm_dev; + + sysfs_remove_link(&tsm_dev->dev.kobj, ide->name); + ide->tsm_dev = NULL; +} +EXPORT_SYMBOL_GPL(tsm_ide_stream_unregister); + static void tsm_release(struct device *dev) { struct tsm_dev *tsm_dev = container_of(dev, typeof(*tsm_dev), dev); diff --git a/include/linux/pci-ide.h b/include/linux/pci-ide.h index 5a7ffb1d826f..a30f9460b04a 100644 --- a/include/linux/pci-ide.h +++ b/include/linux/pci-ide.h @@ -46,6 +46,7 @@ struct pci_ide_partner { * @host_bridge_stream: track platform Stream ID * @stream_id: unique Stream ID (within Partner Port pairing) * @name: name of the established Selective IDE Stream in sysfs + * @tsm_dev: For TSM established IDE, the TSM device context * * Negative @stream_id values indicate "uninitialized" on the * expectation that with TSM established IDE the TSM owns the stream_id @@ -57,6 +58,7 @@ struct pci_ide { u8 host_bridge_stream; int stream_id; const char *name; + struct tsm_dev *tsm_dev; }; struct pci_ide_partner *pci_ide_to_settings(struct pci_dev *pdev, struct pci_ide *ide); diff --git a/include/linux/tsm.h b/include/linux/tsm.h index ee9a54ae3d3c..376139585797 100644 --- a/include/linux/tsm.h +++ b/include/linux/tsm.h @@ -120,4 +120,7 @@ int tsm_report_unregister(const struct tsm_report_ops *ops); struct tsm_dev *tsm_register(struct device *parent, struct pci_tsm_ops *ops); void tsm_unregister(struct tsm_dev *tsm_dev); struct tsm_dev *find_tsm_dev(int id); +struct pci_ide; +int tsm_ide_stream_register(struct pci_ide *ide); +void tsm_ide_stream_unregister(struct pci_ide *ide); #endif /* __TSM_H */ -- 2.51.0