From: Peter Zijlstra <peterz@infradead.org>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: "Huang, Kai" <kai.huang@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/tdx: Make seamcall/tdcall CET-compliant
Date: Wed, 22 Oct 2025 13:19:14 +0200 [thread overview]
Message-ID: <20251022111914.GM4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <9d93a6a5-a431-4548-ac1c-0e1e5a214dc3@suse.com>
On Wed, Oct 22, 2025 at 02:10:45PM +0300, Nikolay Borisov wrote:
>
>
> On 10/22/25 13:51, Peter Zijlstra wrote:
> > On Wed, Oct 22, 2025 at 01:48:11PM +0300, Nikolay Borisov wrote:
> > > > The compiler is clever enough to see that is a direct call of foo.
> > >
> > > Thanks, I verified this, turns out we are using an earlier version of
> > > 10df8607bf1a ("x86/virt/tdx: Mark memory cache state incoherent when making
> > > SEAMCALL")
> >
> > 0b3bc018e86a ("x86/virt/tdx: Avoid indirect calls to TDX assembly functions")
>
> We have that, but as it turns out it's not sufficient, we need
> __seamcall_dirty_cache to also be __always_inline as it also has an indirect
> call in it.
Right, so that commit does the __always_inline and explains why, and
then the other commit just copies the __always_inline.
prev parent reply other threads:[~2025-10-22 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:36 [PATCH] x86/tdx: Make seamcall/tdcall CET-compliant Nikolay Borisov
2025-10-22 10:14 ` Huang, Kai
2025-10-22 10:21 ` Nikolay Borisov
2025-10-22 10:30 ` Peter Zijlstra
2025-10-22 10:48 ` Nikolay Borisov
2025-10-22 10:51 ` Peter Zijlstra
2025-10-22 11:10 ` Nikolay Borisov
2025-10-22 11:19 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022111914.GM4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dave.hansen@linux.intel.com \
--cc=kai.huang@intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=nik.borisov@suse.com \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox