From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1C01CAA85 for ; Thu, 30 Oct 2025 11:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761822960; cv=none; b=gc7zYL8i52ta8f0VdOjpTfG+fqMyyVBHQBKQGggqD8+jg4kmprx5T+Bnb+irQcTMsskyjqvpcF1X3jt+VV2/C593yDFU9dH6lcOsqWagGiYazZSGZ5zfWZ/kR9TX4RUL1Oq+w12DK4UNIN2zn3l/To9vJWGG48wPQKsK/pmT6i4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761822960; c=relaxed/simple; bh=DR15C7NxbfAWRyga0iph0sdKhc8xcN9dnBFkhMMKUSA=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=umQ/EclTpku4J3iflD+Rq3AuhuicGXMMxmQ7czfdcKt1kPVopKj7quR+KCKl/vRBrJHWuvYiHfQHqzbQvZTIBN4+bI+fDMxzAYSuvgh9dnr42lsxsjX58sEWsMwhIF2Rn5RlLtjwCY+yEZnHnMKMzX0GO6WQGLuTiz21Kr6CsSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cy1hb60L1z67cQ8; Thu, 30 Oct 2025 19:14:07 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 087BF14038F; Thu, 30 Oct 2025 19:15:57 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 30 Oct 2025 11:15:56 +0000 Date: Thu, 30 Oct 2025 11:15:55 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , , Zhenzhong Duan , Xu Yilun Subject: Re: [RFC PATCH 19/27] coco/tdx-host: Add a helper to exchange SPDM messages through DOE Message-ID: <20251030111555.00000d8f@huawei.com> In-Reply-To: <20250919142237.418648-20-dan.j.williams@intel.com> References: <20250919142237.418648-1-dan.j.williams@intel.com> <20250919142237.418648-20-dan.j.williams@intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To dubpeml100005.china.huawei.com (7.214.146.113) On Fri, 19 Sep 2025 07:22:28 -0700 Dan Williams wrote: > From: Zhenzhong Duan > > TDX host uses this function to exchange TDX Module encrypted data with > devices via SPDM. It is unfortunate that TDX passes raw DOE frames with > headers included and the PCI DOE core wants payloads separated from > headers. > > This conversion code is about the same amount of work as teaching the PCI > DOE driver to support raw frames. Unless and until another raw frame use > case shows up, just do this conversion in the TDX TSM driver. > > Signed-off-by: Zhenzhong Duan > Co-developed-by: Xu Yilun > Signed-off-by: Xu Yilun > Signed-off-by: Dan Williams LGTM and finally a bit I know enough about for a tag to make sense :) Reviewed-by: Jonathan Cameron