From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Kirill A. Shutemov" <kas@kernel.org>
Cc: kvm@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, Yan Zhao <yan.y.zhao@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Hou Wenlong <houwenlong.hwl@antgroup.com>
Subject: [PATCH v5 0/4] KVM: x86: User-return MSR fix+cleanups
Date: Thu, 30 Oct 2025 12:15:24 -0700 [thread overview]
Message-ID: <20251030191528.3380553-1-seanjc@google.com> (raw)
Fix a bug in TDX where KVM will incorrectly update the current user-return
MSR values when the TDX-Module doesn't actually clobber the relevant MSRs,
and then cleanup and harden the user-return MSR code, e.g. against forced
reboots.
v5:
- Set TDX MSRs to their expected post-run value during
tdx_prepare_switch_to_guest() instead of trying to predict what value
is in hardware after the SEAMCALL. [Yan]
- Free user_return_msrs at kvm_x86_vendor_exit(), not kvm_x86_exit(). [Chao]
v4:
- https://lore.kernel.org/all/20251016222816.141523-1-seanjc@google.com
- Tweak changelog regarding the "cache" rename to try and better capture
the details of how .curr is used. [Yan]
- Synchronize the cache immediately after TD-Exit to minimize the window
where the cache is stale (even with the reboot change, it's still nice to
minimize the window). [Yan]
- Leave the user-return notifier registered on reboot/shutdown so that the
common code doesn't have to be paranoid about being interrupted.
v3: https://lore.kernel.org/all/15fa59ba7f6f849082fb36735e784071539d5ad2.1758002303.git.houwenlong.hwl@antgroup.com
v1 (cache): https://lore.kernel.org/all/20250919214259.1584273-1-seanjc@google.com
Hou Wenlong (1):
KVM: x86: Don't disable IRQs when unregistering user-return notifier
Sean Christopherson (3):
KVM: TDX: Explicitly set user-return MSRs that *may* be clobbered by
the TDX-Module
KVM: x86: WARN if user-return MSR notifier is registered on exit
KVM: x86: Leave user-return notifier registered on reboot/shutdown
arch/x86/include/asm/kvm_host.h | 1 -
arch/x86/kvm/vmx/tdx.c | 52 +++++++++++-------------
arch/x86/kvm/vmx/tdx.h | 1 -
arch/x86/kvm/x86.c | 72 ++++++++++++++++++++-------------
4 files changed, 66 insertions(+), 60 deletions(-)
base-commit: 4cc167c50eb19d44ac7e204938724e685e3d8057
--
2.51.1.930.gacf6e81ea2-goog
next reply other threads:[~2025-10-30 19:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 19:15 Sean Christopherson [this message]
2025-10-30 19:15 ` [PATCH v5 1/4] KVM: TDX: Explicitly set user-return MSRs that *may* be clobbered by the TDX-Module Sean Christopherson
2025-11-03 6:20 ` Yan Zhao
2025-11-04 7:06 ` Yan Zhao
2025-11-04 8:40 ` Xiaoyao Li
2025-11-04 9:31 ` Yan Zhao
2025-11-04 17:55 ` Sean Christopherson
2025-11-05 1:52 ` Yan Zhao
2025-11-05 9:16 ` Xiaoyao Li
2025-11-06 2:22 ` Yan Zhao
2025-11-03 7:42 ` Xiaoyao Li
2025-10-30 19:15 ` [PATCH v5 2/4] KVM: x86: WARN if user-return MSR notifier is registered on exit Sean Christopherson
2025-10-30 19:15 ` [PATCH v5 3/4] KVM: x86: Leave user-return notifier registered on reboot/shutdown Sean Christopherson
2025-11-07 8:18 ` Chao Gao
2025-11-08 1:37 ` Sean Christopherson
2025-10-30 19:15 ` [PATCH v5 4/4] KVM: x86: Don't disable IRQs when unregistering user-return notifier Sean Christopherson
2025-11-04 10:34 ` Huang, Kai
2025-11-10 15:37 ` [PATCH v5 0/4] KVM: x86: User-return MSR fix+cleanups Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030191528.3380553-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).