public inbox for linux-coco@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] coco/guest: Remove unneeded selection of CRYPTO
@ 2025-12-04  5:55 Eric Biggers
  2026-01-09  2:26 ` Eric Biggers
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Biggers @ 2025-12-04  5:55 UTC (permalink / raw)
  To: Dan Williams, linux-coco; +Cc: Eric Biggers

All that's needed here is CRYPTO_HASH_INFO.  It used to be the case that
CRYPTO_HASH_INFO was visible only when CRYPTO, but that was fixed by
commit aacb37f597d0 ("lib/crypto: hash_info: Move hash_info.c into
lib/crypto/").  Now CRYPTO_HASH_INFO can be selected directly.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
 drivers/virt/coco/guest/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/virt/coco/guest/Kconfig b/drivers/virt/coco/guest/Kconfig
index 3d5e1d05bf34..da570dc4bd48 100644
--- a/drivers/virt/coco/guest/Kconfig
+++ b/drivers/virt/coco/guest/Kconfig
@@ -11,7 +11,6 @@ config TSM_REPORTS
 	tristate
 
 config TSM_MEASUREMENTS
 	select TSM_GUEST
 	select CRYPTO_HASH_INFO
-	select CRYPTO
 	bool

base-commit: b2c27842ba853508b0da00187a7508eb3a96c8f7
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] coco/guest: Remove unneeded selection of CRYPTO
  2025-12-04  5:55 [PATCH] coco/guest: Remove unneeded selection of CRYPTO Eric Biggers
@ 2026-01-09  2:26 ` Eric Biggers
  2026-03-14 20:55   ` Eric Biggers
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Biggers @ 2026-01-09  2:26 UTC (permalink / raw)
  To: Dan Williams, linux-coco

On Wed, Dec 03, 2025 at 09:55:12PM -0800, Eric Biggers wrote:
> All that's needed here is CRYPTO_HASH_INFO.  It used to be the case that
> CRYPTO_HASH_INFO was visible only when CRYPTO, but that was fixed by
> commit aacb37f597d0 ("lib/crypto: hash_info: Move hash_info.c into
> lib/crypto/").  Now CRYPTO_HASH_INFO can be selected directly.
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>  drivers/virt/coco/guest/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/virt/coco/guest/Kconfig b/drivers/virt/coco/guest/Kconfig
> index 3d5e1d05bf34..da570dc4bd48 100644
> --- a/drivers/virt/coco/guest/Kconfig
> +++ b/drivers/virt/coco/guest/Kconfig
> @@ -11,7 +11,6 @@ config TSM_REPORTS
>  	tristate
>  
>  config TSM_MEASUREMENTS
>  	select TSM_GUEST
>  	select CRYPTO_HASH_INFO
> -	select CRYPTO
>  	bool
> 

Any interest in applying this patch?

- Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] coco/guest: Remove unneeded selection of CRYPTO
  2026-01-09  2:26 ` Eric Biggers
@ 2026-03-14 20:55   ` Eric Biggers
  2026-03-14 22:04     ` Dan Williams
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Biggers @ 2026-03-14 20:55 UTC (permalink / raw)
  To: Dan Williams, linux-coco

On Thu, Jan 08, 2026 at 06:26:22PM -0800, Eric Biggers wrote:
> On Wed, Dec 03, 2025 at 09:55:12PM -0800, Eric Biggers wrote:
> > All that's needed here is CRYPTO_HASH_INFO.  It used to be the case that
> > CRYPTO_HASH_INFO was visible only when CRYPTO, but that was fixed by
> > commit aacb37f597d0 ("lib/crypto: hash_info: Move hash_info.c into
> > lib/crypto/").  Now CRYPTO_HASH_INFO can be selected directly.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> >  drivers/virt/coco/guest/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/virt/coco/guest/Kconfig b/drivers/virt/coco/guest/Kconfig
> > index 3d5e1d05bf34..da570dc4bd48 100644
> > --- a/drivers/virt/coco/guest/Kconfig
> > +++ b/drivers/virt/coco/guest/Kconfig
> > @@ -11,7 +11,6 @@ config TSM_REPORTS
> >  	tristate
> >  
> >  config TSM_MEASUREMENTS
> >  	select TSM_GUEST
> >  	select CRYPTO_HASH_INFO
> > -	select CRYPTO
> >  	bool
> > 
> 
> Any interest in applying this patch?

Ping.

If there continues to be no response, I'll take this patch via
libcrypto-next.

- Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] coco/guest: Remove unneeded selection of CRYPTO
  2026-03-14 20:55   ` Eric Biggers
@ 2026-03-14 22:04     ` Dan Williams
  2026-03-15 17:15       ` Eric Biggers
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Williams @ 2026-03-14 22:04 UTC (permalink / raw)
  To: Eric Biggers, Dan Williams, linux-coco

Eric Biggers wrote:
> On Thu, Jan 08, 2026 at 06:26:22PM -0800, Eric Biggers wrote:
> > On Wed, Dec 03, 2025 at 09:55:12PM -0800, Eric Biggers wrote:
> > > All that's needed here is CRYPTO_HASH_INFO.  It used to be the case that
> > > CRYPTO_HASH_INFO was visible only when CRYPTO, but that was fixed by
> > > commit aacb37f597d0 ("lib/crypto: hash_info: Move hash_info.c into
> > > lib/crypto/").  Now CRYPTO_HASH_INFO can be selected directly.
> > > 
> > > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > > ---
> > >  drivers/virt/coco/guest/Kconfig | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/virt/coco/guest/Kconfig b/drivers/virt/coco/guest/Kconfig
> > > index 3d5e1d05bf34..da570dc4bd48 100644
> > > --- a/drivers/virt/coco/guest/Kconfig
> > > +++ b/drivers/virt/coco/guest/Kconfig
> > > @@ -11,7 +11,6 @@ config TSM_REPORTS
> > >  	tristate
> > >  
> > >  config TSM_MEASUREMENTS
> > >  	select TSM_GUEST
> > >  	select CRYPTO_HASH_INFO
> > > -	select CRYPTO
> > >  	bool
> > > 
> > 
> > Any interest in applying this patch?
> 
> Ping.
> 
> If there continues to be no response, I'll take this patch via
> libcrypto-next.

Apologies, not sure how I missed this.

Acked-by: Dan Williams <dan.j.williams@intel.com>

...and yes, fine for this to go through libcrypto-next.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] coco/guest: Remove unneeded selection of CRYPTO
  2026-03-14 22:04     ` Dan Williams
@ 2026-03-15 17:15       ` Eric Biggers
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Biggers @ 2026-03-15 17:15 UTC (permalink / raw)
  To: Dan Williams; +Cc: linux-coco

On Sat, Mar 14, 2026 at 03:04:02PM -0700, Dan Williams wrote:
> Eric Biggers wrote:
> > On Thu, Jan 08, 2026 at 06:26:22PM -0800, Eric Biggers wrote:
> > > On Wed, Dec 03, 2025 at 09:55:12PM -0800, Eric Biggers wrote:
> > > > All that's needed here is CRYPTO_HASH_INFO.  It used to be the case that
> > > > CRYPTO_HASH_INFO was visible only when CRYPTO, but that was fixed by
> > > > commit aacb37f597d0 ("lib/crypto: hash_info: Move hash_info.c into
> > > > lib/crypto/").  Now CRYPTO_HASH_INFO can be selected directly.
> > > > 
> > > > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > > > ---
> > > >  drivers/virt/coco/guest/Kconfig | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/virt/coco/guest/Kconfig b/drivers/virt/coco/guest/Kconfig
> > > > index 3d5e1d05bf34..da570dc4bd48 100644
> > > > --- a/drivers/virt/coco/guest/Kconfig
> > > > +++ b/drivers/virt/coco/guest/Kconfig
> > > > @@ -11,7 +11,6 @@ config TSM_REPORTS
> > > >  	tristate
> > > >  
> > > >  config TSM_MEASUREMENTS
> > > >  	select TSM_GUEST
> > > >  	select CRYPTO_HASH_INFO
> > > > -	select CRYPTO
> > > >  	bool
> > > > 
> > > 
> > > Any interest in applying this patch?
> > 
> > Ping.
> > 
> > If there continues to be no response, I'll take this patch via
> > libcrypto-next.
> 
> Apologies, not sure how I missed this.
> 
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> 
> ...and yes, fine for this to go through libcrypto-next.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-15 17:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04  5:55 [PATCH] coco/guest: Remove unneeded selection of CRYPTO Eric Biggers
2026-01-09  2:26 ` Eric Biggers
2026-03-14 20:55   ` Eric Biggers
2026-03-14 22:04     ` Dan Williams
2026-03-15 17:15       ` Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox