From: Bjorn Helgaas <helgaas@kernel.org>
To: Li Ming <ming.li@zohomail.com>
Cc: dan.j.williams@intel.com, linux-pci@vger.kernel.org,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI/IDE: Fix reading a wrong reg for unused sel stream initialization
Date: Tue, 13 Jan 2026 13:10:03 -0600 [thread overview]
Message-ID: <20260113191003.GA776139@bhelgaas> (raw)
In-Reply-To: <20260111073823.486665-1-ming.li@zohomail.com>
On Sun, Jan 11, 2026 at 03:38:23PM +0800, Li Ming wrote:
> During pci_ide_init(), it will write PCI_ID_RESERVED_STREAM_ID into all
> unused selective IDE stream blocks. In a selective IDE stream block, IDE
> stream ID field is in selective IDE stream control register instead of
> selective IDE stream capability register.
>
> Fixes: 079115370d00 ("PCI/IDE: Initialize an ID for all IDE streams")
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Dan, I assume you'll take this? It looks like you've merged
everything to do with ide.c.
> ---
> drivers/pci/ide.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/ide.c b/drivers/pci/ide.c
> index f0ef474e1a0d..26f7cc94ec31 100644
> --- a/drivers/pci/ide.c
> +++ b/drivers/pci/ide.c
> @@ -168,7 +168,7 @@ void pci_ide_init(struct pci_dev *pdev)
> for (u16 i = 0; i < nr_streams; i++) {
> int pos = __sel_ide_offset(ide_cap, nr_link_ide, i, nr_ide_mem);
>
> - pci_read_config_dword(pdev, pos + PCI_IDE_SEL_CAP, &val);
> + pci_read_config_dword(pdev, pos + PCI_IDE_SEL_CTL, &val);
> if (val & PCI_IDE_SEL_CTL_EN)
> continue;
> val &= ~PCI_IDE_SEL_CTL_ID;
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-01-13 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 7:38 [PATCH 1/1] PCI/IDE: Fix reading a wrong reg for unused sel stream initialization Li Ming
2026-01-12 2:54 ` Xu Yilun
2026-01-13 19:10 ` Bjorn Helgaas [this message]
2026-01-14 16:15 ` dan.j.williams
2026-01-23 1:40 ` dan.j.williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113191003.GA776139@bhelgaas \
--to=helgaas@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.li@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox