From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1DD13890F9; Mon, 27 Apr 2026 06:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777272718; cv=none; b=n3eEqohOhTpKocJKYYi+F0D9PLY/GAhYzaO4O4oxbGavCISlYqsXeOjflJp+qHRhQDnm0zYlhp1LBaaqeYTLHp5z27alCaL9MgMad4sVNm9v6VzmEyRkAYrUTj6ySOxPHRGY2VavrggSSSlGGsK+ZOrYBUHLv7QS/0ZJRpzgEYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777272718; c=relaxed/simple; bh=VdMmOEU+WLMyu9cmy2MbebMhWXlrd9XagLeJX1bJz2k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J8KcjtQ6BQUXjmxymUp2IvI6KoQwCTsTY+oWx8+YV7CjHETlITJ2KC1bk0WhaDT8CWwKAvmUyaxZgGzsMFQRHSHcRIo6SFNbSBy6jMgGu2syEDlCKHSey5IaV9h7u5M5kCPYJO1bGmlgycsREaGPj+WzRwTT8oQJn21kVMK3krQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mHDcAh0M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mHDcAh0M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D439AC2BCB6; Mon, 27 Apr 2026 06:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777272717; bh=VdMmOEU+WLMyu9cmy2MbebMhWXlrd9XagLeJX1bJz2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mHDcAh0MjFFeCWsaT8LYI3QxIrELTsBuhydteOCg89CSXExibrFJGp9JHQD0mro0A gvfeLdJ3KCcsVRL7u6phEJL50TC0CnBxBDiVcG8yddDXuHW/UrehMu0dF7dB0RY7ci dwJnorCauY+KnLrstUcajhrgnmkKVfahoJmwIWpgYv3Kh+ti/CFM6pn4dYWB2JioEl yITWmUYSAubJYKkDqs6xen8abOLlyi04nf+pys2kjNiGkI0wiaP6AZ/e840rZYzKZU nBkVmq+KrA6uNSONIXOuoe0LgHCtJkO0cU1RWja2cz8W437/e7KylIz7FvReSf4VCf k3zMy3wvToIWQ== From: "Aneesh Kumar K.V (Arm)" To: linux-coco@lists.linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Aneesh Kumar K.V (Arm)" , Alexey Kardashevskiy , Catalin Marinas , Dan Williams , Jason Gunthorpe , Jonathan Cameron , Marc Zyngier , Samuel Ortiz , Steven Price , Suzuki K Poulose , Will Deacon , Xu Yilun Subject: [RFC PATCH v4 04/14] coco: host: arm64: Add helper to stop and tear down an RMM pdev Date: Mon, 27 Apr 2026 12:21:11 +0530 Message-ID: <20260427065121.916615-5-aneesh.kumar@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427065121.916615-1-aneesh.kumar@kernel.org> References: <20260427065121.916615-1-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add helper to stop and tear down an RMM pdev - describe the RMI_PDEV_STOP/RMI_PDEV_DESTROY SMC IDs and provide wrappers in rmi_cmds.h - implement pdev_stop_and_destroy() so the host driver stops the pdev, waits for it to reach RMI_PDEV_STOPPED and destroys it Signed-off-by: Aneesh Kumar K.V (Arm) --- arch/arm64/include/asm/rmi_cmds.h | 9 +++++ drivers/virt/coco/arm-cca-host/rmi-da.c | 47 ++++++++++++++++++++++++- drivers/virt/coco/arm-cca-host/rmi-da.h | 1 + 3 files changed, 56 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/rmi_cmds.h b/arch/arm64/include/asm/rmi_cmds.h index 6664c439173f..8024e9d89e55 100644 --- a/arch/arm64/include/asm/rmi_cmds.h +++ b/arch/arm64/include/asm/rmi_cmds.h @@ -756,4 +756,13 @@ static inline unsigned long rmi_pdev_abort(unsigned long pdev_phys) return res.a0; } +static inline unsigned long rmi_pdev_stop(unsigned long pdev_phys) +{ + struct arm_smccc_res res; + + arm_smccc_1_1_invoke(SMC_RMI_PDEV_STOP, pdev_phys, &res); + + return res.a0; +} + #endif /* __ASM_RMI_CMDS_H */ diff --git a/drivers/virt/coco/arm-cca-host/rmi-da.c b/drivers/virt/coco/arm-cca-host/rmi-da.c index dc159d9f2c24..8a43a1f1c036 100644 --- a/drivers/virt/coco/arm-cca-host/rmi-da.c +++ b/drivers/virt/coco/arm-cca-host/rmi-da.c @@ -399,7 +399,7 @@ static void pdev_state_transition_workfn(struct work_struct *work) WARN_ON(state != setup_work->target_state); } -static int __maybe_unused submit_pdev_state_transition_work(struct pci_dev *pdev, +static int submit_pdev_state_transition_work(struct pci_dev *pdev, enum rmi_pdev_state target_state) { enum rmi_pdev_state state; @@ -425,3 +425,48 @@ static int __maybe_unused submit_pdev_state_transition_work(struct pci_dev *pdev return -1; return 0; } + +static inline int rmi_pdev_destroy(unsigned long pdev_phys, + unsigned long *rmi_ret) +{ + struct rmi_sro_state *sro __free(sro) = + rmi_sro_init(SMC_RMI_PDEV_DESTROY, pdev_phys); + if (!sro) + return -ENOMEM; + + *rmi_ret = rmi_sro_execute(sro); + + return 0; +} + +void cca_pdev_stop_and_destroy(struct pci_dev *pdev) +{ + int ret; + unsigned long rmi_ret; + struct cca_host_pdev_dsc *pdev_dsc = to_cca_pdev_dsc(pdev); + struct cca_host_pf0_ep_dsc *pf0_ep_dsc = to_cca_pf0_ep_dsc(pdev); + phys_addr_t rmm_pdev_phys = virt_to_phys(pdev_dsc->rmm_pdev); + + if (WARN_ON(rmi_pdev_stop(rmm_pdev_phys))) + return; + + ret = submit_pdev_state_transition_work(pdev, RMI_PDEV_STOPPED); + if (ret) + return; + + ret = rmi_pdev_destroy(rmm_pdev_phys, &rmi_ret); + if (WARN_ON(ret || rmi_ret)) + return; + + if (pf0_ep_dsc) { + kfree(pf0_ep_dsc->cert_chain.public_key); + kvfree(pf0_ep_dsc->cert_chain.cache); + kvfree(pf0_ep_dsc->vca); + pf0_ep_dsc->cert_chain.cache = NULL; + pf0_ep_dsc->vca = NULL; + } + + if (!rmi_undelegate_page(rmm_pdev_phys)) + free_page((unsigned long)pdev_dsc->rmm_pdev); + pdev_dsc->rmm_pdev = NULL; +} diff --git a/drivers/virt/coco/arm-cca-host/rmi-da.h b/drivers/virt/coco/arm-cca-host/rmi-da.h index 9f72ff8f28bf..784eb1fff95d 100644 --- a/drivers/virt/coco/arm-cca-host/rmi-da.h +++ b/drivers/virt/coco/arm-cca-host/rmi-da.h @@ -133,5 +133,6 @@ static inline struct cca_host_comm_data *to_cca_comm_data(struct pci_dev *pdev) } int cca_pdev_create(struct pci_dev *pdev); +void cca_pdev_stop_and_destroy(struct pci_dev *pdev); #endif -- 2.43.0