Re: [PATCH v8 07/21] coco/tdx-host: Implement firmware upload sysfs ABI for TDX module updates

Dave Hansen
2026-04-29T23:17:11Z

On 4/27/26 08:28, Chao Gao wrote:
> Linux kernel supports two primary firmware update mechanisms:
> - request_firmware()
> - firmware upload (or fw_upload)

All the stuff here is good info, but it was hard to extract the
implementation information from the background.

I think this would do:

Select fw_upload for doing TDX module updates. The process of
selecting among available update images is complicated and
nuanced. Punt the selection policy out to userspace.

...
> +static int seamldr_init(struct device *dev)
> +{
> + struct fw_upload *tdx_fwl;
> +
> + if (!can_expose_seamldr())
> + return 0;

can_expose_seamldr() has a not great name.

Why not just have naming that says:

if (supports_runtime_update())
...

Why abstract this out to what can or can't be exposed?