From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921443803F8 for ; Fri, 15 May 2026 19:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778872831; cv=none; b=pK6clHxSbZodKc8Fdj3xaY7tHggDkui9cRH2aw7IscH9N6Hi3CVuxawryfUSaQjf3DPzmqj19hoDAY2kG+uWAkPsXR6ZTMl7Tb3qE/DXXLLkvlVvv5ILioE3/pyf2ePbGsO7yq2Xn6cyBD5IPkTmVZddZ0AoHZEb0JM+Tdcgyr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778872831; c=relaxed/simple; bh=nvaTcMbyfjZXZc1w2lrIIDutznVhYZokau/9P9cewsQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=WzHhmZHDoGSRDWmtNVvFLdksibRznJv9qbo8T6rTiICffCpFiSI52DPY0Yhfhp1PW9ptPAetNFSSvtkEHsWWsyPZDbKVZyboCcvFzsGbD0++GwemPzitoIis/rNoj9tv429qv7pK17XyHTddPNt5RN+yWhOoe4AHI/cL0ShVkCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Qbc9j9T7; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qbc9j9T7" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-82fa1c94b37so1317717b3a.0 for ; Fri, 15 May 2026 12:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778872829; x=1779477629; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=ikDY1x359wvY/+q3wacNdXpEm487YvEWh2udCoEd+NA=; b=Qbc9j9T7SSHK0XeOFPqhYTprGFcJ0NfqfpHXG25Kvjl3Px/MJFVeIQktcMhSkk1yIr lI2zktXH3PRmZUwa9+grosV2fBA+YC6sXA+ma10I6nFKR3C9n2oHK/mCylyn2viNEVby 9ZgQQxpOyFbJKn+gZzv267ESz1LEMoL+5oK1guxmIYmU0mlY7x37+siwkrCCHwupkTXc CXa2pyqWDN1r3KiKAQzPqhOgrxRER7GozrPCB5+Mx6x5JiLbQRoyaBpiDvfDc3mMlAmV slmWrFHlzukD4ebY681E5Z4yACrPZVTwjYuXufBMhFDqzZI+/QnphuS/LasBR5V77Ri5 4bdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778872829; x=1779477629; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ikDY1x359wvY/+q3wacNdXpEm487YvEWh2udCoEd+NA=; b=Hl/hNhp75HbzihuZhwYSZcpuE29bi/YmMNrSZjgD1j6zhDj+AMNJ5+dF6P8KWlH5CG SFf7gMB+LQT8Nyv90PtuXna5z9qB7Ek4uDKk1p2abIVJnkZFfkniIHvAIspwZ4XKCM9N OpwxyynTHG8ZfzK5dcE5AMfPkU5kSu238krOXh94I/EeBMR8vQ+jdlcTVrFpbYuNKB0d 9mAdNbz1do8P2vvmo86LQ+WSTqN3fJEjqtQdgqkb7B+oFw+JF5qrKv/+Xw86ooQtA1pP J7A4Y2muiwoOxVOAC8GUcdJR+L9XeIOS9BvU39J7cxr6KTEd65CC+a0IQqu5zPa2x0k2 Rmow== X-Forwarded-Encrypted: i=1; AFNElJ+IJvopbgPfvjCc9BY47Jx4iPxyO0wMP3Gk27lh5G8i79BJKQRXqbLpRBAkMlXH0RU1A/l1HYS1S+Ks@lists.linux.dev X-Gm-Message-State: AOJu0YzTK6HX/IxkSK9xCNALAUB6uvlm9xUs3H3ln2hB0zNRvqRGaN3M VlVi6E+278Pg2ni92xLokVhcPYmDgWFx1cK4/Mgk/i+hxzx8HLaFOiMf/ffyz3ucTRG79jATyKG BnqIRVQ== X-Received: from pfbgg10.prod.google.com ([2002:a05:6a00:630a:b0:83a:d498:99fb]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:a907:b0:835:447b:a2ac with SMTP id d2e1a72fcca58-83f18d5b8f5mr8777489b3a.5.1778872828431; Fri, 15 May 2026 12:20:28 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 15 May 2026 12:19:05 -0700 In-Reply-To: <20260515191942.1892718-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260515191942.1892718-1-seanjc@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260515191942.1892718-5-seanjc@google.com> Subject: [PATCH v3 04/41] x86/sev: Move check for SNP Secure TSC support to tsc_early_init() From: Sean Christopherson To: Kiryl Shutsemau , Paolo Bonzini , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Rick Edgecombe , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , Thomas Gleixner , David Woodhouse Content-Type: text/plain; charset="UTF-8" Move the check on having a Secure TSC to the common tsc_early_init() so that it's obvious that having a Secure TSC is conditional, and to prepare for adding TDX to the mix (blindly initializing *both* SNP and TDX TSC logic looks especially weird). No functional change intended. Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 3 --- arch/x86/kernel/tsc.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 14ced854cd83..39fb50697542 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2029,9 +2029,6 @@ void __init snp_secure_tsc_init(void) unsigned long tsc_freq_mhz; void *mem; - if (!cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) - return; - mem = early_memremap_encrypted(sev_secrets_pa, PAGE_SIZE); if (!mem) { pr_err("Unable to get TSC_FACTOR: failed to map the SNP secrets page.\n"); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 7e639c0a94a2..243999692aea 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1559,7 +1559,8 @@ void __init tsc_early_init(void) if (is_early_uv_system()) return; - snp_secure_tsc_init(); + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) + snp_secure_tsc_init(); if (!determine_cpu_tsc_frequencies(true)) return; -- 2.54.0.563.g4f69b47b94-goog