From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F8C3410D13 for ; Tue, 9 Jun 2026 12:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007361; cv=none; b=c00/rNCN0ccszCVZV3Oeo3sCzxXy2dpdp0BHv+ns9+szzN8524zD1Mjq6zMNcuffKKBj5uhHd/EFPPoUm0oRs6kM6ynDAgwXSOF6rytZkCRCKjOIU7+smnTdp58E5cYKKwFqeWBG6ZGXdm0qVGqugRInR/ugzBsOL0gT6AIdhX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007361; c=relaxed/simple; bh=brtgLaNnyjw2YXdYG21MgcS8I6CCPSHYKNmm+BOhNKM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eCQNcbyabzv8nRfKKgm+Jz9UL/J+u3X9/UnFWux7+iK+U+z6DgIhw3y12zC81GteGbr+HBTM+Y6wx5vXp+hcffM+O7H5yv9tvnxlBuKLSv9+vs83H3WjV/86+fOD2b4W7qqTmgpz9SdLjYk+BAGYw04ZYfXN3T87txwGnZOTsgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aEO24Yv/; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aEO24Yv/" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b1aefe1cso5820315e9.2 for ; Tue, 09 Jun 2026 05:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781007357; x=1781612157; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=d7sN51CIvQwRuTJi3qMza06o4wJMznBiMEkiJVIlNBs=; b=aEO24Yv/+ICVYF8i7VSgo2y64nzVygobJX2R1G4m4L0/3pY5YkUpMQOLZzSVzoHauy YvXmZuvhz/H1FatM8xvz3QiehzD2ICb8WX2sAq9/HjZXGAQweWS0zZx4JltpBciWh0Mu Y8TYhF/wRmT4AFsU1MASII8rZL7EnEFdEmaCUaUFAB/AqV2GHowqtLfxjhTL2PxRLg6A Vyl6sl07CDfxbABh/QcCDC+Qhy0cWMY5mS0FZoHLMr1nZf1FsJ5BBHWnMewtGmKENZ9h 57AISMIUAcHaBF12M/mRpier4vaZrcoXc0SblOLpj/OEUgk5vVv3dgnakAJgUbkjeFMI 7bmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781007357; x=1781612157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d7sN51CIvQwRuTJi3qMza06o4wJMznBiMEkiJVIlNBs=; b=rrBCzRW7vAHTkViRiojdq+TuKPwinGLcjQ6+bYpjPoMGaVx1w+cKyiDsneTdThMTvr 4UOQ5samco1eRA1xZBsNSa0bMY501JCOJvGdxSmIXhg+hku4Xg4wHil3pKnvi6Knkfun +iMgn6JMEiXr96Qi9T+V80cDjsEOtcKh/BhVut9tQEVn/nLdgiiWZ3InMqm2viv/9T5k xx84G2X4Gy04kIMzAiTJP1M41wvGnJMo74zsN4XLyjM9nbYtMRdTE2nFlpZEiJaGP8Hx Kbegzp2btEeQdaE1/vfb8T6M8tqT46EjOFIEBanDyw7E2NVvX6oyfUpd74yHAaH3/d6+ M1aw== X-Forwarded-Encrypted: i=1; AFNElJ+xLTVjZ+FIdZRxBWedTklNOTs/BeYr7bNAqXtVefUMDUMLM4yIuSQc7lqdzVJFebykwh9oPjzC/aH4@lists.linux.dev X-Gm-Message-State: AOJu0YxiEqpzm0PJJ/UkLs2XtcD5olCVg9N0LA6J9Hievid4/Ocd+cDf X+9O+Uupz/xVYeLfqb+ntyuTBnYfwsU938NfehAef5HMy6aT6x624DiMHNSgTek70+A= X-Gm-Gg: Acq92OHud37Bpw0fqKjFZueKiXP4RJlKVbRBPUfslwQWvJw0zbX91kdpHYleh9Do6WP z5sOyoas9cLWT9EBQbg9bOpmVmoddp8UY9bZfxbgNprDNqAMS6oCBQ2Gru4GLn5Bj73/oyv5Xx5 76H6z0jp53RYrUDydq2PvTGAJNWZ/w4w39btbpkJGs7IVWyip+DDas+ImEh37z3SFDvvsRxNUQ4 hbFVJgcGJ2THJSFUGZAcHorEwtxQmHnX7ZM6O6IzoszgF+yVzsMhSeHZT0WnbjbSJPBBkh8Q+er EDBIs86mQs8y7gc2sRIaZQAaPxMtuo0f7w7GtgqLpUo2AtDEIaFEX64wCT9wvl5qDlQ6YiEvkbt 4DzUgf5AydkbI7BOOFJpgeF4dwFyZW7lGeNg2l/wjRGk/wRIj9GoVIi+o6mnb7lHGIEHwt6ySZ8 pw5AqILfOUI0gPzlTqaETRnvc= X-Received: by 2002:a05:600c:620d:b0:48d:1021:e5d1 with SMTP id 5b1f17b1804b1-490c25f597emr139602585e9.3.1781007356518; Tue, 09 Jun 2026 05:15:56 -0700 (PDT) Received: from mordecai ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3e5a00sm473055565e9.15.2026.06.09.05.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:15:55 -0700 (PDT) Date: Tue, 9 Jun 2026 14:15:48 +0200 From: Petr Tesarik To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Jason Gunthorpe , Mostafa Saleh , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Jiri Pirko , Michael Kelley Subject: Re: [PATCH v6 02/20] dma-direct: swiotlb: handle swiotlb alloc/free outside __dma_direct_alloc_pages Message-ID: <20260609141548.70a5848d@mordecai> In-Reply-To: <20260604083959.1265923-3-aneesh.kumar@kernel.org> References: <20260604083959.1265923-1-aneesh.kumar@kernel.org> <20260604083959.1265923-3-aneesh.kumar@kernel.org> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 4 Jun 2026 14:09:41 +0530 "Aneesh Kumar K.V (Arm)" wrote: > Move swiotlb allocation out of __dma_direct_alloc_pages() and handle it in > dma_direct_alloc() / dma_direct_alloc_pages(). > > This is needed for follow-up changes that simplify the handling of > memory encryption/decryption based on the DMA attribute flags. > > swiotlb backing pages are already mapped decrypted by > swiotlb_update_mem_attributes() and rmem_swiotlb_device_init(), so > dma-direct should not call dma_set_decrypted() on allocation nor > dma_set_encrypted() on free for swiotlb-backed memory. > > Update alloc/free paths to detect swiotlb-backed pages and skip > encrypt/decrypt transitions for those paths. Keep the existing highmem > rejection in dma_direct_alloc_pages() for swiotlb allocations. > > Only for "restricted-dma-pool", we currently set `for_alloc = true`, while > rmem_swiotlb_device_init() decrypts the whole pool up front. This pool is > typically used together with "shared-dma-pool", where the shared region is > accessed after remap/ioremap and the returned address is suitable for > decrypted memory access. So existing code paths remain valid. > > Tested-by: Jiri Pirko > Tested-by: Michael Kelley > Tested-by: Mostafa Saleh > Signed-off-by: Aneesh Kumar K.V (Arm) > --- > include/linux/swiotlb.h | 6 ++++ > kernel/dma/direct.c | 71 ++++++++++++++++++++++++++++++----------- > kernel/dma/swiotlb.c | 6 ++++ > 3 files changed, 65 insertions(+), 18 deletions(-) > > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index 3dae0f592063..133bb8ca9032 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -284,6 +284,8 @@ extern void swiotlb_print_info(void); > #ifdef CONFIG_DMA_RESTRICTED_POOL > struct page *swiotlb_alloc(struct device *dev, size_t size); > bool swiotlb_free(struct device *dev, struct page *page, size_t size); > +void swiotlb_free_from_pool(struct device *dev, phys_addr_t tlb_addr, > + size_t size, struct io_tlb_pool *pool); > > static inline bool is_swiotlb_for_alloc(struct device *dev) > { > @@ -299,6 +301,10 @@ static inline bool swiotlb_free(struct device *dev, struct page *page, > { > return false; > } > +static inline void swiotlb_free_from_pool(struct device *dev, phys_addr_t tlb_addr, > + size_t size, struct io_tlb_pool *pool) > +{ > +} > static inline bool is_swiotlb_for_alloc(struct device *dev) > { > return false; > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 583c5922bca2..a741c8a2ee66 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -96,14 +96,6 @@ static int dma_set_encrypted(struct device *dev, void *vaddr, size_t size) > return ret; > } > > -static void __dma_direct_free_pages(struct device *dev, struct page *page, > - size_t size) > -{ > - if (swiotlb_free(dev, page, size)) > - return; > - dma_free_contiguous(dev, page, size); > -} > - > static struct page *dma_direct_alloc_swiotlb(struct device *dev, size_t size) > { > struct page *page = swiotlb_alloc(dev, size); > @@ -125,9 +117,6 @@ static struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > > WARN_ON_ONCE(!PAGE_ALIGNED(size)); > > - if (is_swiotlb_for_alloc(dev)) > - return dma_direct_alloc_swiotlb(dev, size); > - > gfp |= dma_direct_optimal_gfp_mask(dev, &phys_limit); > page = dma_alloc_contiguous(dev, size, gfp); > if (page) { > @@ -204,6 +193,7 @@ void *dma_direct_alloc(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) > { > bool remap = false, set_uncached = false; > + bool mark_mem_decrypt = true; > struct page *page; > void *ret; > > @@ -250,11 +240,21 @@ void *dma_direct_alloc(struct device *dev, size_t size, > dma_direct_use_pool(dev, gfp)) > return dma_direct_alloc_from_pool(dev, size, dma_handle, gfp); > > + if (is_swiotlb_for_alloc(dev)) { > + page = dma_direct_alloc_swiotlb(dev, size); > + if (page) { > + mark_mem_decrypt = false; > + goto setup_page; > + } > + return NULL; > + } > + > /* we always manually zero the memory once we are done */ > page = __dma_direct_alloc_pages(dev, size, gfp & ~__GFP_ZERO, true); > if (!page) > return NULL; > > +setup_page: > /* > * dma_alloc_contiguous can return highmem pages depending on a > * combination the cma= arguments and per-arch setup. These need to be > @@ -281,7 +281,7 @@ void *dma_direct_alloc(struct device *dev, size_t size, > goto out_free_pages; > } else { > ret = page_address(page); > - if (dma_set_decrypted(dev, ret, size)) > + if (mark_mem_decrypt && dma_set_decrypted(dev, ret, size)) > goto out_leak_pages; > } > > @@ -298,10 +298,11 @@ void *dma_direct_alloc(struct device *dev, size_t size, > return ret; > > out_encrypt_pages: > - if (dma_set_encrypted(dev, page_address(page), size)) > + if (mark_mem_decrypt && dma_set_encrypted(dev, page_address(page), size)) > return NULL; > out_free_pages: > - __dma_direct_free_pages(dev, page, size); > + if (!swiotlb_free(dev, page, size)) > + dma_free_contiguous(dev, page, size); > return NULL; > out_leak_pages: > return NULL; > @@ -310,6 +311,9 @@ void *dma_direct_alloc(struct device *dev, size_t size, > void dma_direct_free(struct device *dev, size_t size, > void *cpu_addr, dma_addr_t dma_addr, unsigned long attrs) > { > + phys_addr_t phys; > + bool mark_mem_encrypted = true; > + struct io_tlb_pool *swiotlb_pool; > unsigned int page_order = get_order(size); > > if ((attrs & DMA_ATTR_NO_KERNEL_MAPPING) && > @@ -338,16 +342,25 @@ void dma_direct_free(struct device *dev, size_t size, > dma_free_from_pool(dev, cpu_addr, PAGE_ALIGN(size))) > return; > > + phys = dma_to_phys(dev, dma_addr); > + swiotlb_pool = swiotlb_find_pool(dev, phys); > + if (swiotlb_pool) > + /* Swiotlb doesn't need a page attribute update on free */ > + mark_mem_encrypted = false; > + > if (is_vmalloc_addr(cpu_addr)) { > vunmap(cpu_addr); > } else { > if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_CLEAR_UNCACHED)) > arch_dma_clear_uncached(cpu_addr, size); > - if (dma_set_encrypted(dev, cpu_addr, size)) > + if (mark_mem_encrypted && dma_set_encrypted(dev, cpu_addr, size)) > return; > } > > - __dma_direct_free_pages(dev, dma_direct_to_page(dev, dma_addr), size); > + if (swiotlb_pool) > + swiotlb_free_from_pool(dev, phys, size, swiotlb_pool); > + else > + dma_free_contiguous(dev, dma_direct_to_page(dev, dma_addr), size); > } > > struct page *dma_direct_alloc_pages(struct device *dev, size_t size, > @@ -359,6 +372,15 @@ struct page *dma_direct_alloc_pages(struct device *dev, size_t size, > if (force_dma_unencrypted(dev) && dma_direct_use_pool(dev, gfp)) > return dma_direct_alloc_from_pool(dev, size, dma_handle, gfp); > > + if (is_swiotlb_for_alloc(dev)) { > + page = dma_direct_alloc_swiotlb(dev, size); > + if (!page) > + return NULL; > + > + ret = page_address(page); > + goto setup_page; > + } > + > page = __dma_direct_alloc_pages(dev, size, gfp, false); > if (!page) > return NULL; > @@ -366,6 +388,7 @@ struct page *dma_direct_alloc_pages(struct device *dev, size_t size, > ret = page_address(page); > if (dma_set_decrypted(dev, ret, size)) > goto out_leak_pages; > +setup_page: > memset(ret, 0, size); > *dma_handle = phys_to_dma_direct(dev, page_to_phys(page)); > return page; > @@ -377,16 +400,28 @@ void dma_direct_free_pages(struct device *dev, size_t size, > struct page *page, dma_addr_t dma_addr, > enum dma_data_direction dir) > { > + phys_addr_t phys; > void *vaddr = page_address(page); > + struct io_tlb_pool *swiotlb_pool; > + bool mark_mem_encrypted = true; > > /* If cpu_addr is not from an atomic pool, dma_free_from_pool() fails */ > if (IS_ENABLED(CONFIG_DMA_COHERENT_POOL) && > dma_free_from_pool(dev, vaddr, size)) > return; > > - if (dma_set_encrypted(dev, vaddr, size)) > + phys = page_to_phys(page); > + swiotlb_pool = swiotlb_find_pool(dev, phys); > + if (swiotlb_pool) > + mark_mem_encrypted = false; > + > + if (mark_mem_encrypted && dma_set_encrypted(dev, vaddr, size)) > return; > - __dma_direct_free_pages(dev, page, size); > + > + if (swiotlb_pool) > + swiotlb_free_from_pool(dev, phys, size, swiotlb_pool); > + else > + dma_free_contiguous(dev, page, size); > } > > #if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \ > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index 1abd3e6146f4..ac03a6856c2e 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -1809,6 +1809,12 @@ bool swiotlb_free(struct device *dev, struct page *page, size_t size) > return true; > } > > +void swiotlb_free_from_pool(struct device *dev, phys_addr_t tlb_addr, size_t size, > + struct io_tlb_pool *pool) What's the reason to pass the buffer size if it's not used? Other than that, this patch looks good to me. Petr T > +{ > + swiotlb_release_slots(dev, tlb_addr, pool); > +} > + > static int rmem_swiotlb_device_init(struct reserved_mem *rmem, > struct device *dev) > {