From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C5B4A9D7E for ; Thu, 24 Sep 2026 16:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790269044; cv=none; b=INPTAaAu0ObcBQekQS0rTbAzyqhBLRhYWUwtRsT6u1ql1rnXeQyPuoOdJckuCyp91xH/gVZFx4ssol/OAkn7ak+FTnIjaGZEsQGqfhHFJAg9QCMHzPFhz2N0nJJpYbKhV9ywImzX699wlTsrHqb4ef4/rTDJMHfQtrWZ9TWNwO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790269044; c=relaxed/simple; bh=Hzsp1UFzoC59Md1gxeOIU+2qNTd46IkSWC0K1qbvf6w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iiTQUmqyCfVmN3HU3MtdxrohJ5yOBnWcOJIsMYUsOkEOvJwyk425pyS5lpcQ0BiFLU6uxCjM8gy54LJFVDcm/U/ZGA5mBlPbXYrQIeBqieI/7WWUt8jMhXnqv3nmwoLgIuWjPXuDyG993OabNLdji2acK4mygPmBTo5YicBLnVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pMi043bE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hztw/1vB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pMi043bE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hztw/1vB" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OFedkk3605094 for ; Thu, 24 Sep 2026 16:57:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M8tOw3w9WOlBwac6L5boAJMWocybycmH2cMyGQykxKE=; b=pMi043bE6QGr1lII pZb0IyUUMlzTpHxw6zL3pxwMkGK8zJVP5wf0pJMCdoiBDmqx+axCDSvvbSt23IG+ BXfrMC1Wk6A8fjtC5jzeO6bz4MdM8/VtpzpX5o5gQfB8x/IaQ8q666ePw+XLT9jY hN4i54agbS8Ri8oQRajPAwr8WtpfK2LI6h4DcFh427uEJSvVII/M1WCRWYDpOEF/ B+o+xUmeg8peBe8ZjmHPFWGCZMUcUluWBmV5cZiAO5OaeKNYVATURT3c9sJwbHjx sxtv395HGmucKB5F44AWHi/W2FjQSSkoJZWovi/F9mNyWsryNblI5zIHqqEqpQPI dx6LCw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1rahs8c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 16:57:19 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-39e3c10ac70so102141a91.2 for ; Thu, 24 Sep 2026 09:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790269039; x=1790873839; darn=lists.linux.dev; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=M8tOw3w9WOlBwac6L5boAJMWocybycmH2cMyGQykxKE=; b=hztw/1vBwptyZnSbua3Shv2776tZJUO+AvWCLIcPAPcvI4NxP/oVCpszezgrJn7I4h 3algw9LzOMOU2Iy0XAlHYIo80kDe+WIWJi0kEpSLNYNNsTe9XXdptCoaMv8RzW5ynob9 olygTG98uPIRyMIp1yqpW7u5dXJ5QKqVEIHa01bRLfxbk5dQswoBDbrspNCBvkTxRMeS M0lmuYk7YkZfVXsk5lECol5k20Hu480MZIvjMK+OmvpZ/taPmwKMJVnHj210bkGV2sSj aBnuzZU7aRuAhCw4EB4MppM7Ka4y66CVUyDZ6kjo3BqUWiKAdEmO/zmBDJIDfEgsWOu3 J7Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790269039; x=1790873839; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M8tOw3w9WOlBwac6L5boAJMWocybycmH2cMyGQykxKE=; b=syC6YuthmGZpmDdj/tyTuwYUlXf4D2FkrMjE2GK3wcVHv8fj5MWjm4Wkm8ikxgHXRz xIsawJd5AKV9WAe5HTwQOOH0WlQ+3myY08KdW5hLco16ZCb464EwtBbiz9T1HOT4gwLw 5YAz+pNbmxwCOEPb9R8UTJy3B8xhpsPziZIa8CMhKWq0r3sDsUcCME8bnSF04eK5hUUa 2wTRw8kFBMtZP1kkLNc6vkEPuUEhSly9WUGcZg8OQD/66nbl7807MN+QwE23oS0Nkjpi 2fKsEO8kzLnB4oBs42mS+2qClxOpbOKljEAtWsNWUsvVVZIlpUhLGSXVElLBQTPPetCf JsRg== X-Forwarded-Encrypted: i=1; AKwUvBxdGYBqPdJn2Tw+DtTexgXHBOWVIwiqMsgwccWMX8jbvOeccz4klR3tM4wENVwfYep5esDUeJNiNiNJ@lists.linux.dev X-Gm-Message-State: AFuF++mULUVR2TX99jRqPkFqTx51p9aXWAQ1fYOQ4pf+47miMx6on3Qd ongb5irB0yX7WWCkxhUlHzBMz/+BkE+AX0jPFZO6jwETcaZxky5SZxnoaZ5jEZ0RNBMgH4IZaC2 6s4YtcP/0zJr6jcuuC00RN3jVGc9VwcPwYjFyXoz0NBnI2UzKBVFAZyCydXlR1NG+ X-Gm-Gg: AYBFou0v54LqpTpYMNFa6O2pSaVdA6TcBICkC+wex2SO2jrLHrBBYhpvj/vicJDdUeI KzPO6AxNQOAtka2nT/kXgDwkFwFudarbEbTzx0JafCnfS+wmqGY4xV8xI5mepAJ5qSuouU+6AYx ELhbS0dkGSdQ4rgrHAUCEpCtfrr27WalkRWFIWHJ4KnFveKuy7qjIiWI9gd/M4cdI3gJTt2mLnr yPG9zPNRnpGO0jh7I+K1Wt52kBVMJcXX4BAiHZzXHG1wdjzxm2ab4S+6Cxg4eEx+SCuQH0uxuzz KAtyYtuolcA+zCT6PKkbFQf2EdkA3KZNIi9u99d449ZWvsWWjFB/014PCuCm+lAOA+BLEVdNJao Cv31pavZdaowoncjCaaUYDEwLoxZo6POGWV32SS5vL0ZfSh/5Db6PFQ== X-Received: by 2002:a17:90b:3c0f:b0:39d:eda9:febf with SMTP id 98e67ed59e1d1-3a098da4171mr3197736a91.18.1790269038443; Thu, 24 Sep 2026 09:57:18 -0700 (PDT) X-Received: by 2002:a17:90b:3c0f:b0:39d:eda9:febf with SMTP id 98e67ed59e1d1-3a098da4171mr3197707a91.18.1790269037987; Thu, 24 Sep 2026 09:57:17 -0700 (PDT) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0976cacbesm5687417a91.13.2026.09.24.09.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 09:57:17 -0700 (PDT) Date: Thu, 24 Sep 2026 09:57:12 -0700 From: Jonathan Cameron To: Suzuki K Poulose Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com, joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com, sudeep.holla@arm.com Subject: Re: [PATCH v19 1/7] firmware: arm_rmm: Add SMC definitions for calling the RMM Message-ID: <20260924095712.00004057@oss.qualcomm.com> In-Reply-To: <20260924135201.850038-2-suzuki.poulose@arm.com> References: <20260924135201.850038-1-suzuki.poulose@arm.com> <20260924135201.850038-2-suzuki.poulose@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA2OSBTYWx0ZWRfXxGmOdcK3EIbx xzAzalBmGtliqSvSnw9I7wvRe8p2MCUgysZ2sF9GgERdH6UbDsu7p/HNRXsYhkcP+zvgNU92WaD ZM1vX4ExbVB7AXBgVFEqRwqyb+43Td+W4pg1HFxEbDzsSpa3VojjihsCVDZdTjP0+91rBIBGQMi 9rXCk0MqD+151Bt88Mmv9Yl1ZBRh7TyU1YilfeBMuykJSyO76IUE+zw+X5Aww20dCgPPVbrsHTs f8U1M77N8M/OcLn1Tia2Ucd0TRMQBuIJ54FJ28cwC1AuV8misAbllaQzEfjfie+C6Jciys7vzWP 7rL3K79CQPLZbOhvaKXTPPlDXG7wJ2E2C1i7uCbQBBnqwuBv5JKbEmN6niwsmr/SRikYER2Ws5X Xsoynhxyf16pQdS8BkifjKO/NpSeEd4q2T/yiANY3w6avWoUa0T49QDlWcmIk42oEwS0vCIT7pY N0W9PXlItJwrfCG6AwQ== X-Proofpoint-ORIG-GUID: uWZP9TIflzv_YF2KxgFwh1KFF_D7SI5I X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA2OSBTYWx0ZWRfX/NOuMCJIEAof hVIYR1H2CVnpjiOBFVgIdMf9iXgIrA145phSkBHoUQn8ldfDZ0VPRFNz3gr2F7DQR/Tg0du8bEU 4ZOJXlvNJHRrRMWbD33/MnhuYleN2bU= X-Authority-Analysis: v=2.4 cv=fvpJ914f c=1 sm=1 tr=0 ts=6ab5566f cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=7CQSdrXTAAAA:8 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=SeLr52ClSpxFPvFle8UA:9 a=CjuIK1q_8ugA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: uWZP9TIflzv_YF2KxgFwh1KFF_D7SI5I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240069 On Thu, 24 Sep 2026 14:51:55 +0100 Suzuki K Poulose wrote: > From: Steven Price > > The RMM (Realm Management Monitor) provides functionality that can be > accessed by SMC calls from the host. > > The SMC definitions are based on DEN0137[1] version 2.0-bet3 > > [1] https://developer.arm.com/documentation/den0137/2-0bet3/ > > Reviewed-by: Gavin Shan > Signed-off-by: Steven Price > Signed-off-by: Suzuki K Poulose Hi Suzuki, One small thing I didn't really care about but where I thought you said you were going to tweak things. Either way Reviewed-by: Jonathan Cameron > +struct rec_exit { > + union { /* 0x000 */ > + u8 exit_reason; > + u8 padding0[0x100]; > + }; > + union { /* 0x100 */ > + struct { > + u64 esr; > + u64 far; > + u64 hpfar; > + u64 rtt_tree; > + }; > + u8 padding1[0x100]; > + }; > + union { /* 0x200 */ > + u64 gprs[REC_RUN_GPRS]; > + u8 padding2[0x100]; > + }; > + union { /* 0x300 */ > + u8 padding3[0x100]; I thought plan was to fold into the padding above? https://lore.kernel.org/all/d7ccaf22-5bde-4344-8bf0-a5a17dcac0f3@arm.com/ > + }; > + union { /* 0x400 */ > + struct { > + u64 cntp_ctl; > + u64 cntp_cval; > + u64 cntv_ctl; > + u64 cntv_cval; > + }; > + u8 padding4[0x100]; > + };