From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AABC44DAF89 for ; Fri, 16 Oct 2026 14:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792162728; cv=none; b=OkPE6EE35C+mpUso9PAt6f1SxlbgRs4HEh4F2d6z4wmv+p9VvOQM9kxqHFrHj6eNUEL6VTgFzDwfPPre3zH6L77jrKzOYFb6aSxT6vG3yaQYVzaItLHz2Y3DgpgoJmHI+OsAFIhRSjzHtvZOu7pkXRRfOuCOw660HDFDMV9ulFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792162728; c=relaxed/simple; bh=Gs6UDVs85lAeYcbz5natlQddcSkvTtyPzng7JiqW+ac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H0WKoe4CYzR/ILllsIJGSlizU4zpCzgtPAxsXhmN19ry09pdrFRHxdcMZ1X6jZHZpDzlVgcifoJZ9ZZYsX7v49ISyc3YRrq0wc5fwB9dC14oFUp+u9wJFwZn+lEttkhTrzBcKucQg9Qe329imGr5OLr1n+J63mF4kA6Qfy7gT5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=PNEmVOB9; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="PNEmVOB9" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-93e515769d3so2974285a.3 for ; Fri, 16 Oct 2026 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1792162725; x=1792767525; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Q4TOl9JQUahFIQiKudG6oBPl46TqBGSAJ68OWGmu91g=; b=PNEmVOB9Rg6QcEvX6/gWhD6UCBPSE32cake3aVtH1b8DaeVTJx18/sEL2ZpNTDcQ1E tjG6gh9rWPGqpcfiUy9XX8TEp3NNAH9d11k4gP+2z7ADpKirEb3UPEF8f5tRIF8l0Pv2 bNd038QKkbiMcnJVm4fMDs2whaTSR6C0K7Foqll40q42bC5dQBWosRsnfmaE4DrWMsVd pAOTCEZUfzJ8h2so04HvAV8S2gTnpSLeg32iBK+U6VqVZGMwBQ9HDunxA2ZnVBw175NN 8SaXkf6fma69TDmuDLXCC10yqEdQGvf7Is1Y4IoTFi1G2gvp9BaEbNXbmsi3J3X4LJmN j43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792162725; x=1792767525; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Q4TOl9JQUahFIQiKudG6oBPl46TqBGSAJ68OWGmu91g=; b=GGP1extW7OtyoNV/U7twTGylLPZLx5t4cAlJIGroOnXFk/OOV8vT/tcFea+9NmbU8j JaHodJFtaNcHmKBl1N6IvdLOCtGWhiEykzWt4D5Bx3bvR+DjgAEiTUrpyYhxUYOc1G+9 ThfFoI+WRq7Q/XkNH8F+CaX2EvxdgytKGwiwJ1efhdMa5vciGMJvA+D3f6K5Jo4BhFAl MWMnDHm8YLiDYVKYZtGjJlAz98uwdujU05mums/87Yv1uDTm5atj3SiytzhrBx5m/VuH edmccXe3D0rXy5N32smjVS1/mLnbuteqRTbXCrIeIsHKMjQ2B/KZ9L9tFA2gvFLe3bgT Jb8Q== X-Forwarded-Encrypted: i=1; AKwUvBzUTqf0jkNBYd19ti2nLVar8XQI/I/MalVPGqEHXiv0ZzwOX/PxSDqNiVoe3z9AUPlKdYUFpUMNZ2JX@lists.linux.dev X-Gm-Message-State: AFq9FYJO2NB79s7AGF81i7hi0gUumoy6IdLIOeoiMHhT4Z5sUN4Hj6n7 hMVMngQlhKTkjledxhYN6bROjwSTsfXEmzoYVo/CcGsa14jY2Rhf5UlQa1w8XgwWhTI= X-Gm-Gg: AYBFou2BiYr7hFso+BsJKx7OfJFd5CwZafvKqOVo3V2X1pUQqjUSkaa9qfWF0m2ZMex n9O3A82JQOeOTmtgr9O2G+HiocrP8J6BMPTTyuVZCSLE9ydg3BsD673SBbUbbI+ktOcHaPSGM4x t449cbKKaYVwYt5YyzZflzMBW6/G0qy1M6dBaFjtGVKHq3j/OsOJOSFATMiSXrfbF0Cv6pGgL7t 4YmWx3Iv8u9nrHUwwlroAzcF0NQ0V3jaEYwLrfxavv6kCbhg70guL9g37EHjIgHegOeec4pw6Kz A5aYqyt5JQ7XWtUWakvWGrlAv/bx90ymY/DRlrJiShqiaHbC/nf12A/q/QHoIMEFlO675mjG0Yp G+VSS1vnrI1HP5jPWrcmFxgEeUv8Rl54ENxZhUs/pzolII0smufIlLmVL+xJdtgx8zfZEdQMXb7 BMxxXUvXMRA2UAhw+LBIvMDlwwfOF48u3eBHNRm3oruxjH2R77xP4L52WyEWSVuhZvpi05Pk4DB JGrPE3ySpf80W/0Bk6et9JhLTRmO1b9UZtqwbxwXfBVmXa9zvyYYzn1 X-Received: by 2002:a05:620a:7113:b0:93e:96cb:3083 with SMTP id af79cd13be357-93f29d38660mr12133885a.33.1792162725326; Fri, 16 Oct 2026 07:58:45 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93f1a197bd2sm231474285a.29.2026.10.16.07.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 07:58:44 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xHjON-00000001tP5-3WxW; Fri, 16 Oct 2026 11:58:43 -0300 Date: Fri, 16 Oct 2026 11:58:43 -0300 From: Jason Gunthorpe To: Baolu Lu Cc: Xu Yilun , iommu@lists.linux.dev, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Kevin Tian , Kiryl Shutsemau , Rick Edgecombe , xiaoyao.li@intel.com, Chao Gao , Binbin Wu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] coco/tdx-host: Initialize trusted DMA on all capable IOMMUs Message-ID: <20261016145843.GF14213@ziepe.ca> References: <20261015010705.1973284-1-baolu.lu@linux.intel.com> <20261015010705.1973284-5-baolu.lu@linux.intel.com> <20261015173707.GV14213@ziepe.ca> <5ca5f1c4-4c3c-47f1-b79c-c1fe06b20ee4@linux.intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ca5f1c4-4c3c-47f1-b79c-c1fe06b20ee4@linux.intel.com> On Fri, Oct 16, 2026 at 03:03:23PM +0800, Baolu Lu wrote: > On 10/16/2026 1:37 AM, Jason Gunthorpe wrote: > > On Thu, Oct 15, 2026 at 04:31:31PM +0800, Xu Yilun wrote: > > > > > An alternative could be, bringing up one IOMMU when an associated > > > device requests link encryption. Then a no-tdx-support iommu fails the > > > encryption request naturally. > > That is what ARM is planning to do. I think it is reasonable to > > trigger creation of the secure iommu when the TSM is connected to TDX. > > > > Fail connect if the iommu could not be created. > > Yes, agreed. The Intel iommu driver could use per-device interfaces, > just as ARM is planning. There are some differences, though. > > ARM's interaction with the iommu driver in viommu_init() appears to > consist of two steps: > > - arm_smmu_get_realm_params(dev, ¶ms): get and validate the > physical iommu information from the arm-smmu-v3 driver; > - cca_psmmu_get(¶ms): activate the physical smmu for Realm use. Okay, I haven't looked, not sure what is in cca_psmmu_get() yet > So the Intel iommu driver will probably end up with interfaces like: > > - dmar_tdxcs_iommu_init(struct device *dev, ...); > - dmar_tdxcs_iommu_release(struct device *dev, ...); > > These would be called from the connect and disconnect callbacks of > the TDX link ops: It seems OK It sounds like you will have a one time init of the secure iommu at the time the first PCI device wants to use the TSM? It seems like no problem. Jason